From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE867C433FE for ; Mon, 13 Dec 2021 06:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbhLMGBM (ORCPT ); Mon, 13 Dec 2021 01:01:12 -0500 Received: from muru.com ([72.249.23.125]:37936 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbhLMGBM (ORCPT ); Mon, 13 Dec 2021 01:01:12 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 736E3809F; Mon, 13 Dec 2021 06:01:53 +0000 (UTC) Date: Mon, 13 Dec 2021 08:01:09 +0200 From: Tony Lindgren To: Merlijn Wajer Cc: Ivaylo Dimitrov , Dev Null , Sebastian Reichel , linux-omap@vger.kernel.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/2] Droid3: add initial DTS Message-ID: References: <20211212230459.13579-1-merlijn@wizzup.org> <20211212230459.13579-3-merlijn@wizzup.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211212230459.13579-3-merlijn@wizzup.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Merlijn Wajer [211212 23:00]: > @@ -35,7 +35,7 @@ reserved-memory { > * first 512K of that and just overwrite the rest and configure > * only 384K instead of 2M. > */ > - ramoops@a0080000 { > + ramoops0: ramoops@a0080000 { > compatible = "ramoops"; > reg = <0xa0080000 0x60000>; > record-size = <0x20000>; The stock kernel ramoops range might be different here because of less memory. If the stock kernel has it, it should be in the platform data somewhere in the stock kernel sources. Probably best to just leave it out for now. > +// Do don't know if pstore is supported, but the current config causes panics, > +// so delete the node for now > +/delete-node/ &ramoops0; Just leave this out too, I don't think we have the ramoops configured in the mainline kernel. Otherwise looks good to me. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD7CC433EF for ; Mon, 13 Dec 2021 06:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pGjb98ZTAGmAsXe6fZohTNlMjvnpmr/kihgaS8ZzrKc=; b=RWonnMsGm1OqXZ wRdpucdeJz//QRKj7SHSeZIe2N6Bt/rysVSbaYIjam4QcJF62qfwpIt6U/WSa16Q538Fq8cJbCq5D 6AT93Sr2HVP5NAHZGVRjPE+TZ+jLYqLKnElgjM8jWkIlfMHKDcO+v27K5YwaPHURjSpyXQMF0b68J vh1zvsp7ZEaUWvDKMkpUwdNKJlL7lilNr7AQl0gxS1QG36KQv0tgulotQ2tUuPVSGzNmwTSyovi20 CnsLgSRg3Dv8kJXFHxaDzwsE90R4r//Hjq04Ah7LQH4A6rKtsVg8UgcM9LhFPKfbTlONYHSonE8tg 1PeYnzSbBZRWaZ7sOdSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mweOh-007uOk-Ka; Mon, 13 Dec 2021 06:01:15 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mweOe-007uO6-0s for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 06:01:13 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 736E3809F; Mon, 13 Dec 2021 06:01:53 +0000 (UTC) Date: Mon, 13 Dec 2021 08:01:09 +0200 From: Tony Lindgren To: Merlijn Wajer Cc: Ivaylo Dimitrov , Dev Null , Sebastian Reichel , linux-omap@vger.kernel.org, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/2] Droid3: add initial DTS Message-ID: References: <20211212230459.13579-1-merlijn@wizzup.org> <20211212230459.13579-3-merlijn@wizzup.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211212230459.13579-3-merlijn@wizzup.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211212_220112_134808_0C7E8548 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Merlijn Wajer [211212 23:00]: > @@ -35,7 +35,7 @@ reserved-memory { > * first 512K of that and just overwrite the rest and configure > * only 384K instead of 2M. > */ > - ramoops@a0080000 { > + ramoops0: ramoops@a0080000 { > compatible = "ramoops"; > reg = <0xa0080000 0x60000>; > record-size = <0x20000>; The stock kernel ramoops range might be different here because of less memory. If the stock kernel has it, it should be in the platform data somewhere in the stock kernel sources. Probably best to just leave it out for now. > +// Do don't know if pstore is supported, but the current config causes panics, > +// so delete the node for now > +/delete-node/ &ramoops0; Just leave this out too, I don't think we have the ramoops configured in the mainline kernel. Otherwise looks good to me. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel