From: Zev Weiss <zev@bewilderbeest.net>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
ChiaWei Wang <chiawei_wang@aspeedtech.com>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc] pinctrl: ast2400: add support for TXD3/RXD3 pins
Date: Mon, 13 Dec 2021 17:33:00 -0800 [thread overview]
Message-ID: <Ybf0TApJEEaM4FDL@hatter.bewilderbeest.net> (raw)
In-Reply-To: <HK0PR06MB338026E6233FBF845BF04F5EF2759@HK0PR06MB3380.apcprd06.prod.outlook.com>
On Mon, Dec 13, 2021 at 05:22:52PM PST, Ryan Chen wrote:
>Hello,
> You may need claim for function group for link, not for pin link.
> Ex.
> static struct aspeed_sig_desc uart3_link[] = {
> { 0x80, BIT(22), 0},
> { 0x80, BIT(23), 0},
> }
>
> ast2400_groups[] = {
> { "UART3", 2, uart3_link },
>Ryan
Hi Ryan,
That possibility occurred to me, but the existing function/group names
in arch/arm/dts/ast2400.dtsi (lines 1130-1133 and 1375-1378) made me
think they should be separate. I'm certainly not an expert on pinctrl
stuff though...is there some other existing logic or mechanism to link a
"UART3" to the separate "TXD3" and "RXD3" in the device tree?
Zev
next prev parent reply other threads:[~2021-12-14 1:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:47 [PATCH u-boot v2019.04-aspeed-openbmc] pinctrl: ast2400: add support for TXD3/RXD3 pins Zev Weiss
2021-12-14 1:22 ` Ryan Chen
2021-12-14 1:33 ` Zev Weiss [this message]
2021-12-14 1:39 ` Ryan Chen
2021-12-14 3:20 ` Zev Weiss
2021-12-14 3:29 ` Ryan Chen
2021-12-14 3:43 ` Zev Weiss
2021-12-14 5:21 ` Ryan Chen
2021-12-15 2:50 ` Zev Weiss
2021-12-15 5:30 ` Ryan Chen
2022-01-25 17:32 ` Zev Weiss
2022-01-31 6:25 ` Joel Stanley
2022-01-31 7:56 ` Zev Weiss
2022-02-07 6:46 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybf0TApJEEaM4FDL@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=chiawei_wang@aspeedtech.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.