From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22EFFC433EF for ; Tue, 14 Dec 2021 11:27:22 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EB69B3C8B60 for ; Tue, 14 Dec 2021 12:27:19 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C4E953C7621 for ; Tue, 14 Dec 2021 12:27:10 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id DEE43600807 for ; Tue, 14 Dec 2021 12:27:09 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E9B092112A; Tue, 14 Dec 2021 11:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639481228; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kOYTpWZvgTmjkqXS/kImWfQ5Yao6Psvpw0iGVJq50fM=; b=Bur7/qlAqhB6Q3lB/05lpjubzXkg7Po6xX12Ke7SbmpNK3Fld8xTvvPQWupB9Uioo9lSgK WPnq1VpLcyK+WnTEwFLYr0Pd7xD/AhgZKOT7C9vDTsIFX0BYQ6IUCuIz4JuLTQmsDbAUEs KbAEu24I3PUX4fahmHb0knOooqpbDDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639481228; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kOYTpWZvgTmjkqXS/kImWfQ5Yao6Psvpw0iGVJq50fM=; b=qXaBNlJIcFRTz07ubMZbX/WM5+1Mub05qukeyJjmLBDWHMTfT9j3AhlFv24fTZ2C4LjWPP x4Otqf/c3F3+UEAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9D2513BA4; Tue, 14 Dec 2021 11:27:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8Dp4Kox/uGF3agAAMHmgww (envelope-from ); Tue, 14 Dec 2021 11:27:08 +0000 Date: Tue, 14 Dec 2021 12:27:06 +0100 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20211213193419.13414-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, > Hi! > > > My only concern is that the variable name is too long and not easy > > > to remember/understand usage. Can we find a better name? > > > LTP_ONE_FS_TYPE > > > LTP_ASGD_FD_TYPE > > > LTP_FS_TYPE_DEBUG > > Yes, it's too long. LTP_FS_TYPE_DEBUG sounds best to me, but no strong opinion > > about it. > Not sure about the "DEBUG" in the name. I would go for a variation of > the first name "LTP_SINGLE_FS_TYPE" or "LTP_LIMIT_FS_TYPE" LTP_SINGLE_FS_TYPE looks better for me, because I'd understand LIMIT to run fewer filesystems but possibly more than one. > > If we agree we want this, we can consider to use some switch instead or print > > this variable in help output (-h), with other variables from > > https://github.com/linux-test-project/ltp/wiki/User-Guidelines. > Printing the variables on -h does sounds reasonabe. +1 (post v2). Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp