From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Add io_read_eof in common.h utilities
Date: Tue, 14 Dec 2021 17:40:49 +0100 [thread overview]
Message-ID: <YbjJEVJq3vQchSBO@pevik> (raw)
In-Reply-To: <20211213121417.21825-1-andrea.cervesato@suse.com>
Hi,
...
> +static inline void io_read_eof(const char *filename, volatile int *run_child)
> +{
> + char buff[4096];
> + int fd;
> + int r;
> +
> + while ((fd = open(filename, O_RDONLY, 0666)) < 0)
Just for a record [1] this open should be checked for errno == EINVAL
in case of /tmp/ being tmpfs.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/YbjIqypOcAYAnLbl@pevik/T/#t
> + usleep(100);
> +
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-14 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 12:14 [LTP] [PATCH v2] Add io_read_eof in common.h utilities Andrea Cervesato via ltp
2021-12-14 16:40 ` Petr Vorel [this message]
2021-12-15 13:06 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbjJEVJq3vQchSBO@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.