From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 344C7C433EF for ; Wed, 15 Dec 2021 05:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0BpF1dBZybqSKBMRYRxOgp0Y6MxyGJPd7Qd+/WV3uqU=; b=vKvCkn2gHF+1ke sx3XwKqW2iCFzA6yR/V+oZHN/+OPoOUHDaHxHn6eo1b6rutV6RakKdCoNBY3PBGtFAfUtU8I3wqcu BeXli14lTkB1rFPPldbdqHWdRjODxdvaSbp/ShTSc04XYWxgNBXO/hJehlZsNTtA+4s+50HOUpv4q g9jFL/TGMf8VOUjrLvzOz9rgJQ8XuBAPYgKncp3QSeEWA8uWXp2OjYtyOCTGRnTK2UQdDSv3ULmxR O2r1cZuN1bLQZQ+zLq9A9VYEAg1csc73C3bjnCBKscSIY7I0ZZYcCnm3KetrlY1U0T62VuYcfb5FW WvUJoJdXy8pkFdc9Zy4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxNGc-00Gl89-3C; Wed, 15 Dec 2021 05:55:54 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxNGZ-00Gl6N-LU for linux-mediatek@lists.infradead.org; Wed, 15 Dec 2021 05:55:52 +0000 Received: by mail-pf1-x431.google.com with SMTP id u80so19745682pfc.9 for ; Tue, 14 Dec 2021 21:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=kDowek4cSSKDkV4UGyJuXyqi5JIWAReO4OxHgYeFCA2HgFjEt1CmeiAM/M29ggFdWg zDA/vFKSK9uddEPsw6wgIXwmAHpCHwIGsC3J/1ibKr0pCY02/gmpC/7BEgpLr/c4ATlC L3nLg9A3lMltpboAcgF5Vbiohm/XRqfAc6EERoIOQoo/W0TrNgmv4Sgo3e6xJjP+J/19 4hBUComVDTtx8ThzXRwuIHX16u61zSn3cVAorIsKN+qBdjiiNhlbPIqoOlNh/vYW33HJ 9LaKqv8Cfwn8Hk4NM7gRBQU/s3wspmVc7BIW1GQm67V9cop79vBDzKcQPPSZmi3etjlo An/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=1cwHrDA1F6K3ymwjPp8ZblN44rQsRjA5q4uhbLaqbLi49gk/ZWqK+PocrG+BIaIJrG r9vRTsp9yVLWxY5FI/X6gObEU9sax0LwiEMuu1E1Hpm5+pcgX2QCyfn1ZotTCfjLAt/k tt2bWYeupMQhB3HGLI4TVQwrUHm9UCSxe9bBkpw9H7/otKoC8nzIKmP0f2SlrN0ETGgK 9f8YVBCq3AcsOKAgZrVAyRl7bKqtKtaXnDLFvWhcvPO8NXA8NmJOMYtyTg9UiaO7xrLA qXBU8WNrkHJKT8KVHlMhq5qjkfEpcom2UAgfkIlcPxjo2r/fxzMXX6/T4LzYf4fj3P1F VYYg== X-Gm-Message-State: AOAM530lVL2k+5JA62tGYnrK0yPSCf0II+7khrMOP/cQHVS5RI4TCNRa 6FbDutMNR2TdWCyXcPGWOikHXA== X-Google-Smtp-Source: ABdhPJxJk9jvjtHfRNmilmy4wTT3wZeaD4iKsJSZSfKzYHurbYvLQ7MyZFm9b5pPFVNOYSjjm5goIA== X-Received: by 2002:a63:102:: with SMTP id 2mr6802124pgb.311.1639547750606; Tue, 14 Dec 2021 21:55:50 -0800 (PST) Received: from google.com ([2401:fa00:1:10:754d:1c44:62a9:6d30]) by smtp.gmail.com with ESMTPSA id k22sm1015260pfu.72.2021.12.14.21.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 21:55:50 -0800 (PST) Date: Wed, 15 Dec 2021 13:55:47 +0800 From: Tzung-Bi Shih To: Jiasheng Jiang Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer Message-ID: References: <20211215052157.94172-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_215551_730398_1261981E X-CRM114-Status: UNSURE ( 7.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote: > The return value of devm_kzalloc() needs to be checked. > To avoid use of null pointer in case of thefailure of alloc. > > Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files") > Signed-off-by: Jiasheng Jiang With a nit: s/thefailure/the failure/ Reviewed-by: Tzung-Bi Shih _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81C03C433F5 for ; Wed, 15 Dec 2021 05:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VdDdZg5vabMNZwJPIifhJ+iZbyCnzQVD8CzR95TOzlU=; b=A607xY8r/IunqT DkLaO1eWEIitGJXv+nEzHz/cOtLxIEjx5M3v7kohKRZIouRAkfXtFPaJX0gbExmZKLc/fmedRp148 Zad7vZ+aO+iaAms/HoYehRZ7iD2NxaIbqWofECT5oqAL5ytEZ8oPcZmEvDtx1u9zl4/hC0wr2vVe6 uMAknwgsbEywnn/2Z1QU0i4ZYZfOZBXy1ZTjB+ybsRSffQl0O8i9CVSvAcjw07eJBD/4aLvBsx8JE 5xVhDWoE0SefDrFP36Bb8ZPcECRAwp7trDnF4m38cmtJpdFoboqcqhpwfDWOM+121mlDvIM4IHOTO pmkilNUhAiiwbVTuaz/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxNGd-00Gl8U-Ui; Wed, 15 Dec 2021 05:55:56 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxNGZ-00Gl6O-LZ for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 05:55:52 +0000 Received: by mail-pg1-x52d.google.com with SMTP id r5so19275259pgi.6 for ; Tue, 14 Dec 2021 21:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=kDowek4cSSKDkV4UGyJuXyqi5JIWAReO4OxHgYeFCA2HgFjEt1CmeiAM/M29ggFdWg zDA/vFKSK9uddEPsw6wgIXwmAHpCHwIGsC3J/1ibKr0pCY02/gmpC/7BEgpLr/c4ATlC L3nLg9A3lMltpboAcgF5Vbiohm/XRqfAc6EERoIOQoo/W0TrNgmv4Sgo3e6xJjP+J/19 4hBUComVDTtx8ThzXRwuIHX16u61zSn3cVAorIsKN+qBdjiiNhlbPIqoOlNh/vYW33HJ 9LaKqv8Cfwn8Hk4NM7gRBQU/s3wspmVc7BIW1GQm67V9cop79vBDzKcQPPSZmi3etjlo An/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=oM+N+nPo1jf0Ey2DByRuhff17mV/yog+8MewfV1lhbZaARvm2AtLl67zGIIwlhSz/e vEDfgT06du+4l+UW5REGOVat7Y/GpEWiptTxyC6Q8X0Mw2b88B8+1hgY6Qcg3xtp2YXv o5Zlgvw1mIAT676wuS8B3EZSzJSd1yOsMBU/3at+n72P1GRd35o6+ZLIkVnE5zq72swE nbmJS09ZXgCAaYrlk2byILJLQuc0TR52aQutieM7627roLTzAeNz2d6UIr/r/5ZqCBPK 9W49SKrh9Hbnjza4S+yAryDIWIAv75puON1qX6AyDQq32qltz5Qyz+4qIxcPFdW0z0jS FVVA== X-Gm-Message-State: AOAM533qt6yZi2EdCGRyAiy8VoXkUbS+mfjEYH6GpOI3qhh33b77/YBk rP3ySAH1hCvibyfBhR9hR951Pg== X-Google-Smtp-Source: ABdhPJxJk9jvjtHfRNmilmy4wTT3wZeaD4iKsJSZSfKzYHurbYvLQ7MyZFm9b5pPFVNOYSjjm5goIA== X-Received: by 2002:a63:102:: with SMTP id 2mr6802124pgb.311.1639547750606; Tue, 14 Dec 2021 21:55:50 -0800 (PST) Received: from google.com ([2401:fa00:1:10:754d:1c44:62a9:6d30]) by smtp.gmail.com with ESMTPSA id k22sm1015260pfu.72.2021.12.14.21.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 21:55:50 -0800 (PST) Date: Wed, 15 Dec 2021 13:55:47 +0800 From: Tzung-Bi Shih To: Jiasheng Jiang Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer Message-ID: References: <20211215052157.94172-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_215551_733952_2AAB1F4D X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote: > The return value of devm_kzalloc() needs to be checked. > To avoid use of null pointer in case of thefailure of alloc. > > Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files") > Signed-off-by: Jiasheng Jiang With a nit: s/thefailure/the failure/ Reviewed-by: Tzung-Bi Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 249BDC433EF for ; Wed, 15 Dec 2021 05:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237758AbhLOFzw (ORCPT ); Wed, 15 Dec 2021 00:55:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233244AbhLOFzv (ORCPT ); Wed, 15 Dec 2021 00:55:51 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 496F5C061574 for ; Tue, 14 Dec 2021 21:55:51 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id i12so19764409pfd.6 for ; Tue, 14 Dec 2021 21:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=kDowek4cSSKDkV4UGyJuXyqi5JIWAReO4OxHgYeFCA2HgFjEt1CmeiAM/M29ggFdWg zDA/vFKSK9uddEPsw6wgIXwmAHpCHwIGsC3J/1ibKr0pCY02/gmpC/7BEgpLr/c4ATlC L3nLg9A3lMltpboAcgF5Vbiohm/XRqfAc6EERoIOQoo/W0TrNgmv4Sgo3e6xJjP+J/19 4hBUComVDTtx8ThzXRwuIHX16u61zSn3cVAorIsKN+qBdjiiNhlbPIqoOlNh/vYW33HJ 9LaKqv8Cfwn8Hk4NM7gRBQU/s3wspmVc7BIW1GQm67V9cop79vBDzKcQPPSZmi3etjlo An/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=or349biYLFpL+w0ZA3FfJe1BgIFAwbYkc2y2ZXxAeHw=; b=ivoxv2/5sk61uxCHG+LQAjsV/g9jmxEf8coszoWMsmvO2OFTIzLSbyfAquv/eYS+42 ro+tHj2L1oL64WW6irJaEDsls/JjtQDomX/3C/5g9anHTvtjFGLB54XP1XnghQE7gLiP nNrJa070ArxHLmnl0n5fAYudSKTz+qVeGeCaRDWw2ZyQ5fYTlpFwFU1tlCjaSfkRpJI1 w4Ip4pJZkd0UG26MdV3dkN3CQXYA1digrUC3CqWdzr8yqdzNw0i2/MyhP2pxhIi76rP1 yoa1ryNkpISoa3SX9R5Ko5VfeVk0o597HPgGcU6IcAcA/Dbg0j5eGRJ+CaYedBUb2usB vZ7w== X-Gm-Message-State: AOAM531ZHx5XFWzp/nBUOPbppX4QdLCDK6w6K5NIssbqUIKFZa0XuvpN AEnf0zFJRxzQvZSeYaz5FbqzRQ== X-Google-Smtp-Source: ABdhPJxJk9jvjtHfRNmilmy4wTT3wZeaD4iKsJSZSfKzYHurbYvLQ7MyZFm9b5pPFVNOYSjjm5goIA== X-Received: by 2002:a63:102:: with SMTP id 2mr6802124pgb.311.1639547750606; Tue, 14 Dec 2021 21:55:50 -0800 (PST) Received: from google.com ([2401:fa00:1:10:754d:1c44:62a9:6d30]) by smtp.gmail.com with ESMTPSA id k22sm1015260pfu.72.2021.12.14.21.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 21:55:50 -0800 (PST) Date: Wed, 15 Dec 2021 13:55:47 +0800 From: Tzung-Bi Shih To: Jiasheng Jiang Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: mtk-vcodec: potential dereference of null pointer Message-ID: References: <20211215052157.94172-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211215052157.94172-1-jiasheng@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Dec 15, 2021 at 01:21:57PM +0800, Jiasheng Jiang wrote: > The return value of devm_kzalloc() needs to be checked. > To avoid use of null pointer in case of thefailure of alloc. > > Fixes: 46233e91fa24 ("media: mtk-vcodec: move firmware implementations into their own files") > Signed-off-by: Jiasheng Jiang With a nit: s/thefailure/the failure/ Reviewed-by: Tzung-Bi Shih