From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA7AC433EF for ; Wed, 15 Dec 2021 14:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243270AbhLOORM (ORCPT ); Wed, 15 Dec 2021 09:17:12 -0500 Received: from mga04.intel.com ([192.55.52.120]:44608 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243291AbhLOORI (ORCPT ); Wed, 15 Dec 2021 09:17:08 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="237973151" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="237973151" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:17:08 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="567937520" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:16:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mxV4Z-006d5b-Tn; Wed, 15 Dec 2021 16:15:59 +0200 Date: Wed, 15 Dec 2021 16:15:59 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Linus Walleij , Marc Zyngier , Sam Shih , Zhiyong Tao , Ludovic Desroches , Claudiu Beznea , Radim Pavlik , Kavyasree Kotagiri , Colin Foster , Douglas Anderson , Bjorn Andersson , Dmitry Baryshkov , Herve Codina , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-actions@lists.infradead.org, Linux Kernel Mailing List , bcm-kernel-feedback-list , linux-rpi-kernel , - , ALSA Development Mailing List , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , Linux-Renesas , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Charles Keepax , Richard Fitzgerald , Sean Wang , Basavaraj Natikar , Shyam Sundar S K , Nicolas Ferre , Alexandre Belloni , Support Opensource , Baruch Siach , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Andy Gross , Geert Uytterhoeven , Viresh Kumar , Shiraz Hashim , arm-soc Subject: Re: [PATCH v1 1/2] pinctrl: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211213163929.7509-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Dec 15, 2021 at 11:28:34AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 13, 2021 at 5:40 PM Andy Shevchenko > wrote: > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > drivers/pinctrl/renesas/pinctrl-rza2.c | 1 - > > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Thanks, there is v2 with this patch w/o changes. I take a liberty to extrapolate the tags to it. I need to send a v3 in case Linus hasn't taken the first patch before it happens. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E3FC433F5 for ; Wed, 15 Dec 2021 14:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k+ZKPKDp2bsPmcYILGLo90RMa0PV+MFQlp9vjp4Z+As=; b=X6nQIzXs5PlbxF MGB/3p8qFZNcsJLmY2DtxQq3NmL3c2nJ35CESSOxK3j49Hc5U6tQj3YkFra21mXTsC6idIvO7pq+L OG4GkNPQoDY1aaC1/oOZsn9bSlh1rDvy1YnIoR9CO0XJE+7TVkShCmSnulQNnv6Y2s1dH21yUQFuC FTjJGFJ2sZjxVS0x407GlKSldl3FUGRP67mVEZ61b+edRNrldZjK3vpQSARnD5nitssiTLV0uBXc2 MF/UZbC4Ttz8yRxt/FVdb6zS1aEGZGpq7Jcmm1y4J3RpTawrUkZTshftQdz250X8kt+dg4R7Y+I6+ ZIbZwHHH4QGFPJslBqHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxVAc-001897-Fl; Wed, 15 Dec 2021 14:22:14 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxV7e-00166k-KO; Wed, 15 Dec 2021 14:19:11 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="236771189" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="236771189" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:17:08 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="567937520" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 06:16:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mxV4Z-006d5b-Tn; Wed, 15 Dec 2021 16:15:59 +0200 Date: Wed, 15 Dec 2021 16:15:59 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Linus Walleij , Marc Zyngier , Sam Shih , Zhiyong Tao , Ludovic Desroches , Claudiu Beznea , Radim Pavlik , Kavyasree Kotagiri , Colin Foster , Douglas Anderson , Bjorn Andersson , Dmitry Baryshkov , Herve Codina , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-actions@lists.infradead.org, Linux Kernel Mailing List , bcm-kernel-feedback-list , linux-rpi-kernel , - , ALSA Development Mailing List , linux-mediatek@lists.infradead.org, linux-oxnas@groups.io, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm , Linux-Renesas , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Charles Keepax , Richard Fitzgerald , Sean Wang , Basavaraj Natikar , Shyam Sundar S K , Nicolas Ferre , Alexandre Belloni , Support Opensource , Baruch Siach , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Andy Gross , Geert Uytterhoeven , Viresh Kumar , Shiraz Hashim , arm-soc Subject: Re: [PATCH v1 1/2] pinctrl: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211213163929.7509-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_061910_731326_B83AA52B X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Dec 15, 2021 at 11:28:34AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 13, 2021 at 5:40 PM Andy Shevchenko > wrote: > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > drivers/pinctrl/renesas/pinctrl-rza2.c | 1 - > > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Thanks, there is v2 with this patch w/o changes. I take a liberty to extrapolate the tags to it. I need to send a v3 in case Linus hasn't taken the first patch before it happens. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek