All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Prashant Malani <pmalani@chromium.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" 
	<linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] acpi: Store the Physical Location of Device (_PLD) information
Date: Wed, 15 Dec 2021 15:08:27 +0200	[thread overview]
Message-ID: <Ybnoy9e6VvFsJ4b1@kuha.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0jq5ve9+V3k5Vi=vJAheSyQbAsNmi6An9=oKxkyVed5bw@mail.gmail.com>

Hi Rafael,

On Wed, Dec 15, 2021 at 12:43:48PM +0100, Rafael J. Wysocki wrote:
> One overall problem I see here is that it potentially stores a bunch
> of _PLD buffers that will never be used, which is a waste of memory.
> 
> It may be better to make acpi_device_get_location() evaluate _PLD for
> the target device if it cannot be found in the list and either update
> one of the existing entries if the crc matches and return the pld data
> from there, or add a new item to the list and return its pld data.

The primary goal of this series is actually to see the other devices
that share a fixed location with our device. The _PLD buffer cache
would be nice, but not necessary. We don't have to store the _PLD
buffer itself as part of the location structure at all if that's a
problem.

I'll make the change.

thanks,

-- 
heikki

  reply	other threads:[~2021-12-15 13:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 10:32 [PATCH v2 0/5] acpi: Store _PLD information and convert users Heikki Krogerus
2021-12-13 10:32 ` [PATCH v2 1/5] acpi: Store the Physical Location of Device (_PLD) information Heikki Krogerus
2021-12-15 11:43   ` Rafael J. Wysocki
2021-12-15 13:08     ` Heikki Krogerus [this message]
2021-12-15 14:52       ` Rafael J. Wysocki
2021-12-13 10:32 ` [PATCH v2 2/5] usb: Use the cached ACPI _PLD entry Heikki Krogerus
2021-12-13 10:32 ` [PATCH v2 3/5] usb: Link the ports to the connectors they are attached to Heikki Krogerus
2021-12-13 10:32 ` [PATCH v2 4/5] usb: typec: port-mapper: Convert to the component framework Heikki Krogerus
2021-12-13 10:32 ` [PATCH v2 5/5] usb: Remove usb_for_each_port() Heikki Krogerus
2021-12-13 12:10 ` [PATCH v2 0/5] acpi: Store _PLD information and convert users Andy Shevchenko
2021-12-14 23:04 ` Prashant Malani
2021-12-15 10:56 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ybnoy9e6VvFsJ4b1@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.