From: Greg KH <gregkh@linuxfoundation.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.15] staging: most: dim2: use device release method
Date: Wed, 15 Dec 2021 14:30:05 +0100 [thread overview]
Message-ID: <Ybnt3WY+VH2qE6xd@kroah.com> (raw)
In-Reply-To: <20211213181346.989171-1-nikita.yoush@cogentembedded.com>
On Mon, Dec 13, 2021 at 09:13:46PM +0300, Nikita Yushchenko wrote:
> Upstream commit d445aa402d60014a37a199fae2bba379696b007d.
>
> Commit 723de0f9171e ("staging: most: remove device from interface
> structure") moved registration of driver-provided struct device to
> the most subsystem. This updated dim2 driver as well.
>
> However, struct device passed to register_device() becomes refcounted,
> and must not be explicitly deallocated, but must provide release method
> instead. Which is incompatible with managing it via devres.
>
> This patch makes the device structure allocated without devres, adds
> device release method, and moves device destruction there.
>
> Fixes: 723de0f9171e ("staging: most: remove device from interface structure")
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Link: https://lore.kernel.org/r/20211005143448.8660-2-nikita.yoush@cogentembedded.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/most/dim2/dim2.c | 55 +++++++++++++++++---------------
> 1 file changed, 30 insertions(+), 25 deletions(-)
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-12-15 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 8:03 FAILED: patch "[PATCH] staging: most: dim2: use device release method" failed to apply to 5.15-stable tree gregkh
2021-12-13 18:13 ` [PATCH 5.15] staging: most: dim2: use device release method Nikita Yushchenko
2021-12-15 13:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybnt3WY+VH2qE6xd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.