From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CD9C433F5 for ; Wed, 15 Dec 2021 16:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244143AbhLOQDY (ORCPT ); Wed, 15 Dec 2021 11:03:24 -0500 Received: from mail-ot1-f45.google.com ([209.85.210.45]:33392 "EHLO mail-ot1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbhLOQDX (ORCPT ); Wed, 15 Dec 2021 11:03:23 -0500 Received: by mail-ot1-f45.google.com with SMTP id 35-20020a9d08a6000000b00579cd5e605eso25547257otf.0; Wed, 15 Dec 2021 08:03:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xe/HfKxTm30DSYVeCryK/T+prtaOXtlQsHhhgKcn9BA=; b=2Azru8x7BKG7AJivHgBTrBGgXVqwBHPgt7obmoJc/milMBuNj9Ey7/5/gDBuIHsHJu TB3gxOybfiLJi7Ulj6FFEg/p4BBbsDRskUDCLOfmNKy0pTAXuOx+T20Ajqlcsc/KvU6U vcMo5LB/tiEHMf7GaF9w9j6H3EEz3VmEa4X067A5bh9D/46keBP1zWPHmWIkeTl942k6 L7fleLjStpOhPMc0CrYnissASoEAuRSQmNECtJIdC1MB6KEuS43lVwnhO91Biq+BIVpd 1J7OX3xfpnEk4so4ITRb1R9n9vehsdvl6OVifaxehKgWGEMaZ6aD+yJoBiwZXVsq8W2W LG+g== X-Gm-Message-State: AOAM532Q70r5YuZ1CMM2WqhuBH/IMMDr32besy/afBRGHIhmFQo1qELZ 7j6DTxnYr6QdXQV5pFyMrQ== X-Google-Smtp-Source: ABdhPJyc26sAWDjW5Ma9yjRYf51V/CNKMYBUkWE2k3ib18TK3TN8L2LhtWUymRdccSZjKJnaYOWe2Q== X-Received: by 2002:a9d:12f3:: with SMTP id g106mr9156177otg.175.1639584203012; Wed, 15 Dec 2021 08:03:23 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o10sm505242oom.32.2021.12.15.08.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:03:22 -0800 (PST) Received: (nullmailer pid 1396374 invoked by uid 1000); Wed, 15 Dec 2021 16:03:21 -0000 Date: Wed, 15 Dec 2021 10:03:21 -0600 From: Rob Herring To: Roger Quadros Cc: krzysztof.kozlowski@canonical.com, tony@atomide.com, kishon@ti.com, nm@ti.com, vigneshr@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/4] memory: omap-gpmc: check for nand node name instead of just compatibility Message-ID: References: <20211208124611.16843-1-rogerq@kernel.org> <20211208124611.16843-3-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208124611.16843-3-rogerq@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Dec 08, 2021 at 02:46:10PM +0200, Roger Quadros wrote: > We have added new compatibles for controller so just checking for > "ti,omap2-nand" compatible is not enough. Check for "nand" node name > as well. > > Signed-off-by: Roger Quadros > --- > drivers/memory/omap-gpmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index 624153048182..9f0062a262db 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2183,7 +2183,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, > } > } > > - if (of_device_is_compatible(child, "ti,omap2-nand")) { > + if (of_device_is_compatible(child, "ti,omap2-nand") || > + of_node_name_eq(child, "nand")) { It would be better to stick with compatible strings. You can match against a match table. This should be 'nand-controller' really if this binding had a proper split between the controller and nand chips. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38469C433FE for ; Wed, 15 Dec 2021 16:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T8fFDOi764T+PaDFQXDFQklGx4lszNuAvVnsBmgdzsQ=; b=FyrAn//NC6xYxs H8SQbqmQpClj9vfqy+kmNy9Abww25PAVGlaoBtcVZCl31XEA2Xyo02QLmIolokzjVmOxWpwsgrWD8 zZvc26SzlADaTR403EaAPAAaFDPaa8ukkMsfwAd3TYafcGgKPtGwYN9euHI1gRan4//yBjDURFwMB qljmvQT4XOYIRnztX6dvSUZL8NfS6bFXK3neNUTKL3mebRMZE493Sg1+nMXGnXFt4Iz7GMGZKnuzU egtvaaaBk8vBl6TfW4KVLjdtOmf5XR06C5ViLlo684fTEbxFcCc99cI2VNA5aoFHFl+CxrwDBFaTV Ob3CEyhYn8AO2K9Jih6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxWlv-001Y0V-7f; Wed, 15 Dec 2021 16:04:51 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxWkY-001XF0-R1 for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 16:03:28 +0000 Received: by mail-ot1-f46.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso25428161otf.12 for ; Wed, 15 Dec 2021 08:03:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xe/HfKxTm30DSYVeCryK/T+prtaOXtlQsHhhgKcn9BA=; b=dHaNu2s2C+ldnHggDv2Mqh8XWZC+XHHcBc3krkEQUgplZ1vckP+RF9g7nHi1Hb9Pxk +GKPvL+wFTZvf9b8/sCpLTxvcqbDqByJUHbc3OTyJ92siV9qlicPFuDt8SqfUR4ceI+g UGYLXlzBJNd4QmAQREQwyCkaQQojm4ysKpzvUvtkuImpVsLACkg9ROPPk+QSllsd7kE0 jjrgTNY1nZ6+5jiiL/ml0aPra/QzgrIRrJ+ALH+pDnLHu7F4RSvGyiPJH9hTDybW8HyX mpmQoxC2a4gS0ljkfv13mA5+nSh1T262aDNmGrBtfaCDyE/EP2445861usvpbpMrCQrR AlbQ== X-Gm-Message-State: AOAM532/epd2FotOMVvcawiE9P2Kdg9wc12l7e0ZYpp2ty2qlpREljEZ oqv7cpMVpNasR0tI6wl1hA== X-Google-Smtp-Source: ABdhPJyc26sAWDjW5Ma9yjRYf51V/CNKMYBUkWE2k3ib18TK3TN8L2LhtWUymRdccSZjKJnaYOWe2Q== X-Received: by 2002:a9d:12f3:: with SMTP id g106mr9156177otg.175.1639584203012; Wed, 15 Dec 2021 08:03:23 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o10sm505242oom.32.2021.12.15.08.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:03:22 -0800 (PST) Received: (nullmailer pid 1396374 invoked by uid 1000); Wed, 15 Dec 2021 16:03:21 -0000 Date: Wed, 15 Dec 2021 10:03:21 -0600 From: Rob Herring To: Roger Quadros Cc: krzysztof.kozlowski@canonical.com, tony@atomide.com, kishon@ti.com, nm@ti.com, vigneshr@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/4] memory: omap-gpmc: check for nand node name instead of just compatibility Message-ID: References: <20211208124611.16843-1-rogerq@kernel.org> <20211208124611.16843-3-rogerq@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208124611.16843-3-rogerq@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_080326_921437_9C647D93 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 02:46:10PM +0200, Roger Quadros wrote: > We have added new compatibles for controller so just checking for > "ti,omap2-nand" compatible is not enough. Check for "nand" node name > as well. > > Signed-off-by: Roger Quadros > --- > drivers/memory/omap-gpmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index 624153048182..9f0062a262db 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2183,7 +2183,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, > } > } > > - if (of_device_is_compatible(child, "ti,omap2-nand")) { > + if (of_device_is_compatible(child, "ti,omap2-nand") || > + of_node_name_eq(child, "nand")) { It would be better to stick with compatible strings. You can match against a match table. This should be 'nand-controller' really if this binding had a proper split between the controller and nand chips. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel