From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com,
william.roche@oracle.com
Subject: Re: [PATCH v2 1/2] EDAC/amd64: Check register values from all UMCs
Date: Wed, 15 Dec 2021 19:01:22 +0100 [thread overview]
Message-ID: <YbotciKVDsH1Fl1H@zn.tnic> (raw)
In-Reply-To: <20211215155309.2711917-2-yazen.ghannam@amd.com>
On Wed, Dec 15, 2021 at 03:53:08PM +0000, Yazen Ghannam wrote:
> - if ((pvt->umc[0].dimm_cfg | pvt->umc[1].dimm_cfg) & BIT(5))
> + u32 umc_cfg = 0, dimm_cfg = 0, i = 0;
> +
> + for_each_umc(i) {
> + umc_cfg |= pvt->umc[i].umc_cfg;
> + dimm_cfg |= pvt->umc[i].dimm_cfg;
> + }
> +
> + if (dimm_cfg & BIT(5))
> pvt->dram_type = MEM_LRDDR4;
> - else if ((pvt->umc[0].dimm_cfg | pvt->umc[1].dimm_cfg) & BIT(4))
> + else if (dimm_cfg & BIT(4))
You're working here under the assumption that bit 4 and 5 will have the
same value on all those UMCs.
You're probably going to say that that is how the BIOS is programming
them so they should be all the same and any other configuration is
invalid but lemme still ask about it explicitly.
And if so, this would probably need a comment above it which I can add
when applying...
Hmm?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-12-15 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:53 [PATCH v2 0/2] AMD Family 19h Models 10h-1Fh Updates Yazen Ghannam
2021-12-15 15:53 ` [PATCH v2 1/2] EDAC/amd64: Check register values from all UMCs Yazen Ghannam
2021-12-15 18:01 ` Borislav Petkov [this message]
2021-12-16 16:08 ` Yazen Ghannam
2021-12-30 11:36 ` Borislav Petkov
2022-01-05 16:12 ` Yazen Ghannam
2021-12-15 15:53 ` [PATCH v2 2/2] EDAC/amd64: Add new register offset support and related changes Yazen Ghannam
2021-12-15 16:32 ` William Roche
2021-12-15 18:07 ` Borislav Petkov
2021-12-16 15:46 ` Yazen Ghannam
2021-12-16 18:43 ` William Roche
2021-12-16 19:21 ` Yazen Ghannam
2021-12-15 17:53 ` [PATCH v2 0/2] AMD Family 19h Models 10h-1Fh Updates Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbotciKVDsH1Fl1H@zn.tnic \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=william.roche@oracle.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.