From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: fix regression in looped (broad|multi)cast's MAC handling
Date: Thu, 16 Dec 2021 00:05:53 +0100 [thread overview]
Message-ID: <Ybp00cTdRaeespOg@salvia> (raw)
In-Reply-To: <20211210153127.i7kqadosjgw6qiqp@zenon.in.qult.net>
On Fri, Dec 10, 2021 at 04:31:27PM +0100, Ignacy Gawędzki wrote:
> In commit 5648b5e1169f ("netfilter: nfnetlink_queue: fix OOB when mac
> header was cleared"), the test for non-empty MAC header introduced in
> commit 2c38de4c1f8da7 ("netfilter: fix looped (broad|multi)cast's MAC
> handling") has been replaced with a test for a set MAC header.
>
> This breaks the case when the MAC header has been reset (using
> skb_reset_mac_header), as is the case with looped-back multicast
> packets. As a result, the packets ending up in NFQUEUE get a bogus
> hwaddr interpreted from the first bytes of the IP header.
>
> This patch adds a test for a non-empty MAC header in addition to the
> test for a set MAC header. The same two tests are also implemented in
> nfnetlink_log.c, where the initial code of commit 2c38de4c1f8da7
> ("netfilter: fix looped (broad|multi)cast's MAC handling") has not been
> touched, but where supposedly the same situation may happen.
Applied to nf, thanks
prev parent reply other threads:[~2021-12-15 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 15:31 [PATCH v3] netfilter: fix regression in looped (broad|multi)cast's MAC handling Ignacy Gawędzki
2021-12-15 23:05 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybp00cTdRaeespOg@salvia \
--to=pablo@netfilter.org \
--cc=ignacy.gawedzki@green-communications.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.