From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043A4C433F5 for ; Wed, 15 Dec 2021 19:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231913AbhLOTiw (ORCPT ); Wed, 15 Dec 2021 14:38:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbhLOTiv (ORCPT ); Wed, 15 Dec 2021 14:38:51 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F97DC061574; Wed, 15 Dec 2021 11:38:51 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id b22so592836lfb.9; Wed, 15 Dec 2021 11:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fOcjE2pXavuKbJCrwB9ewcw0SQq3JyvpjoJ4QyUms+k=; b=o5dMU0DcaUlE+/2CiW05vzfTnr1Z77oVBKfCUQNAWnB/OsBNdI4o54ecYJjM75u9vg rumPl1ANlnY1sGQ5A8QVq5e3qtaAm8tQdpLkLl6uwWVNO1qOYYy6subpsVjKQTyVYwaF 03H1MXlzz7LF7VHLRfMSOkuPwwpEwN2pV2cy+59gHDAcZluJ4dV2vm3VfCKKzjP4D1CO dVef13FjgFkkTF+9AKC/EoeP86pYpw3adJVaB3Tb4Oh/qNDgjSA3rT63sUTaCPG2OuPy BKEnXMGA8P0cCLGpbAjuV2s0vSeIsxQblkAns4Dko7VUXD3bBpkBCVsAGh0oAizWbzcL 2j/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fOcjE2pXavuKbJCrwB9ewcw0SQq3JyvpjoJ4QyUms+k=; b=q0aPhhld57jN5bfvvCD5mnnI2AiUm+fEw9JU8wMvH42kQ8gLKTSi/NBwhwaNHCFzHn qEpWJpPDnOVbqfUumSGgemsinVmWGUJkcofigR6pgTHuWCGf+Wimj2m7Z+PHuDbT1AUB 3u+R5vXuEqI/f321iHWx+qy+X9fvBDe6q/gcjpKmKN1mJ4WsFdNJnJx66hOlJwOBk4dT 2zahbCCdVWrgDZiu+mK9Uw6dmjrEaJMcYG9BglIYu6HWFJFBxD3BrA2sNKflM498KA+e S8/iAFzE1kiC+APkbc8QLMnaUNiYqVZosP6XFU3g+F/oR1bfZiAKRnMKtt8Iz+VOOr6j 5LIQ== X-Gm-Message-State: AOAM530M6wNt+10VZ7Z5DeUPjut91e8i4DTyzjSa6lFFrhenz/1xELli jjoz6Gc3ImNbq7iwaGtRjw4= X-Google-Smtp-Source: ABdhPJxHpQcpecZHC7OldNt5DYzoOYI16J+5esNrAprCo/D3ilVrZV5uhXycQ2Cd340qZ/0p+0tZhA== X-Received: by 2002:a05:6512:2347:: with SMTP id p7mr11387141lfu.304.1639597129414; Wed, 15 Dec 2021 11:38:49 -0800 (PST) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id u22sm463719lff.118.2021.12.15.11.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 11:38:48 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 15 Dec 2021 20:38:46 +0100 To: Jens Axboe , Philipp Reisner , Jason Gunthorpe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org Cc: LKML , RCU , "Paul E . McKenney" , Michal Hocko , Andrew Morton , Daniel Axtens , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Peter Zijlstra , Thomas Gleixner , "Theodore Y . Ts'o" , Sebastian Andrzej Siewior , Oleksiy Avramchenko Subject: Re: [PATCH] drdb: Switch to kvfree_rcu() API Message-ID: References: <20211215111845.2514-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211215111845.2514-1-urezki@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Dec 15, 2021 at 12:18:37PM +0100, Uladzislau Rezki (Sony) wrote: > Instead of invoking a synchronize_rcu() to free a pointer > after a grace period we can directly make use of new API > that does the same but in more efficient way. > > TO: Jens Axboe > TO: Philipp Reisner > TO: Jason Gunthorpe > TO: drbd-dev@lists.linbit.com > TO: linux-block@vger.kernel.org > Signed-off-by: Uladzislau Rezki (Sony) > --- > drivers/block/drbd/drbd_nl.c | 9 +++------ > drivers/block/drbd/drbd_receiver.c | 6 ++---- > drivers/block/drbd/drbd_state.c | 3 +-- > 3 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index 44ccf8b4f4b2..28f4d84945fd 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -1679,8 +1679,7 @@ int drbd_adm_disk_opts(struct sk_buff *skb, struct genl_info *info) > drbd_send_sync_param(peer_device); > } > > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > kfree(old_plan); > mod_timer(&device->request_timer, jiffies + HZ); > goto success; > @@ -2511,8 +2510,7 @@ int drbd_adm_net_opts(struct sk_buff *skb, struct genl_info *info) > > mutex_unlock(&connection->resource->conf_update); > mutex_unlock(&connection->data.mutex); > - synchronize_rcu(); > - kfree(old_net_conf); > + kvfree_rcu(old_net_conf); > > if (connection->cstate >= C_WF_REPORT_PARAMS) { > struct drbd_peer_device *peer_device; > @@ -2925,8 +2923,7 @@ int drbd_adm_resize(struct sk_buff *skb, struct genl_info *info) > new_disk_conf->disk_size = (sector_t)rs.resize_size; > rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); > mutex_unlock(&device->resource->conf_update); > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > new_disk_conf = NULL; > } > > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index 1f740e42e457..d73a53242a75 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -3799,8 +3799,7 @@ static int receive_protocol(struct drbd_connection *connection, struct packet_in > drbd_info(connection, "peer data-integrity-alg: %s\n", > integrity_alg[0] ? integrity_alg : "(none)"); > > - synchronize_rcu(); > - kfree(old_net_conf); > + kvfree_rcu(old_net_conf); > return 0; > > disconnect_rcu_unlock: > @@ -4168,8 +4167,7 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info > > rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); > mutex_unlock(&connection->resource->conf_update); > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > > drbd_info(device, "Peer sets u_size to %lu sectors (old: %lu)\n", > (unsigned long)p_usize, (unsigned long)my_usize); > diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c > index b8a27818ab3f..826e496821c7 100644 > --- a/drivers/block/drbd/drbd_state.c > +++ b/drivers/block/drbd/drbd_state.c > @@ -2071,8 +2071,7 @@ static int w_after_conn_state_ch(struct drbd_work *w, int unused) > conn_free_crypto(connection); > mutex_unlock(&connection->resource->conf_update); > > - synchronize_rcu(); > - kfree(old_conf); > + kvfree_rcu(old_conf); > } > > if (ns_max.susp_fen) { > -- > 2.30.2 > + Jens Axboe + Philipp Reisner + Jason Gunthorpe + drbd-dev@lists.linbit.com + linux-block@vger.kernel.org -- Vlad Rezki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 0F9A6420954 for ; Wed, 15 Dec 2021 20:38:49 +0100 (CET) Received: by mail-lf1-f45.google.com with SMTP id d10so45194752lfg.6 for ; Wed, 15 Dec 2021 11:38:49 -0800 (PST) From: Uladzislau Rezki Date: Wed, 15 Dec 2021 20:38:46 +0100 To: Jens Axboe , Philipp Reisner , Jason Gunthorpe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org Message-ID: References: <20211215111845.2514-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211215111845.2514-1-urezki@gmail.com> Cc: Michal Hocko , "Theodore Y . Ts'o" , "Paul E . McKenney" , Peter Zijlstra , Frederic Weisbecker , LKML , RCU , Oleksiy Avramchenko , Thomas Gleixner , Joel Fernandes , Andrew Morton , Neeraj Upadhyay , Sebastian Andrzej Siewior , Daniel Axtens Subject: Re: [Drbd-dev] [PATCH] drdb: Switch to kvfree_rcu() API List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Dec 15, 2021 at 12:18:37PM +0100, Uladzislau Rezki (Sony) wrote: > Instead of invoking a synchronize_rcu() to free a pointer > after a grace period we can directly make use of new API > that does the same but in more efficient way. > > TO: Jens Axboe > TO: Philipp Reisner > TO: Jason Gunthorpe > TO: drbd-dev@lists.linbit.com > TO: linux-block@vger.kernel.org > Signed-off-by: Uladzislau Rezki (Sony) > --- > drivers/block/drbd/drbd_nl.c | 9 +++------ > drivers/block/drbd/drbd_receiver.c | 6 ++---- > drivers/block/drbd/drbd_state.c | 3 +-- > 3 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index 44ccf8b4f4b2..28f4d84945fd 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -1679,8 +1679,7 @@ int drbd_adm_disk_opts(struct sk_buff *skb, struct genl_info *info) > drbd_send_sync_param(peer_device); > } > > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > kfree(old_plan); > mod_timer(&device->request_timer, jiffies + HZ); > goto success; > @@ -2511,8 +2510,7 @@ int drbd_adm_net_opts(struct sk_buff *skb, struct genl_info *info) > > mutex_unlock(&connection->resource->conf_update); > mutex_unlock(&connection->data.mutex); > - synchronize_rcu(); > - kfree(old_net_conf); > + kvfree_rcu(old_net_conf); > > if (connection->cstate >= C_WF_REPORT_PARAMS) { > struct drbd_peer_device *peer_device; > @@ -2925,8 +2923,7 @@ int drbd_adm_resize(struct sk_buff *skb, struct genl_info *info) > new_disk_conf->disk_size = (sector_t)rs.resize_size; > rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); > mutex_unlock(&device->resource->conf_update); > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > new_disk_conf = NULL; > } > > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index 1f740e42e457..d73a53242a75 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -3799,8 +3799,7 @@ static int receive_protocol(struct drbd_connection *connection, struct packet_in > drbd_info(connection, "peer data-integrity-alg: %s\n", > integrity_alg[0] ? integrity_alg : "(none)"); > > - synchronize_rcu(); > - kfree(old_net_conf); > + kvfree_rcu(old_net_conf); > return 0; > > disconnect_rcu_unlock: > @@ -4168,8 +4167,7 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info > > rcu_assign_pointer(device->ldev->disk_conf, new_disk_conf); > mutex_unlock(&connection->resource->conf_update); > - synchronize_rcu(); > - kfree(old_disk_conf); > + kvfree_rcu(old_disk_conf); > > drbd_info(device, "Peer sets u_size to %lu sectors (old: %lu)\n", > (unsigned long)p_usize, (unsigned long)my_usize); > diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c > index b8a27818ab3f..826e496821c7 100644 > --- a/drivers/block/drbd/drbd_state.c > +++ b/drivers/block/drbd/drbd_state.c > @@ -2071,8 +2071,7 @@ static int w_after_conn_state_ch(struct drbd_work *w, int unused) > conn_free_crypto(connection); > mutex_unlock(&connection->resource->conf_update); > > - synchronize_rcu(); > - kfree(old_conf); > + kvfree_rcu(old_conf); > } > > if (ns_max.susp_fen) { > -- > 2.30.2 > + Jens Axboe + Philipp Reisner + Jason Gunthorpe + drbd-dev@lists.linbit.com + linux-block@vger.kernel.org -- Vlad Rezki