From: Rob Herring <robh@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Caleb Connolly <caleb@connolly.tech>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Satya Priya <skakit@codeaurora.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
Date: Wed, 15 Dec 2021 14:23:53 -0600 [thread overview]
Message-ID: <YbpO2ckB14wZ7p0l@robh.at.kernel.org> (raw)
In-Reply-To: <7I544R.923UO8WZHK48@ixit.cz>
On Tue, Dec 14, 2021 at 05:22:55PM +0100, David Heidelberg wrote:
>
>
>
> On Mon, Dec 13 2021 at 17:23:49 -0600, Rob Herring <robh@kernel.org> wrote:
> > On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
> > > Extend registers up to 2, also document their names.
> > >
> > > Also fixes warnings generated by `make
> > > qcom/sdm845-oneplus-fajita.dtb`:
> > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
> > > reg: [[24576], [24832]] is too long
> > > From schema:
> > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
> > > 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> > > From schema:
> > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> > >
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > > .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9
> > > ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1567467
> >
> >
> > rtc@11d: compatible: Additional items are not allowed ('qcom,pm8921-rtc'
> > was unexpected)
> > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
> >
> > rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
> > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
>
>
> Would you consider safe, if I sent patch to remove redundant
> `qcom,pm8921-rtc` from arch/arm/boot/dts/qcom-mdm9615.dtsi?
I don't know. Depends if anything uses that and doesn't know about
'qcom,pm8018-rtc'.
Rob
next prev parent reply other threads:[~2021-12-15 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:29 [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers David Heidelberg
2021-12-13 23:23 ` Rob Herring
2021-12-14 16:22 ` David Heidelberg
2021-12-15 20:23 ` Rob Herring [this message]
2021-12-15 20:24 ` Rob Herring
2022-01-05 0:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbpO2ckB14wZ7p0l@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.