All of lore.kernel.org
 help / color / mirror / Atom feed
From: asmadeus@codewreck.org
To: zhuxinran <zhuran@mail.ustc.edu.cn>
Cc: ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
	kuba@kernel.org, v9fs-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: fix spelling error
Date: Thu, 16 Dec 2021 12:18:36 +0900	[thread overview]
Message-ID: <YbqwDPjapugTakhZ@codewreck.org> (raw)
In-Reply-To: <20211216030836.81989-1-zhuran@mail.ustc.edu.cn>


Thanks for the patch.

A few comments below:
zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800:
> Subject: virtio: fix spelling error

"virtio" is much more than this.
Have a look at previous commit messages for this file, something like
'9p/trans_virtio' would make a better component name.

(`git log net/9p/trans_virtio.c` to get git history for a single file)

> start my first kernel patch commit

This is not particularly useful for someone reading the git log, I'd
just remove this line.


I can do both changes on my end, but since you're learning it can also
be a good time to also see how to send a v2 (setting subject as [PATCH
v2], sending patch with in-reply-to)

I don't really mind either way, please let me know if you won't resend.

-- 
Dominique

      parent reply	other threads:[~2021-12-16  3:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16  3:08 [PATCH] virtio: fix spelling error zhuxinran
2021-12-16  3:17 ` Jason Wang
2021-12-16  3:18 ` asmadeus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbqwDPjapugTakhZ@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=davem@davemloft.net \
    --cc=ericvh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=zhuran@mail.ustc.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.