From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"fw@strlen.de" <fw@strlen.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: LTS "Warning: file conntrack_vrf.sh is not executable, correct this."
Date: Thu, 16 Dec 2021 09:07:13 +0100 [thread overview]
Message-ID: <YbrzsZf/arqfZ3DT@kroah.com> (raw)
In-Reply-To: <234d7a6a81664610fdf21ac72730f8bd10d3f46f.camel@nokia.com>
On Thu, Dec 16, 2021 at 08:00:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> Hi Greg,
>
> Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since
> "selftests: netfilter: add a vrf+conntrack testcase" was added to LTS.
> It's correct 755 in upstream, but somehow messed up in LTS :-(
That is because quilt/git can not set modes of files.
> linux-5.4.y
> ===========
> commit 8d3563ecbca3526fcc6639065c9fb11b2f234706
> Author: Florian Westphal <fw@strlen.de>
> Date: Mon Oct 18 14:38:13 2021 +0200
>
> selftests: netfilter: add a vrf+conntrack testcase
>
> commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream.
>
> [...]
> diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> new file mode 100644 <----------------
>
>
> linux-5.15.y
> ============
> commit cffab968e94e513bdcef25e11402243ce2919803
> [...]
> new file mode 100644 <----------------
>
>
> upstream
> ========
> $ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c
>
> commit 33b8aad21ac175eba9577a73eb62b0aa141c241c
> Author: Florian Westphal <fw@strlen.de>
> Date: Mon Oct 18 14:38:13 2021 +0200
>
> selftests: netfilter: add a vrf+conntrack testcase
>
> [...]
> diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh
> new file mode 100755 <-----------------------
>
>
> -Tommi
>
What about the 5.10.y tree? Does it need this change as well?
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-16 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 8:00 LTS "Warning: file conntrack_vrf.sh is not executable, correct this." Rantala, Tommi T. (Nokia - FI/Espoo)
2021-12-16 8:07 ` gregkh [this message]
2021-12-16 8:13 ` gregkh
2021-12-17 6:38 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbrzsZf/arqfZ3DT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.