From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH v3 0/6] Some more code de-duplication
Date: Thu, 16 Dec 2021 14:12:29 +0100 [thread overview]
Message-ID: <Ybs7PVP5W5V8X2nx@salvia> (raw)
In-Reply-To: <20211216125840.385-1-phil@nwl.cc>
On Thu, Dec 16, 2021 at 01:58:34PM +0100, Phil Sutter wrote:
> No change in patches 1 to 3 and 6.
>
> Patch 4 is new: Extend program_version field with variant string instead
> of introducing a separate field. This made patch 5 a bit smaller, due to
> less differences between basic_exit_err() and xtables_exit_error().
LGTM, thanks
prev parent reply other threads:[~2021-12-16 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:58 [iptables PATCH v3 0/6] Some more code de-duplication Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 1/6] xshared: Share print_match_save() between legacy ip*tables Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 2/6] xshared: Share a common printhelp function Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 3/6] xshared: Share exit_tryhelp() Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 4/6] xtables_globals: Embed variant name in .program_version Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 5/6] libxtables: Extend basic_exit_err() Phil Sutter
2021-12-16 12:58 ` [iptables PATCH v3 6/6] iptables-*-restore: Drop pointless line reference Phil Sutter
2021-12-16 13:12 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybs7PVP5W5V8X2nx@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.