From: Christoph Hellwig <hch@infradead.org>
To: Miko Larsson <mikoxyzzz@gmail.com>
Cc: minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
Date: Thu, 16 Dec 2021 02:14:44 -0800 [thread overview]
Message-ID: <YbsRlDYT2BfgrXRX@infradead.org> (raw)
In-Reply-To: <20211215192128.108967-3-mikoxyzzz@gmail.com>
On Wed, Dec 15, 2021 at 08:21:28PM +0100, Miko Larsson wrote:
> strlcpy shouldn't be used; strscpy should be used instead.
I think the proper API to use here would be kmemdup_nul.
next prev parent reply other threads:[~2021-12-16 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 19:21 [PATCH 0/2] zram: zram_drv: Fix some formatting problems Miko Larsson
2021-12-15 19:21 ` [PATCH 1/2] zram: zram_drv: add SPDX license identifiers Miko Larsson
2021-12-16 10:12 ` Christoph Hellwig
2021-12-15 19:21 ` [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy Miko Larsson
2021-12-16 10:14 ` Christoph Hellwig [this message]
2021-12-16 15:00 ` Miko Larsson
2021-12-16 17:52 ` Christoph Hellwig
2021-12-16 17:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbsRlDYT2BfgrXRX@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikoxyzzz@gmail.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.