All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue] build: doc: Update build_man.sh for doxygen 1.9.2
Date: Thu, 16 Dec 2021 13:26:10 +0100	[thread overview]
Message-ID: <YbswYqgQ2EYfBWGO@salvia> (raw)
In-Reply-To: <Ybsv3Hkk93EEYqSr@slk1.local.net>

On Thu, Dec 16, 2021 at 11:23:56PM +1100, Duncan Roe wrote:
> Hi Pablo,
> 
> On Thu, Dec 16, 2021 at 12:28:34AM +0100, Pablo Neira Ayuso wrote:
> > A bit more details on this one? It's just a cosmetic issue?
> >
> > On Wed, Dec 08, 2021 at 09:45:02AM +1100, Duncan Roe wrote:
> > > Cater for bold line number in del_def_at_lines()
> > >
> > > Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
> > > ---
> > >  doxygen/build_man.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/doxygen/build_man.sh b/doxygen/build_man.sh
> > > index 852c7b8..c68876c 100755
> > > --- a/doxygen/build_man.sh
> > > +++ b/doxygen/build_man.sh
> > > @@ -96,7 +96,7 @@ fix_double_blanks(){
> > >  del_def_at_lines(){
> > >    linnum=1
> > >    while [ $linnum -ne 0 ]
> > > -  do mygrep "^Definition at line [[:digit:]]* of file" $target
> > > +  do mygrep '^Definition at line (\\fB)?[[:digit:]]*(\\fP)? of file' $target
> > >      [ $linnum -eq 0 ] || delete_lines $(($linnum - 1)) $linnum
> > >    done
> > >  }
> > > --
> > > 2.17.5
> > >
> No, not cosmetic. The regexp has to be updated to recognise a line with bold
> line numbering. Without the patch, the unwanted line appears in the man page.

I see.

> I thought that was obvious. Will submit a v2 explaining a bit more, unless you
> apply the patch in the meantime.

Thanks for sending v2.

      reply	other threads:[~2021-12-16 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 22:45 [PATCH libnetfilter_queue] build: doc: Update build_man.sh for doxygen 1.9.2 Duncan Roe
2021-12-15 23:28 ` Pablo Neira Ayuso
2021-12-16 12:23   ` Duncan Roe
2021-12-16 12:26     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbswYqgQ2EYfBWGO@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.