From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Ulrich Hecht <uli+renesas@fpond.eu>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp
Subject: Re: [PATCH 3/3] serial: sh-sci: Use devm_clk_get_optional()
Date: Thu, 16 Dec 2021 16:23:03 +0100 [thread overview]
Message-ID: <YbtZ18XzusXJgKio@kunai> (raw)
In-Reply-To: <bce27288cb570952dd96b441e1af8768ad8b4870.1639663832.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Thu, Dec 16, 2021 at 03:17:34PM +0100, Geert Uytterhoeven wrote:
> The sh-sci driver supports up to four input clocks, of which only the
> first one is mandatory.
>
> Replace devm_clk_get() and custom error checking by
> devm_clk_get_optional(), to simplify the code and to catch all real
> errors.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Yeah, much better. Great cleanup!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-16 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 14:17 [PATCH 0/3] serial: sh-sci: Clock handling improvements Geert Uytterhoeven
2021-12-16 14:17 ` [PATCH 1/3] serial: sh-sci: Drop support for "sci_ick" clock Geert Uytterhoeven
2021-12-16 14:52 ` Laurent Pinchart
2021-12-16 15:17 ` Wolfram Sang
2021-12-16 14:17 ` [PATCH 2/3] serial: sh-sci: Use dev_err_probe() Geert Uytterhoeven
2021-12-16 14:52 ` Laurent Pinchart
2021-12-16 15:18 ` Wolfram Sang
2021-12-16 14:17 ` [PATCH 3/3] serial: sh-sci: Use devm_clk_get_optional() Geert Uytterhoeven
2021-12-16 14:53 ` Laurent Pinchart
2021-12-16 15:23 ` Wolfram Sang [this message]
2021-12-19 10:35 ` [PATCH 0/3] serial: sh-sci: Clock handling improvements Rob Landley
2021-12-19 10:53 ` Geert Uytterhoeven
2021-12-20 10:29 ` Rob Landley
2021-12-22 9:25 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtZ18XzusXJgKio@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.