From: Lee Jones <lee.jones@linaro.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: hdegoede@redhat.com, bhelgaas@google.com,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
srinivas.pandruvada@intel.com, mgross@linux.intel.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org,
Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH V4 3/6] platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus
Date: Thu, 16 Dec 2021 16:49:53 +0000 [thread overview]
Message-ID: <YbtuMVoTbCUi82cm@google.com> (raw)
In-Reply-To: <20211216023146.2361174-4-david.e.box@linux.intel.com>
On Wed, 15 Dec 2021, David E. Box wrote:
> Intel Platform Monitoring Technology (PMT) support is indicated by presence
> of an Intel defined PCIe Designated Vendor Specific Extended Capabilities
> (DVSEC) structure with a PMT specific ID. The current MFD implementation
> creates child devices for each PMT feature, currently telemetry, watcher,
> and crashlog. However DVSEC structures may also be used by Intel to
> indicate support for other features. The Out Of Band Management Services
> Module (OOBMSM) uses DVSEC to enumerate several features, including PMT.
> In order to support them it is necessary to modify the intel_pmt driver to
> handle the creation of the child devices more generically. To that end,
> modify the driver to create child devices for any VSEC/DVSEC features on
> supported devices (indicated by PCI ID). Additionally, move the
> implementation from MFD to the Auxiliary bus. VSEC/DVSEC features are
> really multifunctional PCI devices, not platform devices as MFD was
> designed for. Auxiliary bus gives more flexibility by allowing the
> definition of custom structures that can be shared between associated
> auxiliary devices and the parent device. Also, rename the driver from
> intel_pmt to intel_vsec to better reflect the purpose.
>
> This series also removes the current runtime pm support which was not
> complete to begin with. None of the current devices require runtime pm.
> However the support will be replaced when a device is added that requires
> it.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> Reviewed-by: Mark Gross <markgross@kernel.org>
> ---
> V4
> - Add intel_vsec_extract_vsec() to combine common code and simplify
> the extended capability loops. Suggested by Andy.
> V3
> - Add comment clarifying how driver cleanup is handled without remove().
>
> V2
> - Clarify status of missing pm support in commit message.
> - Clarify why auxiliary bus is preferred in commit message.
>
> MAINTAINERS | 12 +-
> drivers/mfd/Kconfig | 10 -
> drivers/mfd/Makefile | 1 -
> drivers/mfd/intel_pmt.c | 261 -------------
Acked-by: Lee Jones <lee.jones@linaro.org>
> drivers/platform/x86/intel/Kconfig | 11 +
> drivers/platform/x86/intel/Makefile | 2 +
> drivers/platform/x86/intel/pmt/Kconfig | 4 +-
> drivers/platform/x86/intel/pmt/class.c | 21 +-
> drivers/platform/x86/intel/pmt/class.h | 5 +-
> drivers/platform/x86/intel/pmt/crashlog.c | 47 +--
> drivers/platform/x86/intel/pmt/telemetry.c | 46 +--
> drivers/platform/x86/intel/vsec.c | 405 +++++++++++++++++++++
> drivers/platform/x86/intel/vsec.h | 43 +++
> 13 files changed, 533 insertions(+), 335 deletions(-)
> delete mode 100644 drivers/mfd/intel_pmt.c
> create mode 100644 drivers/platform/x86/intel/vsec.c
> create mode 100644 drivers/platform/x86/intel/vsec.h
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-12-16 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 2:31 [PATCH V4 0/6] Auxiliary bus driver support for Intel PCIe VSEC/DVSEC David E. Box
2021-12-16 2:31 ` [PATCH V4 1/6] PCI: Add #defines for accessing PCIe DVSEC fields David E. Box
2021-12-16 2:31 ` [PATCH V4 2/6] driver core: auxiliary bus: Add driver data helpers David E. Box
2021-12-21 9:20 ` Greg KH
2021-12-16 2:31 ` [PATCH V4 3/6] platform/x86/intel: Move intel_pmt from MFD to Auxiliary Bus David E. Box
2021-12-16 16:49 ` Lee Jones [this message]
2021-12-16 2:31 ` [PATCH V4 4/6] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2021-12-16 2:31 ` [PATCH V4 5/6] tools arch x86: Add Intel SDSi provisiong tool David E. Box
2021-12-16 2:31 ` [PATCH V4 6/6] selftests: sdsi: test sysfs setup David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtuMVoTbCUi82cm@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.