From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B94C433F5 for ; Thu, 16 Dec 2021 17:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239876AbhLPRCK (ORCPT ); Thu, 16 Dec 2021 12:02:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239862AbhLPRCJ (ORCPT ); Thu, 16 Dec 2021 12:02:09 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D69C061574 for ; Thu, 16 Dec 2021 09:02:09 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id o13so45290989wrs.12 for ; Thu, 16 Dec 2021 09:02:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=It+bnMz4rm/amgvVUJO9nMItDC+LaTW6epjyib1HqJ0=; b=ZA3e2GoUMaTgCNcQ3kQBY2Kg13CKzCEqVq7uu+SpcchRUVLm5V5klv/hPZ9pXBjFTK Td6bSnQAG2N25TCNvDV6Un0Xg/ngcMC44kbCfeawuAQ4iAigufTyTYNHBCdh8L+AuGR8 VvnJsClabWwD2+ct+NPtjTBavXhTRmK3c6+tQnoe2V91n4xaJSbD45MW/Jayee2YGNKn +Cat7e8pCKb3h0Nk6/MSR3W5SSFFhzNjyIzxPSiVO6Djyyc//DPRlH4CLzYn8m3o5b1E fZ0a41QEv2wwgf2DsLQ/12vGHN+I1SaBcCAG2hRsNWpB99E5tuREg1B2uYDOmVOJWbc4 WXfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=It+bnMz4rm/amgvVUJO9nMItDC+LaTW6epjyib1HqJ0=; b=GgbWaQndLSWn1UDVQUntcS7j67MlYyK7kbCOd1US4ly63GveBn9n56EC4UqPFEiDje 9W+0vrwLwFHr8nqppqtv4tYhSPX6yjmeUJG/+fm0aBetAKs2uPZ9v27i+rXRAP9ymcLg h5GFtNZVeqW5E7UdapE5LboNyBvLKbILl56CppxOU+9R8gtxUU3xrSf8fvkH8/bKz8kC yU+q7QgoxxxZNir8oM7tPBhad/lsWcwmhn5Zb8Q53EBKMG6FY1ge5rOM+j5s486IYzOE de9BC28K1xmzxYei5yDjVFsI227hE7FU06f1VVO4kg5QFfAVS8vZKue0hvBnPMfyInfN lEaw== X-Gm-Message-State: AOAM533zEQa/aomPPuVNLl1LVRqgRcl1CIqrLngb2iyTQNTAN0YvDscs /7IAlUKcOx4Ue1aQ/aEQunia9g== X-Google-Smtp-Source: ABdhPJzeTqEpCjeJ6NjiNp8/yLg56LBXLaaC1dSL4XvqoejFF9ms2a/DcHv6jj9bhPjxEzanzbG/Eg== X-Received: by 2002:adf:aad6:: with SMTP id i22mr4081857wrc.40.1639674128086; Thu, 16 Dec 2021 09:02:08 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id q206sm1320350wme.8.2021.12.16.09.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 09:02:07 -0800 (PST) Date: Thu, 16 Dec 2021 17:01:58 +0000 From: Lee Jones To: Uladzislau Rezki Cc: Mike Marciniszyn , LKML , RCU , "Paul E . McKenney" , Michal Hocko , Andrew Morton , Daniel Axtens , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Peter Zijlstra , Thomas Gleixner , "Theodore Y . Ts'o" , Sebastian Andrzej Siewior , Oleksiy Avramchenko Subject: Re: [PATCH] mfd: dln2: Switch to kvfree_rcu() API Message-ID: References: <20211215111845.2514-1-urezki@gmail.com> <20211215111845.2514-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Wed, 15 Dec 2021, Uladzislau Rezki wrote: > On Wed, Dec 15, 2021 at 12:18:41PM +0100, Uladzislau Rezki (Sony) wrote: > > Instead of invoking a synchronize_rcu() to free a pointer > > after a grace period we can directly make use of new API > > that does the same but in more efficient way. > > > > TO: Lee Jones > > TO: Mike Marciniszyn > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > drivers/mfd/dln2.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c > > index 852129ea0766..365e3e77cac4 100644 > > --- a/drivers/mfd/dln2.c > > +++ b/drivers/mfd/dln2.c > > @@ -179,10 +179,8 @@ void dln2_unregister_event_cb(struct platform_device *pdev, u16 id) > > > > spin_unlock_irqrestore(&dln2->event_cb_lock, flags); > > > > - if (found) { > > - synchronize_rcu(); > > - kfree(i); > > - } > > + if (found) > > + kvfree_rcu(i); > > } > > EXPORT_SYMBOL(dln2_unregister_event_cb); > > > + Lee Jones > + Mike Marciniszyn I can't do anything with this. Send it properly please. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog