From: Klaus Jensen <its@irrelevant.dk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Mauro Matteo Cascella <mcascell@redhat.com>,
qemu-block@nongnu.org, David Hildenbrand <david@redhat.com>,
Jason Wang <jasowang@redhat.com>, Li Qiang <liq3ea@gmail.com>,
qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Qiuhao Li <Qiuhao.Li@outlook.com>,
Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Keith Busch <kbusch@kernel.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
Darren Kenny <darren.kenny@oracle.com>
Subject: Re: [PATCH 0/2] hw/nvme: Fix CVE-2021-3929 (DMA re-entrancy exploitation)
Date: Thu, 16 Dec 2021 20:13:39 +0100 [thread overview]
Message-ID: <YbuP4/rLTlCVBRi7@apples> (raw)
In-Reply-To: <20211216175510.884749-1-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Dec 16 18:55, Philippe Mathieu-Daudé wrote:
> Now that the DMA API allow passing MemTxAttrs argument and
> returning MemTxResult (with MEMTX_BUS_ERROR in particular),
> we can restrict the NVMe controller to memories (prohibitting
> accesses by the DMA engine to devices) and block yet another
> DMA re-entrancy attack.
>
> I'll will try to get a reproducer (and authorization to commit
> it as qtest) from the reporter.
>
> Based-on: <20211216123558.799425-1-philmd@redhat.com>
> "hw: Have DMA API take MemTxAttrs arg & propagate MemTxResult (part 2)"
> https://lore.kernel.org/qemu-devel/20211216123558.799425-1-philmd@redhat.com/
>
> Philippe Mathieu-Daudé (2):
> hw/nvme/ctrl: Do not ignore DMA access errors
> hw/nvme/ctrl: Prohibit DMA accesses to devices (CVE-2021-3929)
>
> hw/nvme/ctrl.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-16 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 17:55 [PATCH 0/2] hw/nvme: Fix CVE-2021-3929 (DMA re-entrancy exploitation) Philippe Mathieu-Daudé
2021-12-16 17:55 ` [PATCH 1/2] hw/nvme/ctrl: Do not ignore DMA access errors Philippe Mathieu-Daudé
2021-12-16 18:01 ` Keith Busch
2021-12-16 17:55 ` [PATCH 2/2] hw/nvme/ctrl: Prohibit DMA accesses to devices (CVE-2021-3929) Philippe Mathieu-Daudé
2021-12-16 18:02 ` Keith Busch
2021-12-16 18:21 ` Mauro Matteo Cascella
2021-12-16 19:13 ` Klaus Jensen [this message]
2021-12-16 19:55 ` [PATCH 0/2] hw/nvme: Fix CVE-2021-3929 (DMA re-entrancy exploitation) Klaus Jensen
2021-12-20 6:40 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbuP4/rLTlCVBRi7@apples \
--to=its@irrelevant.dk \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=liq3ea@gmail.com \
--cc=mcascell@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.