Re: [LTP] [PATCH] [v2, 1/2] syscalls/sched_get_priority_max01: Convert to new

[Petr Vorel <pvorel@suse.cz>]

Hi sujiaxun,

> +++ b/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> @@ -1,142 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>  /*
>   * Copyright (c) Wipro Technologies Ltd, 2002.  All Rights Reserved.
FYI You could add your or LTP copyright. Which one you prefer?

> +/*\
> + * [Description]
>   *
> - *    DESCRIPTION
>   *	This is a Phase I test for the sched_get_priority_max(2) system call.

I suggest to change it to
+ * Basic test for the sched_get_priority_max(2) system call.
+ * Obtain different maximum priority scheduling strategies and compare
+ * them with the expected value.

FYI metadata are:
https://github.com/linux-test-project/ltp/releases/download/20210121/metadata.20210121.html
https://github.com/linux-test-project/ltp/releases/download/20210121/metadata.20210121.pdf
You can run make in metadata/ if you're curious what output you do with
[Description]. The output will be in docparse/metadata.html and/or
docparse/metadata.pdf.

> - *	It is intended to provide a limited exposure of the system call.
> - *
> - * 	Setup:
> - * 	  Setup signal handling.
> - *	  Pause for SIGUSR1 if option specified.
> - *
> - * 	Test:
> - *	 Loop if the proper options are given.
> - * 	  Execute system call
> - *	  Check return code, if system call failed (return=-1)
> - *		Log the errno and Issue a FAIL message.
> - *	  Otherwise, Issue a PASS message.
> - *
> - * 	Cleanup:
> - * 	  Print errno log and/or timing stats if options given
> - *
> - * USAGE:  <for command-line>
> - *  sched_get_priority_max01 [-c n] [-e] [-i n] [-I x] [-P x] [-t] [-h] [-f]
> - * 			     [-p]
> - *			where,  -c n : Run n copies concurrently.
> - *				-e   : Turn on errno logging.
> - *				-h   : Show help screen
> - *				-f   : Turn off functional testing
> - *				-i n : Execute test n times.
> - *				-I x : Execute test for x seconds.
> - *				-p   : Pause for SIGUSR1 before starting
> - *				-P x : Pause for x seconds between iterations.
> - *				-t   : Turn on syscall timing.
> - *
> - ****************************************************************/
> + *	Obtain different maximum priority scheduling strategies and compare
> + *	them with the expected value.
> + */

>  #include <errno.h>
>  #include <sched.h>
> -#include "test.h"
> -
> -static void setup();
> -static void cleanup();
> -
> -char *TCID = "sched_get_priority_max01";
> +#include "lapi/syscalls.h"
> +#include "tst_test.h"

> -static struct test_case_t {
> +static struct test_case {
>  	char *desc;
>  	int policy;
>  	int retval;
> -} test_cases[] = {
> -	{
> -	"Test for SCHED_OTHER", SCHED_OTHER, 0}, {
> -	"Test for SCHED_FIFO", SCHED_FIFO, 99}, {
> -	"Test for SCHED_RR", SCHED_RR, 99}
> +} tcases[] = {
> +	{"SCHED_OTHER", SCHED_OTHER, 0},
> +	{"SCHED_FIFO", SCHED_FIFO, 99},
> +	{"SCHED_RR", SCHED_RR, 99}
>  };
FYI if string is the same as constant, you can use macro:

#define POLICY_DESC(x) .desc = #x, .policy = x

static struct test_case {
	char *desc;
	int policy;
	int retval;
} tcases[] = {
	{POLICY_DESC(SCHED_OTHER), 0},
	{POLICY_DESC(SCHED_FIFO), 99},
	{POLICY_DESC(SCHED_RR), 99}
};

Thus if you agree, I'm going to merge with this diff below.

diff --git testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
index 8dcf7e3ea6..5058153e36 100644
--- testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
+++ testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
@@ -1,14 +1,16 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright (c) Wipro Technologies Ltd, 2002.  All Rights Reserved.
+ * Copyright (c) 2021 sujiaxun <sujiaxun@uniontech.com>
  */
 
 /*\
  * [Description]
  *
- *	This is a Phase I test for the sched_get_priority_max(2) system call.
- *	Obtain different maximum priority scheduling strategies and compare
- *	them with the expected value.
+ * Basic test for the sched_get_priority_max(2) system call.
+ *
+ * Obtain different maximum priority scheduling strategies and compare
+ * them with the expected value.
  */
 
 #include <errno.h>
@@ -16,14 +18,16 @@
 #include "lapi/syscalls.h"
 #include "tst_test.h"
 
+#define POLICY_DESC(x) .desc = #x, .policy = x
+
 static struct test_case {
 	char *desc;
 	int policy;
 	int retval;
 } tcases[] = {
-	{"SCHED_OTHER", SCHED_OTHER, 0},
-	{"SCHED_FIFO", SCHED_FIFO, 99},
-	{"SCHED_RR", SCHED_RR, 99}
+	{POLICY_DESC(SCHED_OTHER), 0},
+	{POLICY_DESC(SCHED_FIFO), 99},
+	{POLICY_DESC(SCHED_RR), 99}
 };
 
 static void run_test(unsigned int nr)
@@ -33,11 +37,9 @@ static void run_test(unsigned int nr)
 
 	TST_EXP_VAL(tst_syscall(__NR_sched_get_priority_max, tc->policy),
 			tc->retval, "test for %s", tc->desc);
-
 }
 
 static struct tst_test test = {
 	.tcnt = ARRAY_SIZE(tcases),
 	.test = run_test,
 };
-

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp