From: Andrew Lunn <andrew@lunn.ch>
To: Dimitris Michailidis <d.michailidis@fungible.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops
Date: Thu, 30 Dec 2021 18:40:29 +0100 [thread overview]
Message-ID: <Yc3vDQ0cFE6vm0Ul@lunn.ch> (raw)
In-Reply-To: <20211230163909.160269-4-dmichail@fungible.com>
> +static int msg_enable;
> +module_param(msg_enable, int, 0644);
> +MODULE_PARM_DESC(msg_enable, "bitmap of NETIF_MSG_* enables");
> +
Module params are not liked. Please implement the ethtool op, if you
have not already done so.
Andrew
next prev parent reply other threads:[~2021-12-30 17:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 16:39 [PATCH net-next 0/8] new Fungible Ethernet driver Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 1/8] PCI: add Fungible vendor ID to pci_ids.h Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 2/8] net/fungible: Add service module for Fungible drivers Dimitris Michailidis
2021-12-30 17:28 ` Andrew Lunn
2021-12-30 18:24 ` Dimitris Michailidis
2021-12-30 19:00 ` Andrew Lunn
2021-12-30 20:13 ` Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 3/8] net/funeth: probing and netdev ops Dimitris Michailidis
2021-12-30 17:40 ` Andrew Lunn [this message]
2021-12-30 18:33 ` Dimitris Michailidis
2021-12-30 19:02 ` Andrew Lunn
2021-12-30 20:05 ` Dimitris Michailidis
2021-12-31 11:14 ` Heiner Kallweit
2022-01-03 22:11 ` Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 4/8] net/funeth: ethtool operations Dimitris Michailidis
2021-12-30 18:04 ` Andrew Lunn
2021-12-30 20:22 ` Jakub Kicinski
2021-12-30 20:30 ` Dimitris Michailidis
2021-12-30 20:43 ` Jakub Kicinski
2021-12-30 20:56 ` Dimitris Michailidis
2021-12-30 20:27 ` Dimitris Michailidis
2021-12-30 22:25 ` Andrew Lunn
2021-12-31 1:23 ` Dimitris Michailidis
2021-12-31 2:24 ` Andrew Lunn
2021-12-31 3:23 ` Dimitris Michailidis
2021-12-30 20:28 ` Jakub Kicinski
2021-12-30 20:31 ` Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 5/8] net/funeth: devlink support Dimitris Michailidis
2021-12-30 17:41 ` Jakub Kicinski
2021-12-30 16:39 ` [PATCH net-next 6/8] net/funeth: add the data path Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 7/8] net/funeth: add kTLS TX control part Dimitris Michailidis
2021-12-30 16:39 ` [PATCH net-next 8/8] net/fungible: Kconfig, Makefiles, and MAINTAINERS Dimitris Michailidis
2021-12-30 17:43 ` Jakub Kicinski
2021-12-30 20:54 ` Dimitris Michailidis
2021-12-30 21:16 ` Dimitris Michailidis
2021-12-30 22:17 ` Jakub Kicinski
2021-12-30 22:27 ` Andrew Lunn
2021-12-30 22:59 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc3vDQ0cFE6vm0Ul@lunn.ch \
--to=andrew@lunn.ch \
--cc=d.michailidis@fungible.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.