From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH v3] perf/core: Set event shadow time for inactive events too
Date: Mon, 20 Dec 2021 10:39:49 +0100 [thread overview]
Message-ID: <YcBPZXtu0OOesleq@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAM9d7cgugnvrv5CJPe_EP_M8pp8h+GsCCW3-RDmyrd+JDGYJrQ@mail.gmail.com>
On Fri, Dec 10, 2021 at 10:59:49AM -0800, Namhyung Kim wrote:
> > You're doing that bpf-cgroup crud, right? Where exactly do you hook into
> > to do the counter reads?
>
> That's true but it doesn't use cgroup events actually. They are plain cpu
> events and BPF is called from a separate 'cgroup-switches' event to
> read out the counters.
Oh, right.
> > > Maybe because the event is enabled from the beginning.
> > > Then it might miss set_state/update_time at all.
> >
> > Even then, it's set to INACTIVE and any state change thereafter needs to
> > go through perf_event_set_state() and update the relevant timestamps.
>
> Right, but the problem happens when you read the event *before*
> any state change.
But the per-cpu event should be the simplest case ever, the cpu context
is *always* active, enabled time always runs.
next prev parent reply other threads:[~2021-12-20 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 22:48 [PATCH v3] perf/core: Set event shadow time for inactive events too Namhyung Kim
2021-12-06 23:11 ` Song Liu
2021-12-08 23:22 ` Peter Zijlstra
2021-12-09 5:52 ` Namhyung Kim
2021-12-09 8:21 ` Peter Zijlstra
2021-12-09 11:26 ` Peter Zijlstra
2021-12-09 11:34 ` Peter Zijlstra
2021-12-09 21:51 ` Namhyung Kim
2021-12-10 10:19 ` Peter Zijlstra
2021-12-10 18:59 ` Namhyung Kim
2021-12-20 9:39 ` Peter Zijlstra [this message]
2021-12-09 21:35 ` Namhyung Kim
2021-12-10 10:33 ` Peter Zijlstra
2021-12-10 23:19 ` Namhyung Kim
2021-12-17 16:35 ` Peter Zijlstra
2021-12-18 9:09 ` Song Liu
2021-12-20 9:30 ` Peter Zijlstra
2021-12-20 9:54 ` Peter Zijlstra
2021-12-21 12:39 ` Peter Zijlstra
2021-12-20 12:19 ` Peter Zijlstra
2021-12-21 5:54 ` Namhyung Kim
2021-12-21 7:23 ` Song Liu
2021-12-21 11:21 ` Peter Zijlstra
2022-01-18 11:17 ` [tip: perf/urgent] perf: Fix perf_event_read_local() time tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcBPZXtu0OOesleq@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.