From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30FDEC433EF for ; Mon, 20 Dec 2021 16:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239347AbhLTQzS (ORCPT ); Mon, 20 Dec 2021 11:55:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234088AbhLTQzS (ORCPT ); Mon, 20 Dec 2021 11:55:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12878C061574 for ; Mon, 20 Dec 2021 08:55:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3AD960F4B for ; Mon, 20 Dec 2021 16:55:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 868E6C36AEB; Mon, 20 Dec 2021 16:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640019317; bh=j4NIra83Cda9YsgLrQQs5c3bYsrUGBbcsah5z0DbD14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HAQIcj07lQhp1x261NOxHWjdmUsKSBPgROR0ojbXdcwIv4WVYjihiQPRgBMDBJnns PSwuMR0lGOKUX6jq7TrjNjiGpEHXR+qlUpMOL7JJYVvXzjPA2gVFr1K6LDFS7HFBZ7 olu6MdVYjTuKtIvSeSjY++8BR5y+m0EjT+OpnhU8= Date: Mon, 20 Dec 2021 17:55:14 +0100 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Thorsten Leemhuis , Chris Hixon , linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: typec: ucsi: Only check the contract if there is a connection Message-ID: References: <20211217140327.31921-1-heikki.krogerus@linux.intel.com> <1d90a23b-fe2f-6892-1641-7a13e38a00dc@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Dec 20, 2021 at 05:41:22PM +0200, Heikki Krogerus wrote: > On Mon, Dec 20, 2021 at 03:47:56PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 17, 2021 at 05:14:42PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Fri, Dec 17, 2021 at 03:32:59PM +0100, Thorsten Leemhuis wrote: > > > > Lo! Thx for working out a fix this quickly! > > > > > > > > I'm just the regression tracker, but I think there are a few minor > > > > details to improve here. > > > > > > > > On 17.12.21 15:03, Heikki Krogerus wrote: > > > > > The driver must make sure there is an actual connection > > > > > before checking details about the USB Power Delivery > > > > > contract. Those details are not valid unless there is a > > > > > connection. > > > > > > > > > > This fixes NULL pointer dereference that is caused by an > > > > > attempt to register bogus partner alternate mode that the > > > > > firmware on some platform may report before the actual > > > > > connection. > > > > > > > > > > Fixes: 6cbe4b2d5a3f ("usb: typec: ucsi: Check the partner alt modes always if there is PD contract") > > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215117 > > > > BugLink? Is that a tag we really use? Then I'm unaware of it. Greg is > > > > the expert and can likely clarify, but that line afaik needs to replaced > > > > by this: > > > > > > Although not yet documented, it is the appropriate tag for the link to > > > the bug. It makes it clear that the link is to the bug and not to > > > the discussion on the list. > > > > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215117 > > > > Link: > > > > https://lore.kernel.org/linux-usb/bug-215117-208809@https.bugzilla.kernel.org%2F/ > > > > > > > > Normally the last line would need a 's!linux-usb!r!', but seems the > > > > kernel.org redirector doesn't work well in this particular case, so I > > > > guess it's better this way than not at all :-/ > > > > > > > > The second line will also make the regression tracking bot automatically > > > > close the issue (but I fear it might also fail due to the slash at the > > > > end of the message-id :-/) > > > > > > Greg will add the "Link" tag to the commit when, and if, he actually > > > takes the patch. I do not add it because I do not want any bots to > > > react to the patch before it has actually been accepted. > > > > The link my scripts add is to the post on lore.kernel.org, not to > > anywhere else. > > > > So if this needs to point to a different report, like Thorsten shows > > above, then that needs to be done "by hand". > > > > I guess I'll go add these on my own :( > > OK... so I don't prepare v2 then. No, please do, I will not get to this for another few days because it takes me more work :)