All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: linuxfancy@googlegroups.com,
	"Forest Bond" <forest@alittletooquiet.net>,
	"Alberto Merciai" <alb3rt0.m3rciai@gmail.com>,
	"Karolina Drobnik" <karolinadrobnik@gmail.com>,
	"Aldas Taraškevičius" <aldas60@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: drop off byRxMode var in device.h
Date: Mon, 20 Dec 2021 17:39:18 +0100	[thread overview]
Message-ID: <YcCxtkNJKhFWONv7@kroah.com> (raw)
In-Reply-To: <20211219182004.25656-1-tomm.merciai@gmail.com>

On Sun, Dec 19, 2021 at 07:20:03PM +0100, Tommaso Merciai wrote:
> Drop off unused variable byRxMode in device.h, this fix following 
> checkpatch.pl check:
> 
> CHECK: Avoid CamelCase: <byRxMode>
> 131: FILE: drivers/staging/vt6655/device.h:131:
> 	unsigned char byRxMode
> 
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
>  drivers/staging/vt6655/device.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 4706bde1ec1d..84b1dcf80e47 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -128,8 +128,6 @@ struct vnt_private {
>  	u32                         memaddr;
>  	u32                         ioaddr;
>  
> -	unsigned char byRxMode;
> -
>  	spinlock_t                  lock;
>  
>  	volatile int                iTDUsed[TYPE_MAXTD];
> -- 
> 2.25.1
> 
> 

Did you send this twice?  What is the difference between the two
versions?

And you have trailing whitespace in the changelog for this message,
please fix.

thanks,

greg k-h

  reply	other threads:[~2021-12-20 16:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-19 18:20 [PATCH] staging: vt6655: drop off byRxMode var in device.h Tommaso Merciai
2021-12-19 18:20 ` Tommaso Merciai
2021-12-20 16:39 ` Greg Kroah-Hartman [this message]
2021-12-20 19:31   ` Tommaso Merciai
  -- strict thread matches above, loose matches on Subject: below --
2021-12-19 17:47 Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcCxtkNJKhFWONv7@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alb3rt0.m3rciai@gmail.com \
    --cc=aldas60@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=karolinadrobnik@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linuxfancy@googlegroups.com \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.