From: Greg KH <gregkh@linuxfoundation.org>
To: davidcomponentone@gmail.com
Cc: zbr@ioremap.net, yangyingliang@huawei.com,
ivan.zaentsev@wirenboard.ru, yang.guang5@zte.com.cn,
dan.carpenter@oracle.com, unixbhaskar@gmail.com,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v3] w1: w1_therm: use swap() to make code cleaner
Date: Tue, 21 Dec 2021 09:32:18 +0100 [thread overview]
Message-ID: <YcGREnlqJXORmN8b@kroah.com> (raw)
In-Reply-To: <2becaf314c17f5bff4c6af4a8bd05039dde68497.1639988198.git.yang.guang5@zte.com.cn>
On Tue, Dec 21, 2021 at 08:15:28AM +0800, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> ---
> Changes from v1->v2:
> - Delete the curly {} braces.
>
> Changes from v2->v3::
> - Add --- line before version info.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: David Yang <davidcomponentone@gmail.com>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Why the signed-off-by below the --- line? That means it will be cut off
and not present in the patch at all :(
prev parent reply other threads:[~2021-12-21 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 0:15 [PATCH v3] w1: w1_therm: use swap() to make code cleaner davidcomponentone
2021-12-21 8:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGREnlqJXORmN8b@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=davidcomponentone@gmail.com \
--cc=ivan.zaentsev@wirenboard.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=unixbhaskar@gmail.com \
--cc=yang.guang5@zte.com.cn \
--cc=yangyingliang@huawei.com \
--cc=zbr@ioremap.net \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.