From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A93DC433F5 for ; Tue, 21 Dec 2021 12:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zf0Y2BYMxu6xssB98JHIHzALXCjsoygqQBdwNKj+KNs=; b=HSz5tmrQyZBAJ9 EbqBHDwkdAd+xlKl1QyHKp1XnchK6LTRBcplXuQCfDmPuNODQw5RpnMt1R1WNUWEHIa40GJFFIS6l MCKJuIucidr5cZTXsLPlreeYvH4PgNhpE3lev+msKATTWTKxKavzPFZD9KtVmufnixMRPQXkM/cDR XHktCPl8k1yrsneqjEA0fud2jZw3RucUWTbLPsYbs6KIN8ZYbv7Ro69CVrymu9P5CFH2i7vSAmPVU xgldLkGFSTYYlqKGmYZsml5ASNCaZ31cvboBO4o9xXkF55dBKpMNtzmOrmgHadMote0eyGDyLdT+2 uaWAQHLpTLA920kG2/sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mze2X-006idu-CJ; Tue, 21 Dec 2021 12:14:45 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mze2U-006icp-Ny for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 12:14:43 +0000 Received: by mail-wm1-x32d.google.com with SMTP id bg2-20020a05600c3c8200b0034565c2be15so1568792wmb.0 for ; Tue, 21 Dec 2021 04:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NYtFuw8skf4IqEe2E5F4oiyYNk3w/W3sUef4AJQUX7E=; b=kf5FSZi9QZrnv6ySxi9p72oDKv52pmBclrrZhly+vLZhDoHU+uDqpeyaMuJofTjTHu vLzU2JlRKCMKTBSSBXGKad6TZ3AIfa2RWaIn/ZpYO0Y790TQVLxYAXA2LotAe3CnA+rX Fz72DBZ63ZCaBLXPfiCB2pl9eZojAjwadyJ5vQgXtjQsofvawOQyUUs69RHruSyEagzM m8XvxsBF+gN/OxJHMKTywPk1Ie4DVzhpILtScMt3j4galI26LWK9XRWkfRSpF7SLdPD+ v8Vuz95W29oEs/ZHr7YZzuV30BoXbp/sp8HV+NzsJsORykE7IreL+wAO6QCbvCBVPSqX JBGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NYtFuw8skf4IqEe2E5F4oiyYNk3w/W3sUef4AJQUX7E=; b=k7NMbiU/EOcofEJLhVOUUMKNUyG/p5KJKVs/ysCpywh0ZpRxQdI2XCk600p5hwuTev Jd4iNjMz9k5TCJa2adHVMFVoNrwxR4Igo/nZCzG1Akt63xeqPnsX7J05wYM+XYb17FWC toBDRCaeKqjn0RFV6ncBujxiZ4EjtJWaBEAEbGC4nOuQc+Dwqqx02J1YMC5GrUIhE5fu jdpynVkGnUX40HhOApLDTbVtst3OGUs8aaADhPIvpxhjFYY4wVBg0YIcAWMR7n5mH+78 meGXtHsIPH1UhsGyAS7hdHu2FF8shHzYnGPsDo1Y2WqV95Btw9rNEb4hHO5DvNFLoveI qCWg== X-Gm-Message-State: AOAM531UaWdZd64IC54vZ1KIZM/z5cRey05/dlxKSnZaZvnm9J4LvRd8 9UwngX2E7fSN4YUTCFOJ10rpWQ== X-Google-Smtp-Source: ABdhPJyYt6GOM4lsAt7lCM8s88YHu36R9L+5yPwihNvz2lZ9aTQ8C+e5luDGa2eKWrBz2uBXUKHR5g== X-Received: by 2002:a05:600c:2150:: with SMTP id v16mr174804wml.10.1640088880731; Tue, 21 Dec 2021 04:14:40 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:87ff:799:2072:8808]) by smtp.gmail.com with ESMTPSA id p18sm4326864wmq.0.2021.12.21.04.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 04:14:40 -0800 (PST) Date: Tue, 21 Dec 2021 13:14:33 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS Message-ID: References: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_041442_815812_B2984E7B X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: [...] > +static inline bool should_skip_kasan_unpoison(gfp_t flags, bool init_tags) > +{ > + /* Don't skip if a software KASAN mode is enabled. */ > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > + return false; > + > + /* Skip, if hardware tag-based KASAN is not enabled. */ > + if (!kasan_hw_tags_enabled()) > + return true; Same question here: why is IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check required if kasan_hw_tags_enabled() is always false if one of those is configured? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D38BC433EF for ; Tue, 21 Dec 2021 12:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF1D26B0073; Tue, 21 Dec 2021 07:14:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA12D6B0074; Tue, 21 Dec 2021 07:14:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A69B96B0075; Tue, 21 Dec 2021 07:14:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 9852F6B0073 for ; Tue, 21 Dec 2021 07:14:42 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 561E28BEDE for ; Tue, 21 Dec 2021 12:14:42 +0000 (UTC) X-FDA: 78941694804.06.8D59B12 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf10.hostedemail.com (Postfix) with ESMTP id 92F93C001E for ; Tue, 21 Dec 2021 12:14:35 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id y83-20020a1c7d56000000b003456dfe7c5cso1554369wmc.1 for ; Tue, 21 Dec 2021 04:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NYtFuw8skf4IqEe2E5F4oiyYNk3w/W3sUef4AJQUX7E=; b=kf5FSZi9QZrnv6ySxi9p72oDKv52pmBclrrZhly+vLZhDoHU+uDqpeyaMuJofTjTHu vLzU2JlRKCMKTBSSBXGKad6TZ3AIfa2RWaIn/ZpYO0Y790TQVLxYAXA2LotAe3CnA+rX Fz72DBZ63ZCaBLXPfiCB2pl9eZojAjwadyJ5vQgXtjQsofvawOQyUUs69RHruSyEagzM m8XvxsBF+gN/OxJHMKTywPk1Ie4DVzhpILtScMt3j4galI26LWK9XRWkfRSpF7SLdPD+ v8Vuz95W29oEs/ZHr7YZzuV30BoXbp/sp8HV+NzsJsORykE7IreL+wAO6QCbvCBVPSqX JBGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NYtFuw8skf4IqEe2E5F4oiyYNk3w/W3sUef4AJQUX7E=; b=vQX6mYjEicW0lTwKlcdXr3RYeSmPlc4KX+7CwYKqnvr82/eLKvrKDIf2sUJAvnknLH KAqA5vAKnoWry33tcnMw/SJxQtp7Bx5Wc1gwmdhUw1lGb2eiXbJOYSBBn0en4ds2Gw6P XOXk0gQ0fXSQp3AjBVo7zYtzrMnrbiTtu9GqLlx8rPZUOOb9VAWJymU4uPqTJAhN125u v18fV7aj7arOVUMEQzPn30aLl6B8DslgtapJtW5CVzqqTxz1BlBdZyCsUfBJFJ3R57Hp VNtePn+ehHZXhvo5mkOGYUS8eBuPKUOR6W7OprCePHwyY67xcPSfjFplqPlMoPNIEEy0 tY4w== X-Gm-Message-State: AOAM5338pc/zanOJOlsgMxrSH3JnHN15vKmQklxtBNUrL6ZLEebAwD8a Bgq1SEzVd/mYo4jh/HWzxSHMrw== X-Google-Smtp-Source: ABdhPJyYt6GOM4lsAt7lCM8s88YHu36R9L+5yPwihNvz2lZ9aTQ8C+e5luDGa2eKWrBz2uBXUKHR5g== X-Received: by 2002:a05:600c:2150:: with SMTP id v16mr174804wml.10.1640088880731; Tue, 21 Dec 2021 04:14:40 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:87ff:799:2072:8808]) by smtp.gmail.com with ESMTPSA id p18sm4326864wmq.0.2021.12.21.04.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 04:14:40 -0800 (PST) Date: Tue, 21 Dec 2021 13:14:33 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS Message-ID: References: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 92F93C001E X-Stat-Signature: ugekgb9echhtfhknjce5u9b6qyibpocc Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kf5FSZi9; spf=pass (imf10.hostedemail.com: domain of elver@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1640088875-878468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: [...] > +static inline bool should_skip_kasan_unpoison(gfp_t flags, bool init_tags) > +{ > + /* Don't skip if a software KASAN mode is enabled. */ > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > + return false; > + > + /* Skip, if hardware tag-based KASAN is not enabled. */ > + if (!kasan_hw_tags_enabled()) > + return true; Same question here: why is IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check required if kasan_hw_tags_enabled() is always false if one of those is configured?