From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C29C433F5 for ; Tue, 21 Dec 2021 14:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CiQG519Jlsc+mluItvLCgL3YYXG+yHSPduO2VOmoVXw=; b=aa117czD/ZLKsR r4jZVeOAObA3ucpb0vBLVxjhNEbopSARsIGYhNBTq6UgtlsIaGETlBWJNDTmUG0Dkez/x12jVfcsw /jTxf7UO0l1+bfOZTaUjUekMtvS/rGhWzZFqGAa8a8ocUJF1m/BQ9tZn9diFfm96IBCawb6XYsfS8 ymzl+Rb7ks1QuTDCplvurZuoMbLGiVxDEgPq+hERfH9iVbemO873uM8oji8aaeREn0jg9Irl4+aMa tSs+hOcNxnQUfBb08gdkyFolN9KPXUgfLMfjMENjaUpIOcg+Goam/zJu68V+7d6quSr5lE89J84MW l/DM1pWirFM/fHKKkrqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgB6-0078Qu-JB; Tue, 21 Dec 2021 14:31:44 +0000 Received: from mail-qk1-f175.google.com ([209.85.222.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgAr-0078N3-2J; Tue, 21 Dec 2021 14:31:30 +0000 Received: by mail-qk1-f175.google.com with SMTP id f138so1228517qke.10; Tue, 21 Dec 2021 06:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZCiw0bZKYIpEoDjhVNnDiHVYSk1x/IQUJgn5e6PHxuI=; b=jz5jvQQoMfeV2tYsjdYdGb0mbYd4Vi6+FQIyuVE4MO7AU1cXNZhrP0yrYURhU381YQ GaaAoloQRteGMFJfrnL1Dam13kNBuRcDZjaCJ/Hx7S8M3jyxN1zWu/LmC9YzvBS9UaHP MSFc+Ek9Nn+Dh08FC4HkIjbdVcjuMsnqBbzjqM/EdC4T/pzTjL35fFozA2emKUAU5eDx +xnQ/DGcgQ885/VHjSONjU1rQFwX91qsRAvYkBBCIwRGrp+w1krj/MAifvUfhCfRJKaL rCjGWgzKGsQ15IQCbIRt2daAr97wMwjRKn4O4LGVK5fK7yl1mgkZXwyLUkF8k1v7ALBl 46ig== X-Gm-Message-State: AOAM531kApamug0Uu0HmXmbjdvlxMScyW7KUscHTI2subQWP/5NpLZgz vluX1ZdqPaaMmMJKw2uhH/6HAzUhj1gI X-Google-Smtp-Source: ABdhPJwbiZg2cLWCqLWG6kO5T5YieBNWdxELfhYlFtD+O7MYmC3zikpr/lWeCSO3xNhRskwxyCeFrQ== X-Received: by 2002:a05:620a:470e:: with SMTP id bs14mr2147958qkb.210.1640097086038; Tue, 21 Dec 2021 06:31:26 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id f8sm17586444qtk.1.2021.12.21.06.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 06:31:25 -0800 (PST) Received: (nullmailer pid 1358250 invoked by uid 1000); Tue, 21 Dec 2021 14:31:23 -0000 Date: Tue, 21 Dec 2021 10:31:23 -0400 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Message-ID: References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_063129_159329_3D5A7738 X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The problem with this series is it breaks an old kernel with new dt. You can partially mitigate that with stable kernel backport, but IMO keeping the old name is not a burden to maintain. And given RK3399 is widely used including by me, we should not be breaking compatibility. So allow for ref in addition to vpll if you like, but only use 'ref' for new users. And add a comment in the schema to that effect. Rob > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..3b40219e3ea60 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -47,11 +47,12 @@ properties: > - enum: > - cec > - grf > - - vpll > + - ref > - enum: > - grf > - - vpll > - - const: vpll > + - ref > + - const: > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77963C433EF for ; Tue, 21 Dec 2021 14:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wwE39iww5Z2RZ40Jhi7//h6fqZ98hPfdJPHhH9C4LnE=; b=r3LTA6J4mjAz1r 7ISiLRUTsrRF6oRf31is0yPV6Po6P/ggscSjEXYYD9lM0oOjzdJG9+YXrjxK07QlUwUmrhY0XEV8B +tlZTS0DkdiX4HpZcQ8XckXXds2t4uUxihJcM2zQUcFLgv2FsQGz+v8TyElvt+OwtGZbX9/nDYIHk VqF2uCTiZWI5912iMNWTT96j5lVVEVl6W5xYVnyldEK6sADmIB4iL2Sb1TSYSTmRi7kWPzxWQOdvh 9xL3Mia+dJtkvcKXqfqx+WoU6jLQQkHayr0a8HqXtoQGQyQqmo0B2whrkPtTSL/MjB+MO/gyRQPtd BByu9WnRT0muFcJTanjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgAx-0078OU-0e; Tue, 21 Dec 2021 14:31:35 +0000 Received: from mail-qk1-f175.google.com ([209.85.222.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgAr-0078N3-2J; Tue, 21 Dec 2021 14:31:30 +0000 Received: by mail-qk1-f175.google.com with SMTP id f138so1228517qke.10; Tue, 21 Dec 2021 06:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZCiw0bZKYIpEoDjhVNnDiHVYSk1x/IQUJgn5e6PHxuI=; b=jz5jvQQoMfeV2tYsjdYdGb0mbYd4Vi6+FQIyuVE4MO7AU1cXNZhrP0yrYURhU381YQ GaaAoloQRteGMFJfrnL1Dam13kNBuRcDZjaCJ/Hx7S8M3jyxN1zWu/LmC9YzvBS9UaHP MSFc+Ek9Nn+Dh08FC4HkIjbdVcjuMsnqBbzjqM/EdC4T/pzTjL35fFozA2emKUAU5eDx +xnQ/DGcgQ885/VHjSONjU1rQFwX91qsRAvYkBBCIwRGrp+w1krj/MAifvUfhCfRJKaL rCjGWgzKGsQ15IQCbIRt2daAr97wMwjRKn4O4LGVK5fK7yl1mgkZXwyLUkF8k1v7ALBl 46ig== X-Gm-Message-State: AOAM531kApamug0Uu0HmXmbjdvlxMScyW7KUscHTI2subQWP/5NpLZgz vluX1ZdqPaaMmMJKw2uhH/6HAzUhj1gI X-Google-Smtp-Source: ABdhPJwbiZg2cLWCqLWG6kO5T5YieBNWdxELfhYlFtD+O7MYmC3zikpr/lWeCSO3xNhRskwxyCeFrQ== X-Received: by 2002:a05:620a:470e:: with SMTP id bs14mr2147958qkb.210.1640097086038; Tue, 21 Dec 2021 06:31:26 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id f8sm17586444qtk.1.2021.12.21.06.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 06:31:25 -0800 (PST) Received: (nullmailer pid 1358250 invoked by uid 1000); Tue, 21 Dec 2021 14:31:23 -0000 Date: Tue, 21 Dec 2021 10:31:23 -0400 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Message-ID: References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_063129_159329_3D5A7738 X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The problem with this series is it breaks an old kernel with new dt. You can partially mitigate that with stable kernel backport, but IMO keeping the old name is not a burden to maintain. And given RK3399 is widely used including by me, we should not be breaking compatibility. So allow for ref in addition to vpll if you like, but only use 'ref' for new users. And add a comment in the schema to that effect. Rob > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..3b40219e3ea60 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -47,11 +47,12 @@ properties: > - enum: > - cec > - grf > - - vpll > + - ref > - enum: > - grf > - - vpll > - - const: vpll > + - ref > + - const: > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8B9C433F5 for ; Tue, 21 Dec 2021 14:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229517AbhLUOb1 (ORCPT ); Tue, 21 Dec 2021 09:31:27 -0500 Received: from mail-qk1-f171.google.com ([209.85.222.171]:41475 "EHLO mail-qk1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238479AbhLUOb0 (ORCPT ); Tue, 21 Dec 2021 09:31:26 -0500 Received: by mail-qk1-f171.google.com with SMTP id t83so12663089qke.8 for ; Tue, 21 Dec 2021 06:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZCiw0bZKYIpEoDjhVNnDiHVYSk1x/IQUJgn5e6PHxuI=; b=Za1BET45FVHEyShSb7nfWbxYg1CF+eg+PvID59fzTEzeGSk1DnO47vINQo1Ixu9Qjp 4N+gVDAqb88g7w93Ay3pKBVwGeBPAXfGcV2/o6cHBvrrJTBFPF3WQpoHitj2z1rRhog0 WcF63UylJkAhECxDwn0Yuxt5Kr8Obyp4G7lgsigGnWWww36nc0cBh7QSN06kns/nOnFD WEABD1lZvRpvXsoFqSFT0XEpr3wuMJjaHv4/HTSPVz73mzOpvQRXPhZg+l1/EUUx6Q+K 25zA7lZy+91FyhCoHdX7mKJjy6cotrSNmQ7jQ1ekKN3ggF7yBLi7+5sYCfaqDeSiMccF 43jw== X-Gm-Message-State: AOAM5328s47/oHVn3VQ/PMLymxKN7EJua1ImJjv90NaC/HLntdrJbSKq PFDvtYTmp2XaLmkme2sZZg== X-Google-Smtp-Source: ABdhPJwbiZg2cLWCqLWG6kO5T5YieBNWdxELfhYlFtD+O7MYmC3zikpr/lWeCSO3xNhRskwxyCeFrQ== X-Received: by 2002:a05:620a:470e:: with SMTP id bs14mr2147958qkb.210.1640097086038; Tue, 21 Dec 2021 06:31:26 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id f8sm17586444qtk.1.2021.12.21.06.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 06:31:25 -0800 (PST) Received: (nullmailer pid 1358250 invoked by uid 1000); Tue, 21 Dec 2021 14:31:23 -0000 Date: Tue, 21 Dec 2021 10:31:23 -0400 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Message-ID: References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The problem with this series is it breaks an old kernel with new dt. You can partially mitigate that with stable kernel backport, but IMO keeping the old name is not a burden to maintain. And given RK3399 is widely used including by me, we should not be breaking compatibility. So allow for ref in addition to vpll if you like, but only use 'ref' for new users. And add a comment in the schema to that effect. Rob > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..3b40219e3ea60 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -47,11 +47,12 @@ properties: > - enum: > - cec > - grf > - - vpll > + - ref > - enum: > - grf > - - vpll > - - const: vpll > + - ref > + - const: > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CFA4C433F5 for ; Tue, 21 Dec 2021 14:31:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F232113601; Tue, 21 Dec 2021 14:31:28 +0000 (UTC) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id F27501135E4 for ; Tue, 21 Dec 2021 14:31:26 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id m186so12687420qkb.4 for ; Tue, 21 Dec 2021 06:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZCiw0bZKYIpEoDjhVNnDiHVYSk1x/IQUJgn5e6PHxuI=; b=Viups05K03YLW0GpWwl3/r0G/+4DOnubBRE40PgaPXXtCNNcTQQjyCj9aWViloDmaq 6CixflmBT8e4i144MtphTHG2Z6Tq9nxuRz9SzbrXseeoCNCh/14Ba+LkIJJ6pJE3pUGE zNWiU1l1iijlUXGSc/EH+V9MAXuWVajNT/dKEeRknNr3NCRJj2DepwBU8W+9/H/bjk7y DvaIEIN+l8h4v4vDQhKYYVS05YAN2eP5koqIWoknJmhigiDI1eWKTK727yuKYugV74Vq QL0+hefmXULP2hGjmjIxa6MKwKRjizk1WV6eAmxt4Myv2W+sKuFVz63w6XWa3NzA0sPV F1yA== X-Gm-Message-State: AOAM531p34doHS1eP6EX+CEKuzNeJZ8DBtO0ANyVZdlxInAh4gQH/4N0 1vlNbRC9i8uM6UFlqrRB0g== X-Google-Smtp-Source: ABdhPJwbiZg2cLWCqLWG6kO5T5YieBNWdxELfhYlFtD+O7MYmC3zikpr/lWeCSO3xNhRskwxyCeFrQ== X-Received: by 2002:a05:620a:470e:: with SMTP id bs14mr2147958qkb.210.1640097086038; Tue, 21 Dec 2021 06:31:26 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id f8sm17586444qtk.1.2021.12.21.06.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 06:31:25 -0800 (PST) Received: (nullmailer pid 1358250 invoked by uid 1000); Tue, 21 Dec 2021 14:31:23 -0000 Date: Tue, 21 Dec 2021 10:31:23 -0400 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Message-ID: References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. The problem with this series is it breaks an old kernel with new dt. You can partially mitigate that with stable kernel backport, but IMO keeping the old name is not a burden to maintain. And given RK3399 is widely used including by me, we should not be breaking compatibility. So allow for ref in addition to vpll if you like, but only use 'ref' for new users. And add a comment in the schema to that effect. Rob > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 6e09dd2ee05ac..3b40219e3ea60 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -47,11 +47,12 @@ properties: > - enum: > - cec > - grf > - - vpll > + - ref > - enum: > - grf > - - vpll > - - const: vpll > + - ref > + - const: > + - ref > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > -- > 2.30.2 > >