From: Liam Beguin <liambeguin@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Peter Rosin <peda@axentia.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v10 03/14] iio: inkern: make a best effort on offset calculation
Date: Tue, 21 Dec 2021 12:50:20 -0500 [thread overview]
Message-ID: <YcIT3BSIKJKVWAgN@shaak> (raw)
In-Reply-To: <CAHp75Ve_vv619-UxdBN+xhWGm32tCJkkN3epVRgCiLF7p6xMOw@mail.gmail.com>
Hi Andy,
On Tue, Dec 21, 2021 at 07:42:31AM +0200, Andy Shevchenko wrote:
> On Mon, Dec 20, 2021 at 11:17 AM Liam Beguin <liambeguin@gmail.com> wrote:
> >
> > From: Liam Beguin <lvb@xiphos.com>
> >
> > iio_convert_raw_to_processed_unlocked() assumes the offset is an
> > integer. Make a best effort to get a valid offset value for fractional
> > cases without breaking implicit truncations.
>
> ...
>
> > + offset_val /= (1 << offset_val2);
>
> Besides potentially being problematic (if arg is 31 for the left
> shift) why not simply
>
> _val >>= _val2;
That is safer, and more elegant! I'll update.
Thanks,
Liam
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2021-12-21 17:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-19 22:39 [PATCH v10 00/14] iio: afe: add temperature rescaling support Liam Beguin
2021-12-19 22:39 ` [PATCH v10 01/14] iio: inkern: apply consumer scale on IIO_VAL_INT cases Liam Beguin
2021-12-19 22:39 ` [PATCH v10 02/14] iio: inkern: apply consumer scale when no channel scale is available Liam Beguin
2021-12-19 22:39 ` [PATCH v10 03/14] iio: inkern: make a best effort on offset calculation Liam Beguin
2021-12-21 5:42 ` Andy Shevchenko
2021-12-21 17:50 ` Liam Beguin [this message]
2021-12-19 22:39 ` [PATCH v10 04/14] iio: afe: rescale: expose scale processing function Liam Beguin
[not found] ` <CAHp75VdfPf6FMvkGqhhQg5e5XE1cgE-K8seobe5n0yGarnPGtQ@mail.gmail.com>
2021-12-21 5:43 ` Andy Shevchenko
2021-12-22 2:28 ` Liam Beguin
2021-12-19 22:39 ` [PATCH v10 05/14] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2021-12-19 22:39 ` [PATCH v10 06/14] iio: afe: rescale: add offset support Liam Beguin
2021-12-19 22:39 ` [PATCH v10 07/14] iio: afe: rescale: use s64 for temporary scale calculations Liam Beguin
2021-12-19 22:39 ` [PATCH v10 08/14] iio: afe: rescale: fix accuracy for small fractional scales Liam Beguin
2021-12-19 22:39 ` [PATCH v10 09/14] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2021-12-19 22:39 ` [PATCH v10 10/14] iio: test: add basic tests for the iio-rescale driver Liam Beguin
2021-12-21 7:09 ` kernel test robot
2021-12-21 7:09 ` kernel test robot
2021-12-21 8:03 ` kernel test robot
2021-12-21 8:03 ` kernel test robot
2021-12-19 22:39 ` [PATCH v10 11/14] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2021-12-19 22:39 ` [PATCH v10 12/14] iio: afe: rescale: add temperature transducers Liam Beguin
2021-12-19 22:39 ` [PATCH v10 13/14] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2021-12-19 22:39 ` [PATCH v10 14/14] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin
2021-12-20 21:37 ` [PATCH v10 00/14] iio: afe: add temperature rescaling support Peter Rosin
2021-12-22 3:29 ` Liam Beguin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcIT3BSIKJKVWAgN@shaak \
--to=liambeguin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.