From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5FDC433EF for ; Tue, 21 Dec 2021 18:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240962AbhLUSNO (ORCPT ); Tue, 21 Dec 2021 13:13:14 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:37543 "EHLO mail-qk1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240915AbhLUSNN (ORCPT ); Tue, 21 Dec 2021 13:13:13 -0500 Received: by mail-qk1-f175.google.com with SMTP id m186so13393544qkb.4; Tue, 21 Dec 2021 10:13:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FgGg2+AitqaP56Vm5YjQbOGniqdnRT3Htjx11pTGsHI=; b=Da7tFk/6tYiRshAfP61sYreV1E/+BbSJNkMnGtPtKU0wNFw11NXZ/igXaqyqSWFFBK sWb3NsVAj7Qifkyte18rLu5++QAMRKpOZ667Usam2zDrBTWXT/GwxP8FISB7qW/rHjD/ zut5GLlaFGAzU0fxSxIZnfljHVzqGpzyIJvub5/F0BskLp7cRMrWDPfLWAyMBMmx92P2 uazpVdsg2CIZbFiSD2vlUpegax2WQeUOKP84oD2L8V+ikIW9aRgq2/4b0PKuMafxkaiT NxdOXEWVzUbXzbx7i7dJ0FmnQtdO0BtYV2nTgjYBlR6wcpQRjzmRePizn5gDSRBn6ZDf e8gA== X-Gm-Message-State: AOAM532EFPldzYsAxAgaudZJSkq3BZ3b7wcF9+6NCGk7VEAaSB9TAonI X4VDKVZTBXWJDi967GM9Hw== X-Google-Smtp-Source: ABdhPJzQOQFLlDsziLyuvLEMaPbhJnT/tO8cXDb76gkkArdTN7ToTzKDvDS0PliXy7FOIxJcAUWOrg== X-Received: by 2002:a05:620a:f12:: with SMTP id v18mr3010095qkl.720.1640110392914; Tue, 21 Dec 2021 10:13:12 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id t18sm18368027qtw.64.2021.12.21.10.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 10:13:12 -0800 (PST) Received: (nullmailer pid 1519162 invoked by uid 1000); Tue, 21 Dec 2021 18:13:09 -0000 Date: Tue, 21 Dec 2021 14:13:09 -0400 From: Rob Herring To: Tony Lindgren Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Tero Kristo Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel Message-ID: References: <20211217113640.59840-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211217113640.59840-1-tony@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote: > In order to prepare for fixing lots of devicetree unique_unit_address > warnings for the TI clock nodes, let's add a binding for the clksel > clocks. This allows us to move the overlapping devicetree clocks to be > children of the related clksel nodes. And then we need the reg property > only for the parent clksel node. > > We want to set #clock-cells = <1> in case we ever start parsing the clkcsel > clocks directly using a clksel driver rather than using the existing > component clock drivers and child nodes. We also need to update the clock > drivers to get the IO address from the parent clksel node before updating > the dts files. These will be posted as separate patches. > > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- > .../bindings/clock/ti/ti,clksel.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > > diff --git a/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml b/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/ti/ti,clksel.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Binding for TI clksel clock > + > +maintainers: > + - Tony Lindgren > + > +description: | > + The TI CLKSEL clocks consist of consist of a mux, divider, multiplier and > + gate bits. > + > +properties: > + compatible: > + const: ti,clksel > + > + reg: > + maxItems: 1 > + description: The CLKSEL register > + > + "#clock-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: true Like what properties? true is only used for common, incomplete schemas referenced by device schemas. > + > +examples: > + - | > + clksel_gfx_fclk: clock@52c { > + compatible = "ti,clksel"; > + reg = <0x25c 0x4>; > + #clock-cells = <1>; > + }; > +... > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 639FAC433F5 for ; Tue, 21 Dec 2021 18:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WsDP6c47MUY4zpLw4pebJXUcEgxvcN8ftIe4A50CNks=; b=gBADakV3lC6ztc +ZobuIAju2zBlk7eMNtRFMfOZb20cQ2nOIjYRluGZqhWwPB/VXOtY5qXI/zzKH7SccCCo8Kzn1spL DpnbaE/UmTTzkAKuEiOXp7xEBz55Yk1/eSbsvDTDqq14ljOmb2Fot/eao4sefvmuDrSVWDpksIJDg +XmL2+BY+18PvDhcP/7+setIYjsDyTRS5xh29a8iwFx4OPDEWM6UO96GSZYvseoo8NbIIZPFks+dt Bnni7UkwxhNIbITGM5552HoKxJVMwO6J1vOhjD2i9D3GeMPkFu38ks9wtcar9zJgSzH+9cHzTqrKF ns7yqBG+qo0SBD/T+XrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzjiC-00837h-0W; Tue, 21 Dec 2021 18:18:08 +0000 Received: from mail-qk1-f181.google.com ([209.85.222.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzjdS-0081k7-HO for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 18:13:16 +0000 Received: by mail-qk1-f181.google.com with SMTP id a11so13336725qkh.13 for ; Tue, 21 Dec 2021 10:13:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FgGg2+AitqaP56Vm5YjQbOGniqdnRT3Htjx11pTGsHI=; b=sJpp2q7Jlqrs6k5q+aqFRmlgmH0BMR88NsjyM3h/W6G1aKo0efUaMO+0X8WKyAyBn4 Nsay1WdRpNNcwDSzmwy9ky54Sv2EqVqa0eEJM/vu+sB1NUaDRMk/YCOUJkZYwZAUrww+ 8iNat43pxFe0tEiWnMZXzNa1MK6jRKd/vwxZIjGLEqgepWj9UVcsnloe+EOTF/5xXLpo MKiNxo4pxHktqEoPkjIF9RQlwvzZ1tAh+ZkXuhVP5lGSg5++RRGcwajBuppUhHCXL21L JK/GcDflVjm5MPQbg3hrqrf+3aNxpOFtRu000LV0gOxTxoMQCsYeUrwaH24aTF/WRuFd 1pag== X-Gm-Message-State: AOAM530K0R0h8G1CikFUWlpi2VLGBQS+X6Aa+at7tt18PplzBdODLesg HGaS0c+bjvOd1MMrry/k3+KRUSA0N99r X-Google-Smtp-Source: ABdhPJzQOQFLlDsziLyuvLEMaPbhJnT/tO8cXDb76gkkArdTN7ToTzKDvDS0PliXy7FOIxJcAUWOrg== X-Received: by 2002:a05:620a:f12:: with SMTP id v18mr3010095qkl.720.1640110392914; Tue, 21 Dec 2021 10:13:12 -0800 (PST) Received: from robh.at.kernel.org ([24.55.105.145]) by smtp.gmail.com with ESMTPSA id t18sm18368027qtw.64.2021.12.21.10.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 10:13:12 -0800 (PST) Received: (nullmailer pid 1519162 invoked by uid 1000); Tue, 21 Dec 2021 18:13:09 -0000 Date: Tue, 21 Dec 2021 14:13:09 -0400 From: Rob Herring To: Tony Lindgren Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Tero Kristo Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel Message-ID: References: <20211217113640.59840-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211217113640.59840-1-tony@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_101314_622912_851A03E7 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote: > In order to prepare for fixing lots of devicetree unique_unit_address > warnings for the TI clock nodes, let's add a binding for the clksel > clocks. This allows us to move the overlapping devicetree clocks to be > children of the related clksel nodes. And then we need the reg property > only for the parent clksel node. > > We want to set #clock-cells = <1> in case we ever start parsing the clkcsel > clocks directly using a clksel driver rather than using the existing > component clock drivers and child nodes. We also need to update the clock > drivers to get the IO address from the parent clksel node before updating > the dts files. These will be posted as separate patches. > > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- > .../bindings/clock/ti/ti,clksel.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > > diff --git a/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml b/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/ti/ti,clksel.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Binding for TI clksel clock > + > +maintainers: > + - Tony Lindgren > + > +description: | > + The TI CLKSEL clocks consist of consist of a mux, divider, multiplier and > + gate bits. > + > +properties: > + compatible: > + const: ti,clksel > + > + reg: > + maxItems: 1 > + description: The CLKSEL register > + > + "#clock-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: true Like what properties? true is only used for common, incomplete schemas referenced by device schemas. > + > +examples: > + - | > + clksel_gfx_fclk: clock@52c { > + compatible = "ti,clksel"; > + reg = <0x25c 0x4>; > + #clock-cells = <1>; > + }; > +... > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel