From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17DAC433F5 for ; Wed, 22 Dec 2021 06:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242731AbhLVGY0 (ORCPT ); Wed, 22 Dec 2021 01:24:26 -0500 Received: from muru.com ([72.249.23.125]:41156 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233176AbhLVGYZ (ORCPT ); Wed, 22 Dec 2021 01:24:25 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D33BB8107; Wed, 22 Dec 2021 06:25:07 +0000 (UTC) Date: Wed, 22 Dec 2021 08:24:22 +0200 From: Tony Lindgren To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Tero Kristo Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel Message-ID: References: <20211217113640.59840-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Rob Herring [211221 18:13]: > On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote: > > +additionalProperties: true > > Like what properties? > > true is only used for common, incomplete schemas referenced by device > schemas. There is a collection of the current component clock child nodes for each clksel instance. I got warnings with "additionalProperties: false", but maybe the child clock nodes need to be somehow specified in the binding? For example, below is a sample patch for am335x CLKSEL_GFX_FCLK using a clksel parent node with the child nodes moved to fix warnings for unique_unit_address. It also has clock-output-names property added to avoid the node naming warnings. For the other clksel instances, they can be a collection of dividers, multipliers, gates and muxes. Regards, Tony 8< -------- diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi --- a/arch/arm/boot/dts/am33xx-clocks.dtsi +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi @@ -494,20 +494,27 @@ mmc_clk: mmc_clk { clock-div = <2>; }; - gfx_fclk_clksel_ck: gfx_fclk_clksel_ck@52c { - #clock-cells = <0>; - compatible = "ti,mux-clock"; - clocks = <&dpll_core_m4_ck>, <&dpll_per_m2_ck>; - ti,bit-shift = <1>; - reg = <0x052c>; - }; + clock@52c { + compatible = "ti,clksel"; + reg = <0x52c>; + #clock-cells = <1>; + #address-cells = <0>; + + gfx_fclk_clksel_ck: clock-gfx-fclk-clksel { + #clock-cells = <0>; + compatible = "ti,mux-clock"; + clock-output-names = "gfx_fclk_clksel_ck"; + clocks = <&dpll_core_m4_ck>, <&dpll_per_m2_ck>; + ti,bit-shift = <1>; + }; - gfx_fck_div_ck: gfx_fck_div_ck@52c { - #clock-cells = <0>; - compatible = "ti,divider-clock"; - clocks = <&gfx_fclk_clksel_ck>; - reg = <0x052c>; - ti,max-div = <2>; + gfx_fck_div_ck: clock-gfx-fck-div { + #clock-cells = <0>; + compatible = "ti,divider-clock"; + clock-output-names = "gfx_fck_div_ck"; + clocks = <&gfx_fclk_clksel_ck>; + ti,max-div = <2>; + }; }; sysclkout_pre_ck: sysclkout_pre_ck@700 { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E72EC433EF for ; Wed, 22 Dec 2021 06:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YVtPrxgj+6bqAlYHvjXwwl0VXf+9Xx4kx5K/eNH5tg=; b=yLss+LALebOmYs H81VQ4a8L1QLfG46d7o4WQZLogXxZGjSXV0mVIQtcrWi4z7qcFhkN9O91+pUadRPm2Y25XE/Cn/bo ec1Spxf2DCvJleJ1mMcXWx6OBLFhhcCnyFSjqHw1ijS45lZrXXcSTbmaYaC9u8ipOWszsLCKj+gLD 4JuOgOkzTnUkW2LUgi8tph7Y58rQBYXC5JJmHSi8IIwPACcbTnVG9H+1vu8aY29Pcqu2GsIh0jwwO rhNVz9ORA/IrUTIFO6gYSmcYSoQlxfTXiuh5SuTjy3xmyQkq22EsRIGjB2aJCSvPzRFzW3vxFD2VP DfZGWnETV0E0/dUQ1NiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzv37-009LGq-PA; Wed, 22 Dec 2021 06:24:29 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzv34-009LGC-If for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 06:24:28 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D33BB8107; Wed, 22 Dec 2021 06:25:07 +0000 (UTC) Date: Wed, 22 Dec 2021 08:24:22 +0200 From: Tony Lindgren To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Tero Kristo Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel Message-ID: References: <20211217113640.59840-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_222426_707041_1368AEBF X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Rob Herring [211221 18:13]: > On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote: > > +additionalProperties: true > > Like what properties? > > true is only used for common, incomplete schemas referenced by device > schemas. There is a collection of the current component clock child nodes for each clksel instance. I got warnings with "additionalProperties: false", but maybe the child clock nodes need to be somehow specified in the binding? For example, below is a sample patch for am335x CLKSEL_GFX_FCLK using a clksel parent node with the child nodes moved to fix warnings for unique_unit_address. It also has clock-output-names property added to avoid the node naming warnings. For the other clksel instances, they can be a collection of dividers, multipliers, gates and muxes. Regards, Tony 8< -------- diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi --- a/arch/arm/boot/dts/am33xx-clocks.dtsi +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi @@ -494,20 +494,27 @@ mmc_clk: mmc_clk { clock-div = <2>; }; - gfx_fclk_clksel_ck: gfx_fclk_clksel_ck@52c { - #clock-cells = <0>; - compatible = "ti,mux-clock"; - clocks = <&dpll_core_m4_ck>, <&dpll_per_m2_ck>; - ti,bit-shift = <1>; - reg = <0x052c>; - }; + clock@52c { + compatible = "ti,clksel"; + reg = <0x52c>; + #clock-cells = <1>; + #address-cells = <0>; + + gfx_fclk_clksel_ck: clock-gfx-fclk-clksel { + #clock-cells = <0>; + compatible = "ti,mux-clock"; + clock-output-names = "gfx_fclk_clksel_ck"; + clocks = <&dpll_core_m4_ck>, <&dpll_per_m2_ck>; + ti,bit-shift = <1>; + }; - gfx_fck_div_ck: gfx_fck_div_ck@52c { - #clock-cells = <0>; - compatible = "ti,divider-clock"; - clocks = <&gfx_fclk_clksel_ck>; - reg = <0x052c>; - ti,max-div = <2>; + gfx_fck_div_ck: clock-gfx-fck-div { + #clock-cells = <0>; + compatible = "ti,divider-clock"; + clock-output-names = "gfx_fck_div_ck"; + clocks = <&gfx_fclk_clksel_ck>; + ti,max-div = <2>; + }; }; sysclkout_pre_ck: sysclkout_pre_ck@700 { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel