From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60B662CA0 for ; Wed, 22 Dec 2021 09:41:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC5FCC36AE8; Wed, 22 Dec 2021 09:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640166096; bh=ll6r6iFiIjnDzOOMGdh3cRWmd3j5C6kuu3h5I41Vy5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kljr7CwXjMTDgWu3numUdUj33/4jHLsgDLTgvtTfzW2DZyP3TQaMtApKhfQb8Ta29 a85IZZ6ZYoCfOWcaARnFtPou4ZgR6hKEY7i7v1IKf421lr+3to296XMrsFRSuLcedz yZiaIO+QoS4wSEhHzAdT892c1IUd8bMw18wb2dQ4= Date: Wed, 22 Dec 2021 10:41:33 +0100 From: Greg KH To: Paulo Miguel Almeida Cc: realwakka@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: add comment to rx_lock mutex definition Message-ID: References: <20211222093626.GA13332@localhost.localdomain> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211222093626.GA13332@localhost.localdomain> On Wed, Dec 22, 2021 at 10:36:26PM +1300, Paulo Miguel Almeida wrote: > Checkpatch reports: CHECK: struct mutex definition without comment. > Fix this by documenting what rx_mutex struct is used for in pi433 driver. > > Signed-off-by: Paulo Miguel Almeida > --- > drivers/staging/pi433/pi433_if.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 29bd37669059..aa0ecb3788c6 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -92,6 +92,7 @@ struct pi433_device { > u32 rx_bytes_to_drop; > u32 rx_bytes_dropped; > unsigned int rx_position; > + /* rx read and config operations can only be served one at the time */ What exactly does this mean? What is this protecting? This comment doesn't seem to be explaining much :( thanks, greg k-h