From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EE5C433F5 for ; Wed, 22 Dec 2021 11:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244502AbhLVLQ0 (ORCPT ); Wed, 22 Dec 2021 06:16:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236846AbhLVLQZ (ORCPT ); Wed, 22 Dec 2021 06:16:25 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D2AC061401 for ; Wed, 22 Dec 2021 03:16:24 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id e5so4182642wrc.5 for ; Wed, 22 Dec 2021 03:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XPWgMgD0XzqoivywAckaojk88eeT9YD0wWezKrZwghA=; b=TSQvltnJVjN3Yxq5i38Kl4Zl+tIZLyfhNSEv8RP6YUqRZeNA+cHVSjDndysUjDRfNp 9pAxUCsoF4c4bKarlN0yohlCyEkXltFo0uTGZxKKnBMkys0KDKqKJUCK6sfApzEY760Q DxigGxoUD2smGsMvnNnitkRtD7vIBrGHLvEEhCkuwmQcG8/S50V0jWiC13Q8+drZ6UGi ZOnLihm7FMgr7wIL/QE4t0vWJlNZFkN6IagPIfkODJ67ckYHngyQmVRleLEBj/zqVS8m uHgpx3J2J/U6g5OgwHEfuZ2FziBzKqcQ9jks70Dz3h8BmSJJQRBvcjKrIJQmSpaeD33R 16yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XPWgMgD0XzqoivywAckaojk88eeT9YD0wWezKrZwghA=; b=FKWNzQ+qOV4NJfdmi3RiX3Am4gsCtc4tf3c3xqo8YYG16jUnPKcWQ/QHGfAHh6ZCY7 iN1IV1Nb4WVnKd8w0B008WGagDsur2tL1CkbKemGz/QvWuRBRSigexe+QtbtknPe2cah Xpt+RV48Zw5OuUvR3CRjogTFYX+WAvRcsfb/ydI9J3z9wN6WiqQZpl07UTGM48Oq1rg+ 6eqht8JxUpNLiP4+/1IeeU7b33npy06gwsA+JHIfPpT1UxwUiegATZCi9QwQpnjSB7D7 EJnHtJUSYC9MRZ8uN6+Veha01nGcsc80KGqtPWdXSr/eLo1sPQ7Ki4+2bFRklV3bSpP8 Y+mQ== X-Gm-Message-State: AOAM530sEJ6tLjfSJ2sLoQbM0rNTt3ytHeIWe9gsMAQBToOGPscRecgi F2iyc8Vy4Ik6v9l+Xu7OEIHMug== X-Google-Smtp-Source: ABdhPJzkB3s0YBKaAq8SlAKtUF6TM0YviOwwlicJEmYHnBrD6uxPU06eJZhrr/MgKRKs9FFzJP99HA== X-Received: by 2002:a5d:564f:: with SMTP id j15mr1733297wrw.366.1640171783261; Wed, 22 Dec 2021 03:16:23 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id j3sm1612934wrt.14.2021.12.22.03.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 03:16:22 -0800 (PST) Date: Wed, 22 Dec 2021 11:16:20 +0000 From: Lee Jones To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Daniel Thompson , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211115203459.1634079-4-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211115203459.1634079-4-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 15 Nov 2021, Marijn Suijten wrote: > The kernel already provides appropriate primitives to perform endianness > conversion which should be used in favour of manual bit-wrangling. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/video/backlight/qcom-wled.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5205BC433EF for ; Wed, 22 Dec 2021 11:16:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E0D210E85C; Wed, 22 Dec 2021 11:16:25 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id B016D10E85C for ; Wed, 22 Dec 2021 11:16:24 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id t26so4176620wrb.4 for ; Wed, 22 Dec 2021 03:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XPWgMgD0XzqoivywAckaojk88eeT9YD0wWezKrZwghA=; b=TSQvltnJVjN3Yxq5i38Kl4Zl+tIZLyfhNSEv8RP6YUqRZeNA+cHVSjDndysUjDRfNp 9pAxUCsoF4c4bKarlN0yohlCyEkXltFo0uTGZxKKnBMkys0KDKqKJUCK6sfApzEY760Q DxigGxoUD2smGsMvnNnitkRtD7vIBrGHLvEEhCkuwmQcG8/S50V0jWiC13Q8+drZ6UGi ZOnLihm7FMgr7wIL/QE4t0vWJlNZFkN6IagPIfkODJ67ckYHngyQmVRleLEBj/zqVS8m uHgpx3J2J/U6g5OgwHEfuZ2FziBzKqcQ9jks70Dz3h8BmSJJQRBvcjKrIJQmSpaeD33R 16yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XPWgMgD0XzqoivywAckaojk88eeT9YD0wWezKrZwghA=; b=3NHVdGqEEPcciBtt4/OcBBmIqvcR+bw3qTwDT7sRNFwegxyiC649ZVuUzqvWpqs8fU tlJijDCSsYG0lAYVZYlX10TYwEcqbA+9hIbd1L7eeYfdijj3UA4SZTguOnmffHvf31JF 7XMcTN2r4ZSnlJ40ZxRK72AAG+E0UeeO3CxdUuvB4513glCjTQLUOY3SMgC+J97PHga3 7V8LVGybIEKefRfbz6gFUqbsxW1FCUIaan4viAr+ZZKY70wIJ9K7jUY8YxTXJqBNIQX6 2TzceaR/HiS7nOVdXkz3BGVkaC838rALMbpDWOYhfh5uBv/KR0TxpRhThaDWlfjYzd1V AuUw== X-Gm-Message-State: AOAM531lOuIvxu67ucw/qMo/huSwbq+tWqe4tOCNsbbAvvhvRjm0MGJG XsADq1vy1ZSsKWqDiQa72ssIGg== X-Google-Smtp-Source: ABdhPJzkB3s0YBKaAq8SlAKtUF6TM0YviOwwlicJEmYHnBrD6uxPU06eJZhrr/MgKRKs9FFzJP99HA== X-Received: by 2002:a5d:564f:: with SMTP id j15mr1733297wrw.366.1640171783261; Wed, 22 Dec 2021 03:16:23 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id j3sm1612934wrt.14.2021.12.22.03.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 03:16:22 -0800 (PST) Date: Wed, 22 Dec 2021 11:16:20 +0000 From: Lee Jones To: Marijn Suijten Subject: Re: [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211115203459.1634079-4-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211115203459.1634079-4-marijn.suijten@somainline.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Daniel Thompson , Kiran Gunda , Pavel Dubrova , Jami Kettunen , Jingoo Han , linux-arm-msm@vger.kernel.org, Bryan Wu , Konrad Dybcio , linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Andy Gross , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, linux-fbdev@vger.kernel.org, AngeloGioacchino Del Regno , phone-devel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 15 Nov 2021, Marijn Suijten wrote: > The kernel already provides appropriate primitives to perform endianness > conversion which should be used in favour of manual bit-wrangling. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/video/backlight/qcom-wled.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog