From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796D6C433F5 for ; Wed, 22 Dec 2021 23:52:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245755AbhLVXwp (ORCPT ); Wed, 22 Dec 2021 18:52:45 -0500 Received: from mail.netfilter.org ([217.70.188.207]:41626 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbhLVXwp (ORCPT ); Wed, 22 Dec 2021 18:52:45 -0500 Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 8B9EC607C4; Thu, 23 Dec 2021 00:50:10 +0100 (CET) Date: Thu, 23 Dec 2021 00:52:40 +0100 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH iptables] nft-shared: set correc register value Message-ID: References: <20211218201415.257721-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211218201415.257721-1-fw@strlen.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sat, Dec 18, 2021 at 09:14:15PM +0100, Florian Westphal wrote: > reg is populated based off the payload base: > > NFTNL_EXPR_META_KEY = NFTNL_EXPR_BASE, > NFTNL_EXPR_META_DREG, > NFTNL_EXPR_PAYLOAD_DREG = NFTNL_EXPR_BASE, > > Fix this. It worked because the simple nft rules > currently generated via ipables-nft have > base == register-number but this is a coincidence. s/correc/correct/ other than that, LGTM, thanks