From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: linux-media@vger.kernel.org, Robert Foss <robert.foss@linaro.org>,
Todor Tomov <todor.too@gmail.com>, Andy Gross <agross@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>,
linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 02/13] media: camss: Use platform_get_irq_byname() to get the interrupt
Date: Thu, 23 Dec 2021 10:06:38 -0800 [thread overview]
Message-ID: <YcS6rl+dFqhH7giF@ripper> (raw)
In-Reply-To: <20211223173015.22251-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Thu 23 Dec 09:30 PST 2021, Lad Prabhakar wrote:
> platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq_byname().
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 12 ++++--------
> drivers/media/platform/qcom/camss/camss-csiphy.c | 12 ++++--------
> drivers/media/platform/qcom/camss/camss-ispif.c | 12 ++++--------
> drivers/media/platform/qcom/camss/camss-vfe.c | 12 ++++--------
> 4 files changed, 16 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index a1637b78568b..ac3504e98668 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -544,7 +544,6 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
> {
> struct device *dev = camss->dev;
> struct platform_device *pdev = to_platform_device(dev);
> - struct resource *r;
> int i, j;
> int ret;
>
> @@ -571,14 +570,11 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>
> /* Interrupt */
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
> - res->interrupt[0]);
> - if (!r) {
> - dev_err(dev, "missing IRQ\n");
> - return -EINVAL;
> - }
> + ret = platform_get_irq_byname(pdev, res->interrupt[0]);
> + if (ret < 0)
> + return ret;
>
> - csid->irq = r->start;
> + csid->irq = ret;
> snprintf(csid->irq_name, sizeof(csid->irq_name), "%s_%s%d",
> dev_name(dev), MSM_CSID_NAME, csid->id);
> ret = devm_request_irq(dev, csid->irq, csid->ops->isr,
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
> index 24eec16197e7..6b225d06f35a 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
> @@ -568,7 +568,6 @@ int msm_csiphy_subdev_init(struct camss *camss,
> {
> struct device *dev = camss->dev;
> struct platform_device *pdev = to_platform_device(dev);
> - struct resource *r;
> int i, j;
> int ret;
>
> @@ -611,14 +610,11 @@ int msm_csiphy_subdev_init(struct camss *camss,
>
> /* Interrupt */
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
> - res->interrupt[0]);
> - if (!r) {
> - dev_err(dev, "missing IRQ\n");
> - return -EINVAL;
> - }
> + ret = platform_get_irq_byname(pdev, res->interrupt[0]);
> + if (ret < 0)
> + return ret;
>
> - csiphy->irq = r->start;
> + csiphy->irq = ret;
> snprintf(csiphy->irq_name, sizeof(csiphy->irq_name), "%s_%s%d",
> dev_name(dev), MSM_CSIPHY_NAME, csiphy->id);
>
> diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
> index ba5d65f6ef34..4ee11bb979cd 100644
> --- a/drivers/media/platform/qcom/camss/camss-ispif.c
> +++ b/drivers/media/platform/qcom/camss/camss-ispif.c
> @@ -1100,7 +1100,6 @@ int msm_ispif_subdev_init(struct camss *camss,
> struct device *dev = camss->dev;
> struct ispif_device *ispif = camss->ispif;
> struct platform_device *pdev = to_platform_device(dev);
> - struct resource *r;
> int i;
> int ret;
>
> @@ -1153,14 +1152,11 @@ int msm_ispif_subdev_init(struct camss *camss,
>
> /* Interrupt */
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_IRQ, res->interrupt);
> -
> - if (!r) {
> - dev_err(dev, "missing IRQ\n");
> - return -EINVAL;
> - }
> + ret = platform_get_irq_byname(pdev, res->interrupt);
> + if (ret < 0)
> + return ret;
>
> - ispif->irq = r->start;
> + ispif->irq = ret;
> snprintf(ispif->irq_name, sizeof(ispif->irq_name), "%s_%s",
> dev_name(dev), MSM_ISPIF_NAME);
> if (camss->version == CAMSS_8x16)
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 71f78b40e7f5..7c2311d70546 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -1279,7 +1279,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> {
> struct device *dev = camss->dev;
> struct platform_device *pdev = to_platform_device(dev);
> - struct resource *r;
> int i, j;
> int ret;
>
> @@ -1312,14 +1311,11 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
>
> /* Interrupt */
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
> - res->interrupt[0]);
> - if (!r) {
> - dev_err(dev, "missing IRQ\n");
> - return -EINVAL;
> - }
> + ret = platform_get_irq_byname(pdev, res->interrupt[0]);
> + if (ret < 0)
> + return ret;
>
> - vfe->irq = r->start;
> + vfe->irq = ret;
> snprintf(vfe->irq_name, sizeof(vfe->irq_name), "%s_%s%d",
> dev_name(dev), MSM_VFE_NAME, vfe->id);
> ret = devm_request_irq(dev, vfe->irq, vfe->ops->isr,
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-12-23 18:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 17:30 [PATCH 00/13] media: Use platform_get_irq*() variants to fetch IRQ's Lad Prabhakar
2021-12-23 17:30 ` [PATCH 01/13] media: vsp1: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-30 0:06 ` Laurent Pinchart
2021-12-30 12:32 ` Lad, Prabhakar
2021-12-23 17:30 ` [PATCH 02/13] media: camss: Use platform_get_irq_byname() " Lad Prabhakar
2021-12-23 18:06 ` Bjorn Andersson [this message]
2021-12-23 17:30 ` [PATCH 03/13] media: bdisp: Use platform_get_irq() " Lad Prabhakar
2021-12-23 17:30 ` [PATCH 04/13] media: s5p-mfc: " Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-28 8:42 ` Andrzej Hajda
2021-12-28 8:42 ` Andrzej Hajda
2021-12-23 17:30 ` [PATCH 05/13] media: stm32-dma2d: " Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 06/13] media: davinci: vpif: Use platform_get_irq_optional() " Lad Prabhakar
2021-12-25 17:32 ` Andy Shevchenko
2022-01-04 17:22 ` Lad, Prabhakar
2022-01-05 9:42 ` Andy Shevchenko
2022-01-05 17:41 ` Lad, Prabhakar
2022-01-06 13:43 ` Andy Shevchenko
2022-01-06 14:14 ` Andy Shevchenko
2022-01-06 15:27 ` Lad, Prabhakar
2022-01-06 16:01 ` Andy Shevchenko
2022-01-06 16:10 ` Lad, Prabhakar
2022-01-06 16:28 ` Andy Shevchenko
2022-01-06 16:46 ` Lad, Prabhakar
2021-12-23 17:30 ` [PATCH 07/13] media: exynos-gsc: Use platform_get_irq() " Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 08/13] media: marvell-ccic: " Lad Prabhakar
2021-12-23 17:30 ` [PATCH 09/13] media: mtk-vcodec: Drop unnecessary call to platform_get_resource() Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 10/13] media: exynos4-is: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 11/13] media: s5p-g2d: " Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 12/13] media: mtk-vpu: Drop unnecessary call to platform_get_resource() Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
2021-12-23 17:30 ` [PATCH 13/13] media: coda: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-23 17:30 ` Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcS6rl+dFqhH7giF@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.