From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 622CEC433EF for ; Fri, 24 Dec 2021 18:08:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E1CC817BB; Fri, 24 Dec 2021 19:07:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E1CC817BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640369291; bh=o+yCK9ACjFoh7YUFC0yTky2BeehNBi5YTM7DQK6Mp2I=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hBYlOq95MgJBNnwAhQKX5SCpvbJXDkQxmrWbJFUKpVdtJhMgQP4LUK8oMCsHomFv/ 60Ng3WjuogkQEmtuUyVavkTPHECQw+jOr6bANNNLlu0ikOHZUtuRV0Y8F5wvuBhVPi rU4sw69z3QCCAwQUUHD0eD7pIula2aDwLx0hIYyQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 72A8AF800FD; Fri, 24 Dec 2021 19:07:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 024FBF800FF; Fri, 24 Dec 2021 19:07:18 +0100 (CET) Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4252AF80084 for ; Fri, 24 Dec 2021 19:07:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4252AF80084 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RbXc0A07" Received: by mail-oi1-x232.google.com with SMTP id j185so14709108oif.8 for ; Fri, 24 Dec 2021 10:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4WwkxD9pRsYNmxI5wJenMz61e+2fgc2AqpBuPszq2ec=; b=RbXc0A07i189egi89NZXRTEqbxCb9KwdACbYmsqaXqiOGmfribp+2gFQgcsuJCGdBd jawfI1a7zsBghKnXIlDW7YZvmodr3pPce2rdVwl5KID+z+nPRmX3U7UbIQje37R9olq+ fntQorCcgI8ik+8Y5dP5ZYA1jRKnK5+vS+bMtHT79uFh09hIck7bW0ZIARnzmNLIB5Kf CeulPv8RenriKuwquuOYJ4OESwTeugUFdnu0Xx3afSs8nyaNj7bqY/Q7ak77+V4EZ5q7 XZKExRJv82hKWylcltqro9dO/ujOc6JinLOo/kOFuJAq6DMtCwh6DSMaWssM4hREhWbJ Eb3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4WwkxD9pRsYNmxI5wJenMz61e+2fgc2AqpBuPszq2ec=; b=P2crxMEaOhU9HIft3tzWoxPhZrhN5CCMWM8AYZqSnaLHf4vuCkR0x4tPN3dEK45g5C teIfkchCpDrjHPTu4lmvw3+6S+XxLcvQg0DunWCLPlpG3+C9pIe05xBQe8IcQSb0zPBJ BnOxp1c6VPc+qzsGVirRsE9737F03gH5Yl0djDXoQ14iwI/kH+1/XTifQjL2zA22/pEx b7KpSrGHPW7w/gZacjY2J8Xjy2dVhhuLhWL2RTCCKK7+mbJMAnhio09otz+UOVfyWDFR XvnYMlorsJQMxtH33QsYzowLMxGMW05L0oWxAyfQBwQBNdL717mq1liGRHB89NniZdcv iGyw== X-Gm-Message-State: AOAM532FcGBCsqceU96U6gASJYHfA/mDZ6E55uaC/49mbNMVJivBAM5V ObMOylVCZCks69LNBkHymlSUaw== X-Google-Smtp-Source: ABdhPJzJoKsrdaRl4JDv5CJ93Xuh7aO3Rr8Y4L/8xojES8sfdfdDcC9F1afkDy+uY0g7UIxoouFa9Q== X-Received: by 2002:a05:6808:e87:: with SMTP id k7mr5929610oil.16.1640369228274; Fri, 24 Dec 2021 10:07:08 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id bg38sm1801972oib.40.2021.12.24.10.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Dec 2021 10:07:07 -0800 (PST) Date: Fri, 24 Dec 2021 10:08:11 -0800 From: Bjorn Andersson To: Lad Prabhakar Subject: Re: [PATCH] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt Message-ID: References: <20211224161334.31123-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211224161334.31123-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211224161334.31123-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Prabhakar , Andy Gross , Srinivas Kandagatla X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri 24 Dec 08:13 PST 2021, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq(). > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Lad Prabhakar > --- > Hi, > > Dropping usage of platform_get_resource() was agreed based on > the discussion [0]. > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/ > patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Cheers, > Prabhakar > --- > drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > index 7040293c2ee8..0f29a08b4c09 100644 > --- a/drivers/slimbus/qcom-ngd-ctrl.c > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -1526,13 +1526,11 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) > if (IS_ERR(ctrl->base)) > return PTR_ERR(ctrl->base); > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!res) { > - dev_err(&pdev->dev, "no slimbus IRQ resource\n"); > - return -ENODEV; > - } > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) > + return ret; > > - ret = devm_request_irq(dev, res->start, qcom_slim_ngd_interrupt, > + ret = devm_request_irq(dev, ret, qcom_slim_ngd_interrupt, > IRQF_TRIGGER_HIGH, "slim-ngd", ctrl); > if (ret) { > dev_err(&pdev->dev, "request IRQ failed\n"); > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65DE9C433F5 for ; Fri, 24 Dec 2021 18:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241828AbhLXSHJ (ORCPT ); Fri, 24 Dec 2021 13:07:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239382AbhLXSHJ (ORCPT ); Fri, 24 Dec 2021 13:07:09 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2906CC061757 for ; Fri, 24 Dec 2021 10:07:09 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id t19so14792895oij.1 for ; Fri, 24 Dec 2021 10:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4WwkxD9pRsYNmxI5wJenMz61e+2fgc2AqpBuPszq2ec=; b=RbXc0A07i189egi89NZXRTEqbxCb9KwdACbYmsqaXqiOGmfribp+2gFQgcsuJCGdBd jawfI1a7zsBghKnXIlDW7YZvmodr3pPce2rdVwl5KID+z+nPRmX3U7UbIQje37R9olq+ fntQorCcgI8ik+8Y5dP5ZYA1jRKnK5+vS+bMtHT79uFh09hIck7bW0ZIARnzmNLIB5Kf CeulPv8RenriKuwquuOYJ4OESwTeugUFdnu0Xx3afSs8nyaNj7bqY/Q7ak77+V4EZ5q7 XZKExRJv82hKWylcltqro9dO/ujOc6JinLOo/kOFuJAq6DMtCwh6DSMaWssM4hREhWbJ Eb3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4WwkxD9pRsYNmxI5wJenMz61e+2fgc2AqpBuPszq2ec=; b=vEyAfEQUxJ4Mdba1iGdzUGKM/Cfia584KP952v71BkVQST8J1C5VFSthmjBYdMzU4s S2JGjde0ifdwkn6L4rYLWxv43j2Itic6qAXakZ+HgTrbcgS8O57I9BCr51BEByMAw4rZ gj2Nk8weUBnyBO7Dyfkzu8nRSqVvVcbGQYQzatl+galqUYSmT9MMo5gcyjSifq/bQFLp qfixmV4c6hkoC9J4O2b1ZPvnnuo3U/tW2eg9U5vGI98bxz1Goi7xSufa3NYri4V12GLB XWPksVXZ1Bo2kZIKWnjH6cnKKSopIaLwk0NfB8x6De+TgeeO0oYnR73U+GvBECapmzYl 1aFQ== X-Gm-Message-State: AOAM532J45I1NR/Op2Lo1IxYofNBNcUBi+FcBLeeRHS6YK46SZYZ9Z7q zlgHbt9Fbjd5HTnuaE8Yk61a3g== X-Google-Smtp-Source: ABdhPJzJoKsrdaRl4JDv5CJ93Xuh7aO3Rr8Y4L/8xojES8sfdfdDcC9F1afkDy+uY0g7UIxoouFa9Q== X-Received: by 2002:a05:6808:e87:: with SMTP id k7mr5929610oil.16.1640369228274; Fri, 24 Dec 2021 10:07:08 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id bg38sm1801972oib.40.2021.12.24.10.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Dec 2021 10:07:07 -0800 (PST) Date: Fri, 24 Dec 2021 10:08:11 -0800 From: Bjorn Andersson To: Lad Prabhakar Cc: linux-kernel@vger.kernel.org, Andy Gross , Srinivas Kandagatla , Rob Herring , Prabhakar , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt Message-ID: References: <20211224161334.31123-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211224161334.31123-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211224161334.31123-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 24 Dec 08:13 PST 2021, Lad Prabhakar wrote: > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq(). > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Lad Prabhakar > --- > Hi, > > Dropping usage of platform_get_resource() was agreed based on > the discussion [0]. > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/ > patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Cheers, > Prabhakar > --- > drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > index 7040293c2ee8..0f29a08b4c09 100644 > --- a/drivers/slimbus/qcom-ngd-ctrl.c > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -1526,13 +1526,11 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) > if (IS_ERR(ctrl->base)) > return PTR_ERR(ctrl->base); > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!res) { > - dev_err(&pdev->dev, "no slimbus IRQ resource\n"); > - return -ENODEV; > - } > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) > + return ret; > > - ret = devm_request_irq(dev, res->start, qcom_slim_ngd_interrupt, > + ret = devm_request_irq(dev, ret, qcom_slim_ngd_interrupt, > IRQF_TRIGGER_HIGH, "slim-ngd", ctrl); > if (ret) { > dev_err(&pdev->dev, "request IRQ failed\n"); > -- > 2.17.1 >