From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEF79C433F5 for ; Tue, 28 Dec 2021 07:13:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6C4831702; Tue, 28 Dec 2021 08:12:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6C4831702 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640675604; bh=VbHFquqj2jmnV6Iu3jh6A5YmaXODQzuHdjk3YMCz+Bg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MapvnBfj72Cg3jQ8DvlMZH8saikbt2g3K5XrwMt1HwTlGcv4/nBBM6vvD3roazOS2 iJSXHret7rSREiIN06zmaTXBaK5+2JqLi/s0lnR5rGNTTZk59xUeX0NHeoNCUi4bxc rJVwqGOZjGthJyiqVCmDlhBgZpEivoLhZZiqNGkA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CF466F800E9; Tue, 28 Dec 2021 08:12:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B7CECF80224; Tue, 28 Dec 2021 08:12:31 +0100 (CET) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 38AFEF800D3 for ; Tue, 28 Dec 2021 08:12:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 38AFEF800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="skfkrXno" Received: by mail-pj1-x102a.google.com with SMTP id rj2-20020a17090b3e8200b001b1944bad25so16275300pjb.5 for ; Mon, 27 Dec 2021 23:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=skfkrXnoE6gcXNsZO24JsoWju8VO7ddjO/I2mgv+T/TCep2bZbtmSO1O6ccPFzd5sD eFevQpVM1RXH/UkCEKzds05KO+5Kw14kClxop8CYk0tOqi8JG1EZboFb1FRhnmZ46gSx njV/5Nc+WWANbyAfOxa0uNzAy4a2qQ93p9JCAUyFVV4Sm/YCLhmuw2UFMPOq/YYslhzn lVDGd2co3ae6ImuSAbr8bUHlNJ58xtdeMLBRNgy7xL/ecBfYwcqD53//q2/QyMlWRmQK hkYw8wmshBE/+X1bq37jhosbWYqdBFPviHqGqAOqSzvrzYm9T9jQQOT92N7BVJam27Eo JvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=yczJfx6lAOKsg5HDs/cmz4OX5bfm3MJp2p2ceiS6NGhZkIBp2s/AOwLTILSkRVXARq 21JczI7WKt6lEIiM+uXKeT5/ANOYp36/Mef5ZZ4FX7Hx94FSxiNmxl2xDmPuw83PzosV m/3xb9CuKDIMMzA7T7vhKWib1jOrMJ4LxZ8iU7G7vGBQrLNUlpu/pNO6i1ycWHyPKfet Sku0bqCJyHrjZxVcZ2pXGzllGOAOQWpmlHTp9uSQkVULa2pDTYMuWGeVbtikkc3hVDyh YUxfq+uBUU+Cm48zPrSB1blH7eLPMZY5Nv3YgyRggyQKtCVpGc7KEtfTRsRFT5RQND1P yubA== X-Gm-Message-State: AOAM530t6hrIV7NEJK18i/oWPMV2n+cyIQlPGfgk/KqvzuTOZYhJIa8Q bGgEv5BZg1xnUvtqelx41lpBgw== X-Google-Smtp-Source: ABdhPJxgKDjojCITnOzByiXyEFe4d2LD2wr+DhASX8KwbIQB+3HttKHl2m/2SwjrTuCWYzRRF+QSYA== X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr25373225pji.117.1640675540049; Mon, 27 Dec 2021 23:12:20 -0800 (PST) Received: from google.com ([2401:fa00:1:10:a817:45ab:1beb:f01a]) by smtp.gmail.com with ESMTPSA id a4sm21708498pjw.30.2021.12.27.23.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 23:12:19 -0800 (PST) Date: Tue, 28 Dec 2021 15:12:16 +0800 From: Tzung-Bi Shih To: Trevor Wu Subject: Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682 series Message-ID: References: <20211228064821.27865-1-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211228064821.27865-1-trevor.wu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, shumingf@realtek.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, jiaxin.yu@mediatek.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Dec 28, 2021 at 02:48:21PM +0800, Trevor Wu wrote: > Playback pop is observed and the root cause is the reference clock > provided by MT8195 is diabled before RT5682 finishes the control flow. > > To ensure the reference clock supplied to RT5682 is disabled after RT5682 > finishes all register controls. We replace BCLK with MCLK for RT5682 > reference clock, and makes use of set_bias_level_post to handle MCLK > which guarantees MCLK is off after all RT5682 register access. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFC02C433F5 for ; Tue, 28 Dec 2021 07:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QwFIIo5g3mDeWgXNJAp1k+SfcFG6T7JF7y6Uj87Tg6M=; b=3E8DVQbzNlyrCS uQWsuGu/B/N3J37UYPmfzUrIsn5+oybN41+oeNjyNLSZVuKSXsTAH5Gi0IPeVNW5CeBPfjRE1DC16 BZwswM+K3B9ekXODt9fBk0BlPofpJ/qxdVOK+NecP9qE9CaXH3pjywvkBL1pRH9+TFa0OUCGAgHmr DS1XlJGAH40v9n14r3yzNISvbgzZdcKeEFNg3VM268TFqjHmAB897HIfLf7HDJZ0eH1n2v2DjdLH9 Wx7WdxNwQGGg4LnsZ+X5e94mdJrJYQY+FCr7lfavwghWcu0xCYIPGaWQ/oXU2GFFs1v9Q0+l6BQ6i 17Sw3Wqr9ase4G7ZQe/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n26eo-000LqQ-V0; Tue, 28 Dec 2021 07:12:26 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n26em-000Lp4-Cp for linux-mediatek@lists.infradead.org; Tue, 28 Dec 2021 07:12:25 +0000 Received: by mail-pj1-x1029.google.com with SMTP id jw3so15234969pjb.4 for ; Mon, 27 Dec 2021 23:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=skfkrXnoE6gcXNsZO24JsoWju8VO7ddjO/I2mgv+T/TCep2bZbtmSO1O6ccPFzd5sD eFevQpVM1RXH/UkCEKzds05KO+5Kw14kClxop8CYk0tOqi8JG1EZboFb1FRhnmZ46gSx njV/5Nc+WWANbyAfOxa0uNzAy4a2qQ93p9JCAUyFVV4Sm/YCLhmuw2UFMPOq/YYslhzn lVDGd2co3ae6ImuSAbr8bUHlNJ58xtdeMLBRNgy7xL/ecBfYwcqD53//q2/QyMlWRmQK hkYw8wmshBE/+X1bq37jhosbWYqdBFPviHqGqAOqSzvrzYm9T9jQQOT92N7BVJam27Eo JvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=1Ffq8T8+CFxde9hjJk2OSm3+/T43WgkOIRz2fQDp0pVU17rh+YylWk2hb5jMpSxh9W /gA8SmDg7uKsobGeV0w6kq0iLiXhkH7iXKX8zitkB8CZ0CCC3Xu+ZLq/M2iIomZD4Qs/ 1WvEumY/r0dlD+IyqzUiNF/aVG2yQlgxRsdYO1ABH9tiB3OsBTpB0sadiGSD2vqR2q6I iTpM7JTmPGWsppgolqKo49mghHh7N/4o3vZnL+BRc3ZnQql8T7TVv9K6tMpn/hn3ohro +wgZgDD7VKAV3s4mPq/KkSYIeRmBILj3mjXn+qbm0ub6AQ+aegSC4u2k+Wf8JLGG4ovm EU4w== X-Gm-Message-State: AOAM530PTA8xYTg7tWLaFUlScpJlf721dDDgsqtMtfXE+HsSK0e1VXt+ vtedWRr24HATDD0VQ1G73tsUtg== X-Google-Smtp-Source: ABdhPJxgKDjojCITnOzByiXyEFe4d2LD2wr+DhASX8KwbIQB+3HttKHl2m/2SwjrTuCWYzRRF+QSYA== X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr25373225pji.117.1640675540049; Mon, 27 Dec 2021 23:12:20 -0800 (PST) Received: from google.com ([2401:fa00:1:10:a817:45ab:1beb:f01a]) by smtp.gmail.com with ESMTPSA id a4sm21708498pjw.30.2021.12.27.23.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 23:12:19 -0800 (PST) Date: Tue, 28 Dec 2021 15:12:16 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jiaxin.yu@mediatek.com, shumingf@realtek.com Subject: Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682 series Message-ID: References: <20211228064821.27865-1-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211228064821.27865-1-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211227_231224_467374_277E3203 X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Dec 28, 2021 at 02:48:21PM +0800, Trevor Wu wrote: > Playback pop is observed and the root cause is the reference clock > provided by MT8195 is diabled before RT5682 finishes the control flow. > > To ensure the reference clock supplied to RT5682 is disabled after RT5682 > finishes all register controls. We replace BCLK with MCLK for RT5682 > reference clock, and makes use of set_bias_level_post to handle MCLK > which guarantees MCLK is off after all RT5682 register access. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B22B4C433EF for ; Tue, 28 Dec 2021 07:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MWB+d60HUZIm/GKt8l9wQxvovSodJd6HwzeFhCMy++8=; b=FXUjQ0xknZQXUk PNvOP378r67N9ZILHAM/Vsr2yoejuwxU+M/ihhyTKzoYbKKkq9UZz0iyF4P6U51DNEHDJTl9A48Ya guIS0CXzup+CCgBuIJjXQERnXWFIGG1aGInaqd/L+g2rGp3OGCqNW4lCUcgzAS2IPC32LI89JzcSm 05t9pwu/ayln/Ns97lTlXlibRZ+3zZ/CkL6XvdkZ4RUdLqoJOG8JUgWFz97UwhZknjwcB52nWt9FY TNSmKKZza299wrpe/TOhP/v5tucjEeKkclakIi8EAS9UWVY/cAIhFE09b7Z9M7xF1oAhaBpyQ0YUW 43rq6anCUHCtYkIvVTrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n26eq-000Lqd-I7; Tue, 28 Dec 2021 07:12:28 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n26em-000Lp5-D1 for linux-arm-kernel@lists.infradead.org; Tue, 28 Dec 2021 07:12:25 +0000 Received: by mail-pj1-x102a.google.com with SMTP id o63-20020a17090a0a4500b001b1c2db8145so20540454pjo.5 for ; Mon, 27 Dec 2021 23:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=skfkrXnoE6gcXNsZO24JsoWju8VO7ddjO/I2mgv+T/TCep2bZbtmSO1O6ccPFzd5sD eFevQpVM1RXH/UkCEKzds05KO+5Kw14kClxop8CYk0tOqi8JG1EZboFb1FRhnmZ46gSx njV/5Nc+WWANbyAfOxa0uNzAy4a2qQ93p9JCAUyFVV4Sm/YCLhmuw2UFMPOq/YYslhzn lVDGd2co3ae6ImuSAbr8bUHlNJ58xtdeMLBRNgy7xL/ecBfYwcqD53//q2/QyMlWRmQK hkYw8wmshBE/+X1bq37jhosbWYqdBFPviHqGqAOqSzvrzYm9T9jQQOT92N7BVJam27Eo JvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=So7iYSh7UReqq+z5BnHfgEXn8CImOgBGSee958TtLqAgE0jqyZmrc63ozw8S+OR7+d jkntSpx/E6G5feqn0iZhjg+2r5nt9DllOhoZC/RrxUvRQnDKAce0ysc1VC0abKLBvwEB 4pIB+O1QSjYeUK50XKzD+PDGRAsHy290fZhsybESwHEkWzmoUAUU3UXju/f9WcP+7ZaB ELeL4GcpBmGJDKOSjigNXVEcoTazvZhSborFwniDh+Xfed8vt1HZcqbS8v1IVWKRpBMg VnJlLtcDj+rLRC7ayBHIz09uT5e6Ii783pkp1N8TcBh8IkkbUum6gFkLW64M+y9QNfKa 8Smw== X-Gm-Message-State: AOAM530hJ4+IIzjrQGZQ+wqHJnhz8GznqtFQOpEvOPoCsTlDdJdtLQVB 1tf/nKrvqoIkBivo7cI/w3OuvQ== X-Google-Smtp-Source: ABdhPJxgKDjojCITnOzByiXyEFe4d2LD2wr+DhASX8KwbIQB+3HttKHl2m/2SwjrTuCWYzRRF+QSYA== X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr25373225pji.117.1640675540049; Mon, 27 Dec 2021 23:12:20 -0800 (PST) Received: from google.com ([2401:fa00:1:10:a817:45ab:1beb:f01a]) by smtp.gmail.com with ESMTPSA id a4sm21708498pjw.30.2021.12.27.23.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 23:12:19 -0800 (PST) Date: Tue, 28 Dec 2021 15:12:16 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jiaxin.yu@mediatek.com, shumingf@realtek.com Subject: Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682 series Message-ID: References: <20211228064821.27865-1-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211228064821.27865-1-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211227_231224_467830_A2ECDBE2 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 28, 2021 at 02:48:21PM +0800, Trevor Wu wrote: > Playback pop is observed and the root cause is the reference clock > provided by MT8195 is diabled before RT5682 finishes the control flow. > > To ensure the reference clock supplied to RT5682 is disabled after RT5682 > finishes all register controls. We replace BCLK with MCLK for RT5682 > reference clock, and makes use of set_bias_level_post to handle MCLK > which guarantees MCLK is off after all RT5682 register access. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E38C433EF for ; Tue, 28 Dec 2021 07:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235211AbhL1HMV (ORCPT ); Tue, 28 Dec 2021 02:12:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235208AbhL1HMU (ORCPT ); Tue, 28 Dec 2021 02:12:20 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C38C06173E for ; Mon, 27 Dec 2021 23:12:20 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id z9-20020a17090a7b8900b001b13558eadaso20554753pjc.4 for ; Mon, 27 Dec 2021 23:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=skfkrXnoE6gcXNsZO24JsoWju8VO7ddjO/I2mgv+T/TCep2bZbtmSO1O6ccPFzd5sD eFevQpVM1RXH/UkCEKzds05KO+5Kw14kClxop8CYk0tOqi8JG1EZboFb1FRhnmZ46gSx njV/5Nc+WWANbyAfOxa0uNzAy4a2qQ93p9JCAUyFVV4Sm/YCLhmuw2UFMPOq/YYslhzn lVDGd2co3ae6ImuSAbr8bUHlNJ58xtdeMLBRNgy7xL/ecBfYwcqD53//q2/QyMlWRmQK hkYw8wmshBE/+X1bq37jhosbWYqdBFPviHqGqAOqSzvrzYm9T9jQQOT92N7BVJam27Eo JvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NXYVCRlkl1arj3e8WvF9NDZ27UwRswxMzQ9HSWmcWkI=; b=OIgxgY+aWKb4VTJW9l5U6lWyZnKnpvhVp9A53dJXqL/petJTSqjCa5xlkhfFJfRT7Y wIR7pXwg+S52vYfZjXO7vK6wQk+jWavq7Wx2Ih9YTlsBMRPFHtjrUaMy5SoM+EdvIFQe 0cfqewTJml5rEqskZ567dPv+6XhoQ+g9bxJZprKXFPS3SGjh2p6XAH7I7XE9KSKH8v3Z YBtxdPH0N63O9capPtX87j0JvRyx/v01gRYXfGthH+cQ6RU83s5iDOwHtH67CcoGY2GX Cx+6j8Vc6VyPdxxVuoACnYsJJrnNparecp+n9Acnes72eIFnKZuqScCABri5w57rh5Ir f88Q== X-Gm-Message-State: AOAM533oN+mfOMWMgSkzVk2JDTDFYpvCF28igRfP4jqfhYkTYBe5kfhd xAIQiCZYzGDqWmmX6h5aCDZoqQ== X-Google-Smtp-Source: ABdhPJxgKDjojCITnOzByiXyEFe4d2LD2wr+DhASX8KwbIQB+3HttKHl2m/2SwjrTuCWYzRRF+QSYA== X-Received: by 2002:a17:90a:5d13:: with SMTP id s19mr25373225pji.117.1640675540049; Mon, 27 Dec 2021 23:12:20 -0800 (PST) Received: from google.com ([2401:fa00:1:10:a817:45ab:1beb:f01a]) by smtp.gmail.com with ESMTPSA id a4sm21708498pjw.30.2021.12.27.23.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Dec 2021 23:12:19 -0800 (PST) Date: Tue, 28 Dec 2021 15:12:16 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jiaxin.yu@mediatek.com, shumingf@realtek.com Subject: Re: [PATCH v2] ASoC: mediatek: mt8195: update control for RT5682 series Message-ID: References: <20211228064821.27865-1-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211228064821.27865-1-trevor.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Dec 28, 2021 at 02:48:21PM +0800, Trevor Wu wrote: > Playback pop is observed and the root cause is the reference clock > provided by MT8195 is diabled before RT5682 finishes the control flow. > > To ensure the reference clock supplied to RT5682 is disabled after RT5682 > finishes all register controls. We replace BCLK with MCLK for RT5682 > reference clock, and makes use of set_bias_level_post to handle MCLK > which guarantees MCLK is off after all RT5682 register access. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih