From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E89B1C433F5 for ; Wed, 29 Dec 2021 06:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W2t0EHghdZEZ/nMCrQ9vAkg6wwMVt0D2CUy16Xe/84c=; b=hKXBeeNVuIkYhh TBgZ1UQpSRCZkVk7wsKpwdqnAyRikWQ+hm2wlJt6Ko6Xg6iSUQLf/8rTBkEEXqLZJk5CMmDxsjcNe 3tJletyfYW6CN+K5zuI4n/+tIV+vUhWQPlzS7YEPpagnyzSudNdB8yYH5tsX2Ukxc9yYteOxpaOdw artr+ar1zaIV67k5Wf9peLimmWNqMKlOlBBJ1ATZKo9wYxs2r5eAQODXmEVkEEGDDM9No/CHOtypJ f8f3Rw05GauD9VdqPiwMDN69vQ+ec88FcGxsoagjr46ZFoRjY43GnZu0HrxFA6PDrPdVNsg7TPW6b sZ6e0AyxFZ385wjX9qBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2Sa9-002Leh-Kr; Wed, 29 Dec 2021 06:37:05 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2Sa7-002Lcl-6h for linux-mediatek@lists.infradead.org; Wed, 29 Dec 2021 06:37:04 +0000 Received: by mail-pl1-x634.google.com with SMTP id n16so15242920plc.2 for ; Tue, 28 Dec 2021 22:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=US3E/hqHlmnyPzOy/HskFnqIw6YITYtB3SecYzBz/TvRFRiaQ5DNALRLAG1KPwoX4J sdBQ2c6Fm0s8nGLH1iLRLu6FUqFDXjmD5E5kgs1rUOuHC+aCdtwY5dqh2Ev41kZOMVMb JT/44yXGfpcDJ/kOLKnYQIqs7HAjYlSLDIVP98i5KxF2HWCRbPPlFuiGAGcRbPQoTNpq pKVNacwTs8+fmivZ1QHilorH76JfKWLYlHAR+j1FcZCE4uG8HNOHvJyki9/G9qHZ9doc w3+mIdcw/VCRHpkDbNyJyPBV0iBAIkpoMwfbDuFPZgJmId3BIzA0/bGe1/XouW9QehRg 3+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=O1wbXVCy+VDUsReHnxTQzbf8+KSHoI9KXGwqgsJ7Dy3hldTqk9b5GIrckDRusM3ipQ OQdQn7f8WOpPxkbUy0kYXf8SA0mdf3DlQsJyLUiBq29zt8m6yVbqCEASt1fjwy5moWl3 Og6mt5zHGRVG2U/uftDDQ6xVp3NFagY8+90hdRWbuQmKB+HEFxhiWSRSBQJVA+Xd4062 bqejTE9O4zjKOrB13EhepDG78PvhN/wHy5CcDxbx3AIe09DIqorjSrZtAkbHubmXDVeV t9x+bNhyVzs5MBZAVAr8TvfmWZ9flrD595T8Um4hEI8cDM01EerUcz9WZP/JAi9msJ9j dj2A== X-Gm-Message-State: AOAM531onqNUyU0q0YZwlayx+JSxSwILBZnlAxW0AAKOpZHElrvXZ+Zs +Gjb+E1rQtJWC65rGjSvZbcjJw== X-Google-Smtp-Source: ABdhPJzbQgs3ZiPyG3g68c9CE72l8nXqFUBGdfo2PobHZ4oRqfWUj1AoQFmLtN/bznm5cjXVREY+kQ== X-Received: by 2002:a17:902:6a82:b0:148:a2e7:fb5c with SMTP id n2-20020a1709026a8200b00148a2e7fb5cmr25308794plk.157.1640759819836; Tue, 28 Dec 2021 22:36:59 -0800 (PST) Received: from google.com ([2401:fa00:1:10:4dea:2b20:ea89:724b]) by smtp.gmail.com with ESMTPSA id p37sm18097039pfh.97.2021.12.28.22.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 22:36:59 -0800 (PST) Date: Wed, 29 Dec 2021 14:36:54 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , AngeloGioacchino Del Regno , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Message-ID: References: <20211228094146.20505-1-yunfei.dong@mediatek.com> <20211228094146.20505-6-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_223703_277513_D5B2B872 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote: > From: Yunfei Dong Same as 4th patch. Please fix it. > For lat and core architecture, just need to get output buffer for lat > decode. For core hardware need to get lat's message and capture buffer. > In order to let lat and core decode in parallel, need to set capture > buffer buffered. I think the description should be rephrased. I may misunderstand but something like the template: """ OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel. Sets capture buffer buffered to ... """ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > index 5aebf88f997b..23a154c4e321 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx) > src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx, > V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); > > + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE) > + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1); s/1/true/ helps readability. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4873AC433EF for ; Wed, 29 Dec 2021 06:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YMgZpxz5jD9w15DrNN7JkAn968BUDHPDn2L6jWtwTrA=; b=zrCNsTtAEF3Xbh hjdjHEgDycqE2LB+3dkCt659NYdjuTmi93BDGmkUtnJOOeTpKraiWEOJR0BXp41yqjaVNin7tsiEg i9uqeTNJkjE4D7F5S86fUKaU2qVYcr5I6mLnWWAhGm95QAmZUGPDeq7iXhVeeUX73UPfEPWG5xk6i BDxDKaP7G/08gfXqSP8KYwiQzeI2LYvHeopuECuU1VV0OFZD1lJGMEk76+68PIMVVuNY1I+iy2Euv BOzfH6gC13sn7SQHb/7p3RnX6egXPQnpLyJCnVALQHn6omxjDQPbFVnniSo1BbNYuATxrg9GHvPTE FLgfOOazbuMNZtJeQm+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2SaC-002LfG-8B; Wed, 29 Dec 2021 06:37:08 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2Sa7-002Lck-9J for linux-arm-kernel@lists.infradead.org; Wed, 29 Dec 2021 06:37:05 +0000 Received: by mail-pl1-x636.google.com with SMTP id l15so422761pls.7 for ; Tue, 28 Dec 2021 22:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=US3E/hqHlmnyPzOy/HskFnqIw6YITYtB3SecYzBz/TvRFRiaQ5DNALRLAG1KPwoX4J sdBQ2c6Fm0s8nGLH1iLRLu6FUqFDXjmD5E5kgs1rUOuHC+aCdtwY5dqh2Ev41kZOMVMb JT/44yXGfpcDJ/kOLKnYQIqs7HAjYlSLDIVP98i5KxF2HWCRbPPlFuiGAGcRbPQoTNpq pKVNacwTs8+fmivZ1QHilorH76JfKWLYlHAR+j1FcZCE4uG8HNOHvJyki9/G9qHZ9doc w3+mIdcw/VCRHpkDbNyJyPBV0iBAIkpoMwfbDuFPZgJmId3BIzA0/bGe1/XouW9QehRg 3+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=4MxfhQfvsIO0YwdepTatC0Ox/o2/BCFLnON9xZ3PlKt0Ce9/uKUSWoAKBOBjhwTHEF 2A4NIMilsSdfjeSRa0StUMkLYAwwuUNDij/EW6KKCEe8tyLsZUSj0gDsSpoEDtd4yMtA zjhRNqO+XXpKG2o+4dhRdXNAyv7WSAzZ6bBKb3jn9K7v8cf16xnCZc7zxJgZIxJWqHER ruB/9jOUD+kFO8Mn64NAOG4N0T+QzCHFUbto2xqCNDaY67Z5Ugv3M1G8Par+zurb6xNw OO3UUPq8BzXkwEuv2o4+iiCFA/fKDde677tCxKQMICgYrM2BhtfN20PNwANIr/9TEime 5GMg== X-Gm-Message-State: AOAM532S8hWcXAymsROUGlmOriLUjAuAsb93aUKcGsSMBWdzFml+ttyY 3HXs2gWXqNSpXMBEAkcddhIX0w== X-Google-Smtp-Source: ABdhPJzbQgs3ZiPyG3g68c9CE72l8nXqFUBGdfo2PobHZ4oRqfWUj1AoQFmLtN/bznm5cjXVREY+kQ== X-Received: by 2002:a17:902:6a82:b0:148:a2e7:fb5c with SMTP id n2-20020a1709026a8200b00148a2e7fb5cmr25308794plk.157.1640759819836; Tue, 28 Dec 2021 22:36:59 -0800 (PST) Received: from google.com ([2401:fa00:1:10:4dea:2b20:ea89:724b]) by smtp.gmail.com with ESMTPSA id p37sm18097039pfh.97.2021.12.28.22.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 22:36:59 -0800 (PST) Date: Wed, 29 Dec 2021 14:36:54 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , AngeloGioacchino Del Regno , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Message-ID: References: <20211228094146.20505-1-yunfei.dong@mediatek.com> <20211228094146.20505-6-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_223703_340224_D8BB6405 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote: > From: Yunfei Dong Same as 4th patch. Please fix it. > For lat and core architecture, just need to get output buffer for lat > decode. For core hardware need to get lat's message and capture buffer. > In order to let lat and core decode in parallel, need to set capture > buffer buffered. I think the description should be rephrased. I may misunderstand but something like the template: """ OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel. Sets capture buffer buffered to ... """ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > index 5aebf88f997b..23a154c4e321 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx) > src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx, > V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); > > + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE) > + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1); s/1/true/ helps readability. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC96C43219 for ; Wed, 29 Dec 2021 06:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234688AbhL2GhB (ORCPT ); Wed, 29 Dec 2021 01:37:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234634AbhL2GhB (ORCPT ); Wed, 29 Dec 2021 01:37:01 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4503C06173F for ; Tue, 28 Dec 2021 22:37:00 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id i6so9198448pla.0 for ; Tue, 28 Dec 2021 22:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=US3E/hqHlmnyPzOy/HskFnqIw6YITYtB3SecYzBz/TvRFRiaQ5DNALRLAG1KPwoX4J sdBQ2c6Fm0s8nGLH1iLRLu6FUqFDXjmD5E5kgs1rUOuHC+aCdtwY5dqh2Ev41kZOMVMb JT/44yXGfpcDJ/kOLKnYQIqs7HAjYlSLDIVP98i5KxF2HWCRbPPlFuiGAGcRbPQoTNpq pKVNacwTs8+fmivZ1QHilorH76JfKWLYlHAR+j1FcZCE4uG8HNOHvJyki9/G9qHZ9doc w3+mIdcw/VCRHpkDbNyJyPBV0iBAIkpoMwfbDuFPZgJmId3BIzA0/bGe1/XouW9QehRg 3+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=aYUbnL6X4ym1BQ0fvivkqEq+fn0vhKekNt+71FYyzlIf8HizRDN7zgmntXAEL9i14q +4jxZ2MnCClWdMb6MSyQe1wqN6p13GpqW5M8PyY54/Q3NTVFAwcdqjVjlnV6e62Cd/wC xMtMlnlcuFymJIZr/Ea4yLfhv+mHeHM8DTAHXyBhzAaH4g7r0O23U2je5aeGU964O+r4 sbpJN1uHxChlMJTSdbu7SzHoaMEtxlWWJ9XmdyqS7IIWj2Y7lEn50S5sIWT4hrhe1142 IfmG+1kOSmN8FsvGE7TGM4mty8zQ9TJ30eheZsjjCAaHHwduI0ufRJPI7sVMXQLCf6Or y1/w== X-Gm-Message-State: AOAM5304sn+UVEDFlXybWBFpavMsf6NR9Kr/IUmXtEmd7onSc/o3w7uW z72U0naWoLoP7SA0i/Vg4rc06g== X-Google-Smtp-Source: ABdhPJzbQgs3ZiPyG3g68c9CE72l8nXqFUBGdfo2PobHZ4oRqfWUj1AoQFmLtN/bznm5cjXVREY+kQ== X-Received: by 2002:a17:902:6a82:b0:148:a2e7:fb5c with SMTP id n2-20020a1709026a8200b00148a2e7fb5cmr25308794plk.157.1640759819836; Tue, 28 Dec 2021 22:36:59 -0800 (PST) Received: from google.com ([2401:fa00:1:10:4dea:2b20:ea89:724b]) by smtp.gmail.com with ESMTPSA id p37sm18097039pfh.97.2021.12.28.22.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 22:36:59 -0800 (PST) Date: Wed, 29 Dec 2021 14:36:54 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , AngeloGioacchino Del Regno , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Message-ID: References: <20211228094146.20505-1-yunfei.dong@mediatek.com> <20211228094146.20505-6-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote: > From: Yunfei Dong Same as 4th patch. Please fix it. > For lat and core architecture, just need to get output buffer for lat > decode. For core hardware need to get lat's message and capture buffer. > In order to let lat and core decode in parallel, need to set capture > buffer buffered. I think the description should be rephrased. I may misunderstand but something like the template: """ OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel. Sets capture buffer buffered to ... """ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > index 5aebf88f997b..23a154c4e321 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx) > src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx, > V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); > > + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE) > + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1); s/1/true/ helps readability. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8754CC433F5 for ; Wed, 29 Dec 2021 06:37:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2ABE89272; Wed, 29 Dec 2021 06:37:01 +0000 (UTC) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C0C689272 for ; Wed, 29 Dec 2021 06:37:00 +0000 (UTC) Received: by mail-pl1-x62a.google.com with SMTP id u16so15209892plg.9 for ; Tue, 28 Dec 2021 22:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=US3E/hqHlmnyPzOy/HskFnqIw6YITYtB3SecYzBz/TvRFRiaQ5DNALRLAG1KPwoX4J sdBQ2c6Fm0s8nGLH1iLRLu6FUqFDXjmD5E5kgs1rUOuHC+aCdtwY5dqh2Ev41kZOMVMb JT/44yXGfpcDJ/kOLKnYQIqs7HAjYlSLDIVP98i5KxF2HWCRbPPlFuiGAGcRbPQoTNpq pKVNacwTs8+fmivZ1QHilorH76JfKWLYlHAR+j1FcZCE4uG8HNOHvJyki9/G9qHZ9doc w3+mIdcw/VCRHpkDbNyJyPBV0iBAIkpoMwfbDuFPZgJmId3BIzA0/bGe1/XouW9QehRg 3+uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p7zVEyegDmuj+6n30KCO1S5If0BRlYsdYfkjtOazVTk=; b=XHr7mfZtcvDLDNiEPsLA/TTm154ktTjhcBDLGxeuswSh1tksNrWpBKJ5VqBF8Js7Q6 7o7kkRCt+MsTdRSAOup0PJ8jK1UtFFjPEl19UxzFE1q3Vf3Rumk1YGJ+VuMFylUT1hfk DhP8Mh8GpQ7k2MOqOhjSGedXACN1ijN1TGYUZ8Mnpt6xdWtjXun4DNacQRxULNwGhH8a giF9PW5QbvzI/EhRMt2KZcFYkYczS116SsThAh5p00lePj1l7RNCvDRmT+peaSBbIl+v oLQh4d29OBrgLNLs4lrp1M7hZ7iBCvJova8x4yyXXU/sGFEHZdDQSC/n7knH/AuAVTq6 FL+A== X-Gm-Message-State: AOAM5334NRMCPa7uUT/t3FfMp9YV/1u0wb/1kLuV+J8ntQFE2eYFH6b9 I442UvGeAavJ0Fn25oEhW08sgw== X-Google-Smtp-Source: ABdhPJzbQgs3ZiPyG3g68c9CE72l8nXqFUBGdfo2PobHZ4oRqfWUj1AoQFmLtN/bznm5cjXVREY+kQ== X-Received: by 2002:a17:902:6a82:b0:148:a2e7:fb5c with SMTP id n2-20020a1709026a8200b00148a2e7fb5cmr25308794plk.157.1640759819836; Tue, 28 Dec 2021 22:36:59 -0800 (PST) Received: from google.com ([2401:fa00:1:10:4dea:2b20:ea89:724b]) by smtp.gmail.com with ESMTPSA id p37sm18097039pfh.97.2021.12.28.22.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 22:36:59 -0800 (PST) Date: Wed, 29 Dec 2021 14:36:54 +0800 From: Tzung-Bi Shih To: Yunfei Dong Subject: Re: [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Message-ID: References: <20211228094146.20505-1-yunfei.dong@mediatek.com> <20211228094146.20505-6-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211228094146.20505-6-yunfei.dong@mediatek.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Dafna Hirschfeld , dri-devel , Steve Cho , Irui Wang , Mauro Carvalho Chehab , Benjamin Gaignard , Project_Global_Chrome_Upstream_Group@mediatek.com, Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tzung-Bi Shih , Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , Tiffany Lin , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , srv_heupstream@mediatek.com, Alexandre Courbot , linux-kernel@vger.kernel.org, Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 28, 2021 at 05:41:39PM +0800, Yunfei Dong wrote: > From: Yunfei Dong Same as 4th patch. Please fix it. > For lat and core architecture, just need to get output buffer for lat > decode. For core hardware need to get lat's message and capture buffer. > In order to let lat and core decode in parallel, need to set capture > buffer buffered. I think the description should be rephrased. I may misunderstand but something like the template: """ OUTPUT -> lat -> core -> CAPTURE. Lat and core can work in parallel. Sets capture buffer buffered to ... """ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > index 5aebf88f997b..23a154c4e321 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateless.c > @@ -314,6 +314,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx) > src_vq = v4l2_m2m_get_vq(ctx->m2m_ctx, > V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); > > + if (ctx->dev->vdec_pdata->hw_arch != MTK_VDEC_PURE_SINGLE_CORE) > + v4l2_m2m_set_dst_buffered(ctx->m2m_ctx, 1); s/1/true/ helps readability.