From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Luis Chamberlain <mcgrof@kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/build: use the proper name CONFIG_FW_LOADER
Date: Wed, 29 Dec 2021 15:16:28 +0100 [thread overview]
Message-ID: <YcxtvObu4Uofn208@kroah.com> (raw)
In-Reply-To: <20211229111553.5846-1-lukas.bulwahn@gmail.com>
On Wed, Dec 29, 2021 at 12:15:53PM +0100, Lukas Bulwahn wrote:
> Commit c8dcf655ec81 ("x86/build: Tuck away built-in firmware under
> FW_LOADER") intends to add the expression regex only when FW_LOADER is
> built-in, not a module or disabled.
>
> The config is called CONFIG_FW_LOADER when it is built-in; and
> CONFIG_FW_LOADER_MODULE when it is a module.
>
> So, adjust the condition to the actual name of the config.
>
> Fixes: c8dcf655ec81 ("x86/build: Tuck away built-in firmware under FW_LOADER")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>
> I am wondering if this regular expression needs to be made differently
> depending on the build configuration at all.
>
> Could this not just be added unconditionally anyway or is not needed at all?
> It seems that is was broken since its initial inclusion and nobody ever noticed.
Very few people use built-in firmware, which is why no one probably ever
noticed this :(
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-12-29 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 11:15 [PATCH] x86/build: use the proper name CONFIG_FW_LOADER Lukas Bulwahn
2021-12-29 14:16 ` Greg Kroah-Hartman [this message]
2021-12-29 19:36 ` Borislav Petkov
2021-12-30 9:29 ` Greg Kroah-Hartman
2021-12-29 21:29 ` [tip: x86/urgent] x86/build: Use " tip-bot2 for Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcxtvObu4Uofn208@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.