From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72BBC433EF for ; Tue, 11 Jan 2022 09:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349274AbiAKJcy (ORCPT ); Tue, 11 Jan 2022 04:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236995AbiAKJcx (ORCPT ); Tue, 11 Jan 2022 04:32:53 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04922C06173F for ; Tue, 11 Jan 2022 01:32:53 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id v123so10534519wme.2 for ; Tue, 11 Jan 2022 01:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LMy8F7bXkWrfEku+dhz2YISyVBkNNTuMoqdf7ZkD0To=; b=swXL9gRXyWFnGDtv9BadckJ6mLhM/69zfWU8+ocZOa4z77GDZ8hKX0DOB+IIRfXo+x b674NAHat2ChsOGpuPvzN/U3YLXZyFBO4hmbtepec/oXDUnmVHK4Ebt9s41Vl8Wc8MNX nrA2tpPjnjIAnICQLZjtg4UV4b6iTP5OImqH8UEpFlJkZ/vzL00kYYg44u2zjAOtIyKa /6xKppWMPDmcz6K60WT/NXf77pvlHdaEiLHIaoXPVLkGVzaUEBNLI7jJ72q6nsIJ7401 L5zwEFYwKbcsEKnFcjL5eS1n2WQ5bhgV1FcYc+2zPJtOPHAi4QHPVLQeyfJaSVvBs7aN e+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LMy8F7bXkWrfEku+dhz2YISyVBkNNTuMoqdf7ZkD0To=; b=YM6BpQCOy4EkQqLSyXviLuvdrpvSZnwuXhYMJ2CfUYCoS8KaJMe/kVkOCYYJC2WQ0t UbbWhVlZPd1PMUBou5A4+QKXtL0ptUUJQp4mH2ambdh9NpVYibZc+BRsAlkWiah3nzdg ACVZvp6+uQfDtd7XGMD8v/BtYhCLCo7ebvkkTWF7Tpm/OJgrS8EfcmL0AtVM0dZL2xoZ DmJp0vsh4AgBPrtJGhRoxgwNxIV6VHkqRHw1/QM0N9yckwDI0Us1EZ+bmbpluh8PCyLP XHhg9c404t88H2GxDzXek7zyr4KRbB8Ua6L3dJZOTLu/oL06tVaRAK8mKVhIhJfFwOrB 2IGQ== X-Gm-Message-State: AOAM532BT4odnriFa4QRz/RdRO/2Qn5Tdq+0/NzYlRLRjwLkKD18kjEa 1KSVRQkO2dCzAYG1AhkaSCDhxw== X-Google-Smtp-Source: ABdhPJwQ6g3l92q6YTIRewH/TedS5Xf7kkSd9jd60tQw54xnN2pnwEFRMhX7cN9SGsdpzYFiPEF0gA== X-Received: by 2002:a1c:f70d:: with SMTP id v13mr1624941wmh.133.1641893571493; Tue, 11 Jan 2022 01:32:51 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id b14sm8798529wrg.15.2022.01.11.01.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 01:32:51 -0800 (PST) Date: Tue, 11 Jan 2022 09:32:44 +0000 From: Lee Jones To: Zong Li Cc: Michael Turquette , Stephen Boyd , Palmer Dabbelt , Paul Walmsley , linux-clk , linux-riscv Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning Message-ID: References: <20220107090715.2601-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 11 Jan 2022, Zong Li wrote: > On Mon, Jan 10, 2022 at 5:50 PM Lee Jones wrote: > > > > Please improve the subject line. > > > > If this is a straight revert, the subject line should reflect that. > > > > If not, you need to give us specific information regarding the purpose > > of this patch. Please read the Git log for better, more forthcoming > > examples. > > > > It seems to me that this patch is not a straight revert, it provides > another way to fix the original build warnings, just like > '487dc7bb6a0c' tried to do. I guess the commit message has described > what the original warnings is and what the root cause is, it also > mentioned what is changed in this patch. I'm a bit confused whether we > need to add fixes tag, it looks like that it might cause some > misunderstanding? I think it's the patch description and subject that is causing the misunderstanding. Please help me with a couple of points and I'll help you draft something up. Firstly, what alerted you to the problem you're attempting to solve? > > > --- a/drivers/clk/sifive/fu540-prci.c > > > +++ b/drivers/clk/sifive/fu540-prci.c > > > @@ -20,7 +20,6 @@ > > > > > > #include > > > > > > -#include "fu540-prci.h" How is this related to the issue/patch? > > > +struct prci_clk_desc prci_clk_fu540 = { > > > + .clks = __prci_init_clocks_fu540, > > > + .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540), > > > +}; > > > diff --git a/drivers/clk/sifive/fu540-prci.h b/drivers/clk/sifive/fu540-prci.h > > > index c220677dc010..931d6cad8c1c 100644 > > > --- a/drivers/clk/sifive/fu540-prci.h > > > +++ b/drivers/clk/sifive/fu540-prci.h > > > @@ -7,10 +7,6 @@ > > > +extern struct prci_clk_desc prci_clk_fu540; > > > diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c > > > index 80a288c59e56..916d2fc28b9c 100644 > > > --- a/drivers/clk/sifive/sifive-prci.c > > > +++ b/drivers/clk/sifive/sifive-prci.c > > > @@ -12,11 +12,6 @@ > > > #include "fu540-prci.h" > > > #include "fu740-prci.h" > > > > > > -static const struct prci_clk_desc prci_clk_fu540 = { > > > - .clks = __prci_init_clocks_fu540, > > > - .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540), > > > -}; > > > - I'm not sure if it's you or I that is missing the point here, but prci_clk_fu540 is used within *this* file itself: static const struct of_device_id sifive_prci_of_match[] = { {.compatible = "sifive,fu540-c000-prci", .data = &prci_clk_fu540}, {.compatible = "sifive,fu740-c000-prci", .data = &prci_clk_fu740}, {} }; So why are you moving it out to somewhere it is *not* used and making it an extern? This sounds like the opposite to what you'd want? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F68DC433EF for ; Tue, 11 Jan 2022 09:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8MK+VUCvmpXpDkz3fzXk2R7yKzOlgV4J6B3cjUR+VHk=; b=YCquHXUbnWzOyO dSM0CAuF+TJ8TqJ2uA8+lIsQmONH4Hu0rOuBbxVpQ7Fw1mZtnR4xGaEtBFDnV/LocYgQyqmirCTjt QpIHydHPP3ogTjxY4AGwNcGTRVdWWI9C8H+sE2VWi6Qay/s+PC2UWHZ2bwvtHqj80KQicmVPWzIQO FFZnS1LDVau9ALQ1xIRa2/Yn2GV82o/jMIZrHX3C0VkJBqr690gizgQAYdQosoLyBemxn2M0TYd3x yeKuv13lcntm2kXA0AMB9u93IEM12tMrujUXmjzP8kzfPjjSwY+z63ak37zvWTYJo6SsF6lITDNB0 X6nHN6nJncDOInr7DZDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7DWR-00FacA-UP; Tue, 11 Jan 2022 09:32:55 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7DWP-00FaaU-CM for linux-riscv@lists.infradead.org; Tue, 11 Jan 2022 09:32:54 +0000 Received: by mail-wm1-x32b.google.com with SMTP id bg19-20020a05600c3c9300b0034565e837b6so600527wmb.1 for ; Tue, 11 Jan 2022 01:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LMy8F7bXkWrfEku+dhz2YISyVBkNNTuMoqdf7ZkD0To=; b=swXL9gRXyWFnGDtv9BadckJ6mLhM/69zfWU8+ocZOa4z77GDZ8hKX0DOB+IIRfXo+x b674NAHat2ChsOGpuPvzN/U3YLXZyFBO4hmbtepec/oXDUnmVHK4Ebt9s41Vl8Wc8MNX nrA2tpPjnjIAnICQLZjtg4UV4b6iTP5OImqH8UEpFlJkZ/vzL00kYYg44u2zjAOtIyKa /6xKppWMPDmcz6K60WT/NXf77pvlHdaEiLHIaoXPVLkGVzaUEBNLI7jJ72q6nsIJ7401 L5zwEFYwKbcsEKnFcjL5eS1n2WQ5bhgV1FcYc+2zPJtOPHAi4QHPVLQeyfJaSVvBs7aN e+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LMy8F7bXkWrfEku+dhz2YISyVBkNNTuMoqdf7ZkD0To=; b=08Oc4pHgKKhMLOYsCZs39Utl/RQVN4lIEx3aHOmWTywR1iA3DhpTM8sIx8AqegfYrk e/c0GaZdL3OgLDyGkUm5ttp0sTkzwSaqYECAU+JQsd+q3sEs49G34HIFQChePBADBLor jBsaB+vsFilda0zQtPGuK6rVxFAL5+19VWLH2y0DPZGuQSNR9VlqRlyIIP/CxNIDBby7 cAvR+Vnea4zrLmm8NpkG+WZk/3o2Uc9X/ScPlXh/6rKXC/8hurttIhsrNyVvcEFlVv2c ZGF56dh71ZzCGWR5mr4VUF+yiXeNVRvIKz+Xoiv5JXKwDviiQPGlit43feT2bvobgtUb 1JJg== X-Gm-Message-State: AOAM532OOj+iMcXe0Z5fXOWMqv3vGU77shkmz0V6B4IX+y8sUD69JaW9 nXwSC9Gd50Mkv3CMfxPlA1f0wQ== X-Google-Smtp-Source: ABdhPJwQ6g3l92q6YTIRewH/TedS5Xf7kkSd9jd60tQw54xnN2pnwEFRMhX7cN9SGsdpzYFiPEF0gA== X-Received: by 2002:a1c:f70d:: with SMTP id v13mr1624941wmh.133.1641893571493; Tue, 11 Jan 2022 01:32:51 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id b14sm8798529wrg.15.2022.01.11.01.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 01:32:51 -0800 (PST) Date: Tue, 11 Jan 2022 09:32:44 +0000 From: Lee Jones To: Zong Li Cc: Michael Turquette , Stephen Boyd , Palmer Dabbelt , Paul Walmsley , linux-clk , linux-riscv Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning Message-ID: References: <20220107090715.2601-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_013253_479028_9F9183D5 X-CRM114-Status: GOOD ( 26.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMSBKYW4gMjAyMiwgWm9uZyBMaSB3cm90ZToKCj4gT24gTW9uLCBKYW4gMTAsIDIw MjIgYXQgNTo1MCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ Cj4gPiBQbGVhc2UgaW1wcm92ZSB0aGUgc3ViamVjdCBsaW5lLgo+ID4KPiA+IElmIHRoaXMgaXMg YSBzdHJhaWdodCByZXZlcnQsIHRoZSBzdWJqZWN0IGxpbmUgc2hvdWxkIHJlZmxlY3QgdGhhdC4K PiA+Cj4gPiBJZiBub3QsIHlvdSBuZWVkIHRvIGdpdmUgdXMgc3BlY2lmaWMgaW5mb3JtYXRpb24g cmVnYXJkaW5nIHRoZSBwdXJwb3NlCj4gPiBvZiB0aGlzIHBhdGNoLiAgUGxlYXNlIHJlYWQgdGhl IEdpdCBsb2cgZm9yIGJldHRlciwgbW9yZSBmb3J0aGNvbWluZwo+ID4gZXhhbXBsZXMuCj4gPgo+ IAo+IEl0IHNlZW1zIHRvIG1lIHRoYXQgdGhpcyBwYXRjaCBpcyBub3QgYSBzdHJhaWdodCByZXZl cnQsIGl0IHByb3ZpZGVzCj4gYW5vdGhlciB3YXkgdG8gZml4IHRoZSBvcmlnaW5hbCBidWlsZCB3 YXJuaW5ncywganVzdCBsaWtlCj4gJzQ4N2RjN2JiNmEwYycgdHJpZWQgdG8gZG8uIEkgZ3Vlc3Mg dGhlIGNvbW1pdCBtZXNzYWdlIGhhcyBkZXNjcmliZWQKPiB3aGF0IHRoZSBvcmlnaW5hbCB3YXJu aW5ncyBpcyBhbmQgd2hhdCB0aGUgcm9vdCBjYXVzZSBpcywgaXQgYWxzbwo+IG1lbnRpb25lZCB3 aGF0IGlzIGNoYW5nZWQgaW4gdGhpcyBwYXRjaC4gSSdtIGEgYml0IGNvbmZ1c2VkIHdoZXRoZXIg d2UKPiBuZWVkIHRvIGFkZCBmaXhlcyB0YWcsIGl0IGxvb2tzIGxpa2UgdGhhdCBpdCBtaWdodCBj YXVzZSBzb21lCj4gbWlzdW5kZXJzdGFuZGluZz8KCkkgdGhpbmsgaXQncyB0aGUgcGF0Y2ggZGVz Y3JpcHRpb24gYW5kIHN1YmplY3QgdGhhdCBpcyBjYXVzaW5nIHRoZQptaXN1bmRlcnN0YW5kaW5n LgoKUGxlYXNlIGhlbHAgbWUgd2l0aCBhIGNvdXBsZSBvZiBwb2ludHMgYW5kIEknbGwgaGVscCB5 b3UgZHJhZnQKc29tZXRoaW5nIHVwLgoKRmlyc3RseSwgd2hhdCBhbGVydGVkIHlvdSB0byB0aGUg cHJvYmxlbSB5b3UncmUgYXR0ZW1wdGluZyB0byBzb2x2ZT8KCj4gPiA+IC0tLSBhL2RyaXZlcnMv Y2xrL3NpZml2ZS9mdTU0MC1wcmNpLmMKPiA+ID4gKysrIGIvZHJpdmVycy9jbGsvc2lmaXZlL2Z1 NTQwLXByY2kuYwo+ID4gPiBAQCAtMjAsNyArMjAsNiBAQAo+ID4gPgo+ID4gPiAgI2luY2x1ZGUg PGR0LWJpbmRpbmdzL2Nsb2NrL3NpZml2ZS1mdTU0MC1wcmNpLmg+Cj4gPiA+Cj4gPiA+IC0jaW5j bHVkZSAiZnU1NDAtcHJjaS5oIgoKSG93IGlzIHRoaXMgcmVsYXRlZCB0byB0aGUgaXNzdWUvcGF0 Y2g/Cgo+ID4gPiArc3RydWN0IHByY2lfY2xrX2Rlc2MgcHJjaV9jbGtfZnU1NDAgPSB7Cj4gPiA+ ICsgICAgIC5jbGtzID0gX19wcmNpX2luaXRfY2xvY2tzX2Z1NTQwLAo+ID4gPiArICAgICAubnVt X2Nsa3MgPSBBUlJBWV9TSVpFKF9fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCksCj4gPiA+ICt9OwoK PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL3NpZml2ZS9mdTU0MC1wcmNpLmggYi9kcml2 ZXJzL2Nsay9zaWZpdmUvZnU1NDAtcHJjaS5oCj4gPiA+IGluZGV4IGMyMjA2NzdkYzAxMC4uOTMx ZDZjYWQ4YzFjIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2Nsay9zaWZpdmUvZnU1NDAtcHJj aS5oCj4gPiA+ICsrKyBiL2RyaXZlcnMvY2xrL3NpZml2ZS9mdTU0MC1wcmNpLmgKPiA+ID4gQEAg LTcsMTAgKzcsNiBAQAo+ID4gPiArZXh0ZXJuIHN0cnVjdCBwcmNpX2Nsa19kZXNjIHByY2lfY2xr X2Z1NTQwOwoKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL3NpZml2ZS9zaWZpdmUtcHJj aS5jIGIvZHJpdmVycy9jbGsvc2lmaXZlL3NpZml2ZS1wcmNpLmMKPiA+ID4gaW5kZXggODBhMjg4 YzU5ZTU2Li45MTZkMmZjMjhiOWMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvY2xrL3NpZml2 ZS9zaWZpdmUtcHJjaS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvY2xrL3NpZml2ZS9zaWZpdmUtcHJj aS5jCj4gPiA+IEBAIC0xMiwxMSArMTIsNiBAQAo+ID4gPiAgI2luY2x1ZGUgImZ1NTQwLXByY2ku aCIKPiA+ID4gICNpbmNsdWRlICJmdTc0MC1wcmNpLmgiCj4gPiA+Cj4gPiA+IC1zdGF0aWMgY29u c3Qgc3RydWN0IHByY2lfY2xrX2Rlc2MgcHJjaV9jbGtfZnU1NDAgPSB7Cj4gPiA+IC0gICAgIC5j bGtzID0gX19wcmNpX2luaXRfY2xvY2tzX2Z1NTQwLAo+ID4gPiAtICAgICAubnVtX2Nsa3MgPSBB UlJBWV9TSVpFKF9fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCksCj4gPiA+IC19Owo+ID4gPiAtCgpJ J20gbm90IHN1cmUgaWYgaXQncyB5b3Ugb3IgSSB0aGF0IGlzIG1pc3NpbmcgdGhlIHBvaW50IGhl cmUsIGJ1dApwcmNpX2Nsa19mdTU0MCBpcyB1c2VkIHdpdGhpbiAqdGhpcyogZmlsZSBpdHNlbGY6 Cgogc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgc2lmaXZlX3ByY2lfb2ZfbWF0Y2hb XSA9IHsKICAgICAgICAgey5jb21wYXRpYmxlID0gInNpZml2ZSxmdTU0MC1jMDAwLXByY2kiLCAu ZGF0YSA9ICZwcmNpX2Nsa19mdTU0MH0sCiAgICAgICAgIHsuY29tcGF0aWJsZSA9ICJzaWZpdmUs ZnU3NDAtYzAwMC1wcmNpIiwgLmRhdGEgPSAmcHJjaV9jbGtfZnU3NDB9LAogICAgICAgICB7fQog fTsKClNvIHdoeSBhcmUgeW91IG1vdmluZyBpdCBvdXQgdG8gc29tZXdoZXJlIGl0IGlzICpub3Qq IHVzZWQgYW5kIG1ha2luZwppdCBhbiBleHRlcm4/ICBUaGlzIHNvdW5kcyBsaWtlIHRoZSBvcHBv c2l0ZSB0byB3aGF0IHlvdSdkIHdhbnQ/CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClByaW5j aXBhbCBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBP cGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sg fCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yaXNjdgo=