From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Nick Desaulniers <ndesaulniers@google.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v1 1/1] vsprintf: Fix potential unaligned access
Date: Tue, 11 Jan 2022 17:09:08 +0200 [thread overview]
Message-ID: <Yd2dlEMp0a8TAi9i@smile.fi.intel.com> (raw)
In-Reply-To: <Yd2a4MApVR8hexny@alley>
On Tue, Jan 11, 2022 at 03:57:36PM +0100, Petr Mladek wrote:
> On Mon 2022-01-10 22:50:49, Andy Shevchenko wrote:
> > The %p4cc specifier in some cases might get an unaligned pointer.
> > Due to this we need to make copy to local variable once to avoid
> > potential crashes on some architectures due to improper access.
> >
> > Fixes: af612e43de6d ("lib/vsprintf: Add support for printing V4L2 and DRM fourccs")
> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Looks good to me:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> I have already sent pull request for 5.17. Could this wait
> for 5.18 or would you prefer to get it into 5.17, please?
It's not so critical.
But would be nice to have.
> My understanding of Sakari's reply is that the current callers
> provide aligned pointers. In that case it would not be urgent.
> But I might have gotten it wrong.
Not really. There are potential unaligned callers, but Sakari
has another patch that fixes that on the (one of *) caller side.
*) I dunno how many other callers (probably none) in tree and
how many potentially can be with similar issue.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-01-11 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 20:50 [PATCH v1 1/1] vsprintf: Fix potential unaligned access Andy Shevchenko
2022-01-10 22:12 ` Sakari Ailus
2022-01-11 10:10 ` Andy Shevchenko
2022-01-11 10:54 ` Sakari Ailus
2022-01-11 11:22 ` Andy Shevchenko
2022-01-11 14:13 ` Sakari Ailus
2022-01-11 14:18 ` Andy Shevchenko
2022-01-11 14:57 ` Petr Mladek
2022-01-11 15:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd2dlEMp0a8TAi9i@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ndesaulniers@google.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.