From: Kevin Wolf <kwolf@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Thomas Huth <thuth@redhat.com>, Peter Krempa <pkrempa@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH 0/1] Fix -device JSON support wrt hotplug
Date: Tue, 11 Jan 2022 16:21:19 +0100 [thread overview]
Message-ID: <Yd2gb5GgKwIGBq1o@redhat.com> (raw)
In-Reply-To: <20220105123847.4047954-1-berrange@redhat.com>
Am 05.01.2022 um 13:38 hat Daniel P. Berrangé geschrieben:
> Libvirt switched to using -device JSON support, but we discovered in
> testing that it is broken for hotplug, never sending DEVICE_DELETED
> events. This is caused by a subtle refcount leak.
Oops, so I fell again in the trap of this interface returning a strong
reference... Maybe it's just me, but I find it highly unintuitive.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2022-01-11 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 12:38 [PATCH 0/1] Fix -device JSON support wrt hotplug Daniel P. Berrangé
2022-01-05 12:38 ` [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax Daniel P. Berrangé
2022-01-05 12:49 ` Thomas Huth
2022-01-05 14:37 ` Ján Tomko
2022-01-05 14:49 ` Laurent Vivier
2022-01-05 14:55 ` Daniel P. Berrangé
2022-01-05 15:00 ` Laurent Vivier
2022-01-05 15:18 ` Daniel P. Berrangé
2022-01-05 15:19 ` Thomas Huth
2022-01-05 15:31 ` Laurent Vivier
2022-01-14 12:22 ` Markus Armbruster
2022-01-11 15:21 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd2gb5GgKwIGBq1o@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.