From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42AFC433F5 for ; Tue, 11 Jan 2022 15:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245121AbiAKPeS (ORCPT ); Tue, 11 Jan 2022 10:34:18 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:52628 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240480AbiAKPeR (ORCPT ); Tue, 11 Jan 2022 10:34:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A6777B81B61 for ; Tue, 11 Jan 2022 15:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5CF8C36AEB; Tue, 11 Jan 2022 15:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641915255; bh=8YEEKJFVfxZ84YjTI2jSz/Yz8gvZv4P4YbrKwT1xBCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HamDLsSnjEyYn2X6ZyvPEc24qknTsSUlsZ+RR4R6lGLEeaTaUMYbFO67q44JSY1Eg IKtppDOuUyLwTriE8xqc9Ol5G3dfDJkLNJbAziR4s7Qb5lfF4Y4SDYjHoAkaX3yVGo GTGP6iGTMCPL95jfuAvPfxAMOy54IAp5RBkBDnhEqyU8ZVhXY9JrJk6+qs8heSFkea cvCq2vA/uttlNhi/XMAOp6lKCgOSGoPGVHgwUyrV2yKfrVfSITbJoyv535+Zit9uJn 0uTrL/mZ43wgFLauzTCC0fwGQ+gm5IXCDapst8zkDvmDwLDDT0dPZnVTviwWa4FpuP 3rONA+Qo/+9Lw== Date: Tue, 11 Jan 2022 08:34:09 -0700 From: Nathan Chancellor To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Lakshmi Sowjanya D , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 4/4] pinctrl: add one more "const" for generic function groups Message-ID: References: <20211216162206.8027-1-zajec5@gmail.com> <20211216162206.8027-4-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211216162206.8027-4-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Rafał, On Thu, Dec 16, 2021 at 05:22:06PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Generic code doesn't modify those strings and .get_function_groups > callback has that extra "const" as well. This allows more flexibility in > GENERIC_PINMUX_FUNCTIONS users. > > Signed-off-by: Rafał Miłecki > --- > drivers/pinctrl/pinmux.c | 2 +- > drivers/pinctrl/pinmux.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c > index 6cdbd9ccf2f0..f94d43b082d9 100644 > --- a/drivers/pinctrl/pinmux.c > +++ b/drivers/pinctrl/pinmux.c > @@ -875,7 +875,7 @@ EXPORT_SYMBOL_GPL(pinmux_generic_get_function); > */ > int pinmux_generic_add_function(struct pinctrl_dev *pctldev, > const char *name, > - const char **groups, > + const char * const *groups, > const unsigned int num_groups, > void *data) > { > diff --git a/drivers/pinctrl/pinmux.h b/drivers/pinctrl/pinmux.h > index 78c3a31be882..72fcf03eaa43 100644 > --- a/drivers/pinctrl/pinmux.h > +++ b/drivers/pinctrl/pinmux.h > @@ -129,7 +129,7 @@ static inline void pinmux_init_device_debugfs(struct dentry *devroot, > */ > struct function_desc { > const char *name; > - const char **group_names; > + const char * const *group_names; > int num_group_names; > void *data; > }; > @@ -150,7 +150,7 @@ struct function_desc *pinmux_generic_get_function(struct pinctrl_dev *pctldev, > > int pinmux_generic_add_function(struct pinctrl_dev *pctldev, > const char *name, > - const char **groups, > + const char * const *groups, > unsigned const num_groups, > void *data); > > -- > 2.31.1 > > I have not seen this reported yet, even though it has been broken for a couple of weeks now. I see the following error in -next: $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- allmodconfig drivers/pinctrl/pinctrl-thunderbay.o drivers/pinctrl/pinctrl-thunderbay.c: In function ‘thunderbay_add_functions’: drivers/pinctrl/pinctrl-thunderbay.c:815:29: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 815 | grp = func->group_names; | ^ cc1: all warnings being treated as errors Looks like something like the third patch of the series is needed for the Thunderbay driver, which it appears was in development at the same time as this series. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C63FC433F5 for ; Tue, 11 Jan 2022 15:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j5Xxy5iNCz/ViNmKlM//z0d+hMUsqOvHgC8UUgdGA8s=; b=YTV0IMnEeHU67s 55rrr3twe/y+VkNQZnXz0MdsuYLdK0HiruAB39gcn276x7rRs0jVsNoxfDgqLIeiw75qX67vfTLZC DVHMtCifqwKo5ixvRfjMCpFnqpomYiAfm/xZA8G43PrE2F0zZlYhVaioUBJfDTEAc8hrZkh2absc0 Qnxwbcto3YLceLlVyXBdtnqTOv2E2TK1AaZ6doImc8ZJu6tT9kFA+jezLZ3aH0A4rlhB7GIYZPHRY HooXHckC55LZxYEchVU0zJ819yQhn8foKOzcHkRQ4ecua7r8toVDtFNKclv5j0FcuwQa41edmaoyJ PREskWQQidz+D8aYMPPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7JAD-00GkK0-5S; Tue, 11 Jan 2022 15:34:21 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7JA8-00GkJH-IU for linux-arm-kernel@lists.infradead.org; Tue, 11 Jan 2022 15:34:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E86E46163C; Tue, 11 Jan 2022 15:34:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5CF8C36AEB; Tue, 11 Jan 2022 15:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641915255; bh=8YEEKJFVfxZ84YjTI2jSz/Yz8gvZv4P4YbrKwT1xBCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HamDLsSnjEyYn2X6ZyvPEc24qknTsSUlsZ+RR4R6lGLEeaTaUMYbFO67q44JSY1Eg IKtppDOuUyLwTriE8xqc9Ol5G3dfDJkLNJbAziR4s7Qb5lfF4Y4SDYjHoAkaX3yVGo GTGP6iGTMCPL95jfuAvPfxAMOy54IAp5RBkBDnhEqyU8ZVhXY9JrJk6+qs8heSFkea cvCq2vA/uttlNhi/XMAOp6lKCgOSGoPGVHgwUyrV2yKfrVfSITbJoyv535+Zit9uJn 0uTrL/mZ43wgFLauzTCC0fwGQ+gm5IXCDapst8zkDvmDwLDDT0dPZnVTviwWa4FpuP 3rONA+Qo/+9Lw== Date: Tue, 11 Jan 2022 08:34:09 -0700 From: Nathan Chancellor To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Lakshmi Sowjanya D , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 4/4] pinctrl: add one more "const" for generic function groups Message-ID: References: <20211216162206.8027-1-zajec5@gmail.com> <20211216162206.8027-4-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211216162206.8027-4-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_073416_713790_F2918F37 X-CRM114-Status: GOOD ( 25.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUmFmYcWCLAoKT24gVGh1LCBEZWMgMTYsIDIwMjEgYXQgMDU6MjI6MDZQTSArMDEwMCwgUmFm YcWCIE1pxYJlY2tpIHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNr aS5wbD4KPiAKPiBHZW5lcmljIGNvZGUgZG9lc24ndCBtb2RpZnkgdGhvc2Ugc3RyaW5ncyBhbmQg LmdldF9mdW5jdGlvbl9ncm91cHMKPiBjYWxsYmFjayBoYXMgdGhhdCBleHRyYSAiY29uc3QiIGFz IHdlbGwuIFRoaXMgYWxsb3dzIG1vcmUgZmxleGliaWxpdHkgaW4KPiBHRU5FUklDX1BJTk1VWF9G VU5DVElPTlMgdXNlcnMuCj4gCj4gU2lnbmVkLW9mZi1ieTogUmFmYcWCIE1pxYJlY2tpIDxyYWZh bEBtaWxlY2tpLnBsPgo+IC0tLQo+ICBkcml2ZXJzL3BpbmN0cmwvcGlubXV4LmMgfCAyICstCj4g IGRyaXZlcnMvcGluY3RybC9waW5tdXguaCB8IDQgKystLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9w aW5jdHJsL3Bpbm11eC5jIGIvZHJpdmVycy9waW5jdHJsL3Bpbm11eC5jCj4gaW5kZXggNmNkYmQ5 Y2NmMmYwLi5mOTRkNDNiMDgyZDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waW5jdHJsL3Bpbm11 eC5jCj4gKysrIGIvZHJpdmVycy9waW5jdHJsL3Bpbm11eC5jCj4gQEAgLTg3NSw3ICs4NzUsNyBA QCBFWFBPUlRfU1lNQk9MX0dQTChwaW5tdXhfZ2VuZXJpY19nZXRfZnVuY3Rpb24pOwo+ICAgKi8K PiAgaW50IHBpbm11eF9nZW5lcmljX2FkZF9mdW5jdGlvbihzdHJ1Y3QgcGluY3RybF9kZXYgKnBj dGxkZXYsCj4gIAkJCQljb25zdCBjaGFyICpuYW1lLAo+IC0JCQkJY29uc3QgY2hhciAqKmdyb3Vw cywKPiArCQkJCWNvbnN0IGNoYXIgKiBjb25zdCAqZ3JvdXBzLAo+ICAJCQkJY29uc3QgdW5zaWdu ZWQgaW50IG51bV9ncm91cHMsCj4gIAkJCQl2b2lkICpkYXRhKQo+ICB7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGluY3RybC9waW5tdXguaCBiL2RyaXZlcnMvcGluY3RybC9waW5tdXguaAo+IGlu ZGV4IDc4YzNhMzFiZTg4Mi4uNzJmY2YwM2VhYTQzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGlu Y3RybC9waW5tdXguaAo+ICsrKyBiL2RyaXZlcnMvcGluY3RybC9waW5tdXguaAo+IEBAIC0xMjks NyArMTI5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIHBpbm11eF9pbml0X2RldmljZV9kZWJ1Z2Zz KHN0cnVjdCBkZW50cnkgKmRldnJvb3QsCj4gICAqLwo+ICBzdHJ1Y3QgZnVuY3Rpb25fZGVzYyB7 Cj4gIAljb25zdCBjaGFyICpuYW1lOwo+IC0JY29uc3QgY2hhciAqKmdyb3VwX25hbWVzOwo+ICsJ Y29uc3QgY2hhciAqIGNvbnN0ICpncm91cF9uYW1lczsKPiAgCWludCBudW1fZ3JvdXBfbmFtZXM7 Cj4gIAl2b2lkICpkYXRhOwo+ICB9Owo+IEBAIC0xNTAsNyArMTUwLDcgQEAgc3RydWN0IGZ1bmN0 aW9uX2Rlc2MgKnBpbm11eF9nZW5lcmljX2dldF9mdW5jdGlvbihzdHJ1Y3QgcGluY3RybF9kZXYg KnBjdGxkZXYsCj4gIAo+ICBpbnQgcGlubXV4X2dlbmVyaWNfYWRkX2Z1bmN0aW9uKHN0cnVjdCBw aW5jdHJsX2RldiAqcGN0bGRldiwKPiAgCQkJCWNvbnN0IGNoYXIgKm5hbWUsCj4gLQkJCQljb25z dCBjaGFyICoqZ3JvdXBzLAo+ICsJCQkJY29uc3QgY2hhciAqIGNvbnN0ICpncm91cHMsCj4gIAkJ CQl1bnNpZ25lZCBjb25zdCBudW1fZ3JvdXBzLAo+ICAJCQkJdm9pZCAqZGF0YSk7Cj4gIAo+IC0t IAo+IDIuMzEuMQo+IAo+IAoKSSBoYXZlIG5vdCBzZWVuIHRoaXMgcmVwb3J0ZWQgeWV0LCBldmVu IHRob3VnaCBpdCBoYXMgYmVlbiBicm9rZW4gZm9yIGEKY291cGxlIG9mIHdlZWtzIG5vdy4gSSBz ZWUgdGhlIGZvbGxvd2luZyBlcnJvciBpbiAtbmV4dDoKCiQgbWFrZSAtc2tqIiQobnByb2MpIiBB UkNIPWFybTY0IENST1NTX0NPTVBJTEU9YWFyY2g2NC1saW51eC1nbnUtIGFsbG1vZGNvbmZpZyBk cml2ZXJzL3BpbmN0cmwvcGluY3RybC10aHVuZGVyYmF5Lm8KZHJpdmVycy9waW5jdHJsL3BpbmN0 cmwtdGh1bmRlcmJheS5jOiBJbiBmdW5jdGlvbiDigJh0aHVuZGVyYmF5X2FkZF9mdW5jdGlvbnPi gJk6CmRyaXZlcnMvcGluY3RybC9waW5jdHJsLXRodW5kZXJiYXkuYzo4MTU6Mjk6IGVycm9yOiBh c3NpZ25tZW50IGRpc2NhcmRzIOKAmGNvbnN04oCZIHF1YWxpZmllciBmcm9tIHBvaW50ZXIgdGFy Z2V0IHR5cGUgWy1XZXJyb3I9ZGlzY2FyZGVkLXF1YWxpZmllcnNdCiAgODE1IHwgICAgICAgICAg ICAgICAgICAgICAgICAgZ3JwID0gZnVuYy0+Z3JvdXBfbmFtZXM7CiAgICAgIHwgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIF4KY2MxOiBhbGwgd2FybmluZ3MgYmVpbmcgdHJlYXRlZCBhcyBl cnJvcnMKCkxvb2tzIGxpa2Ugc29tZXRoaW5nIGxpa2UgdGhlIHRoaXJkIHBhdGNoIG9mIHRoZSBz ZXJpZXMgaXMgbmVlZGVkIGZvcgp0aGUgVGh1bmRlcmJheSBkcml2ZXIsIHdoaWNoIGl0IGFwcGVh cnMgd2FzIGluIGRldmVsb3BtZW50IGF0IHRoZSBzYW1lCnRpbWUgYXMgdGhpcyBzZXJpZXMuCgpD aGVlcnMsCk5hdGhhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=