From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3D9C433F5 for ; Wed, 12 Jan 2022 02:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348115AbiALCBU (ORCPT ); Tue, 11 Jan 2022 21:01:20 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:37886 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348035AbiALCBT (ORCPT ); Tue, 11 Jan 2022 21:01:19 -0500 Received: by mail-ot1-f43.google.com with SMTP id h20-20020a9d6f94000000b0059100e01744so936537otq.4; Tue, 11 Jan 2022 18:01:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qk2OQ/ws2ks++rPbFgmN3BZmamKFSn87De142ZHrSBo=; b=mm3IOCg7BE1RUDaNWUP5MzmaanQJ93Tk9NqNoF79W0OkrmDAbRazDW8ksYz+0gaN4/ jZnN3Tx4Jvl2bbuuzkxb0dlNwRJcj12Xj989obAT5Hi37NrhH2URi9b9dBq3SNPHNppn TwsKlSPqlpgYj6k2vELHHp17qVDrUWW1+KxTtAsA3d4My7lm/28UBovoxyAR03t2IDdC j3DkH9w2mNRBfZ/N7WVp1AHvqoWE7lCotZEkecBfUlStnAT1l6YA7gQOVpO9QY0hTfBi leLilUA98KZiaqBNqZw1wKxw+htkbQQs6FFvXO07GRMSP7WPK6UiJxnltUUjE41nA94G KVWQ== X-Gm-Message-State: AOAM531WJ4E9rX3uIb5rCud2gg9m0odCXy1J+otAb/fdvOeHDahk9tqE xxLMv/mURWcuiivhY2HP5A== X-Google-Smtp-Source: ABdhPJzqarYaUXTAPE1/+tVVkQSjhrV2udoe9wYR0feu1OlMihqzlS2aPOfLf1LHnoecfVXpdiso7Q== X-Received: by 2002:a05:6830:2705:: with SMTP id j5mr5399966otu.204.1641952879291; Tue, 11 Jan 2022 18:01:19 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id u14sm2369656ote.62.2022.01.11.18.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 18:01:18 -0800 (PST) Received: (nullmailer pid 3915021 invoked by uid 1000); Wed, 12 Jan 2022 02:01:17 -0000 Date: Tue, 11 Jan 2022 20:01:17 -0600 From: Rob Herring To: Brian Norris Cc: Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Lin Huang , MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org, Rob Herring , Derek Basehore , devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 03/10] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220107235320.965497-1-briannorris@chromium.org> <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 07 Jan 2022 15:53:13 -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17499C433F5 for ; Wed, 12 Jan 2022 02:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oSpWwnR2yFuYpNEVvAAJ1hrUBWoLfY8aMuodhixgcvk=; b=ttVQoWNe5YaDdB T0AgV9pRElEaGym/Gh2d0odTULmWtTCVPXTOA5tRxEp4/SCK4UyINFNZSg4+BDAF3XSJDVHv19DKN FvV4mHroBwbp/UKBigPihXcOnVSxUTZU4yu9j2ARn6VDzBkSGQJnzR2ssYr66ivKFTLrISQ6RCz0U rjB9kG/+Lt+qlFC3RQL93H0Uy8kSyw7pmCgcCzABAKFTsbXM1poPixYYiLtNVe4QYAHNE//L2Svqw OsfWGJtelZJQnioyBEJjxSi1hNtv5BQJIQIZUmqUxB3p9i1pzEFGIEvrZuIgQhnGj5ZPLbeIgLwyo uKElNjcoDghKleBMIC5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7SxA-000lX1-In; Wed, 12 Jan 2022 02:01:32 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7Swx-000lTV-U7; Wed, 12 Jan 2022 02:01:21 +0000 Received: by mail-ot1-f52.google.com with SMTP id o3-20020a9d4043000000b0058f31f4312fso960684oti.1; Tue, 11 Jan 2022 18:01:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qk2OQ/ws2ks++rPbFgmN3BZmamKFSn87De142ZHrSBo=; b=15x52a79QboaTjPcSYKytQgzj/Mi08KxekhdzgLfjkW1gjRjnC4MLgtpLCQZBiVLS5 xzt3PyAyq356jWyCNpsZtSOhdeo7UV4eRynmdZYq8pTrx+ZEa4TpoL7GWr4tvbcy5Ioo g6b3qKccd7u1ebz6tGS1EK1jzsvLhS3gbMl7CHIAcmpWWfCjvyZBdt5nAclBr637gxiV 3hxRNoiKV62XQJWmL1NIUCtEV8Bna52LPg7PHt9E80Rj3KYXYTs9Gj6uSrFp4P2cZ3s3 UdblsWHKbNUHeQvygS/q5/G39XYs4PHd1r9WqgJ32QhlIJwHwDQZWQXsRbmaMQqeNWS0 FcGw== X-Gm-Message-State: AOAM533MZ80TXg0zFBXIeMi44rZfSbP6VmtZqq4VHc3bI0bIsHnahJQV +52zV5YXhnwZOVwCKntoBA== X-Google-Smtp-Source: ABdhPJzqarYaUXTAPE1/+tVVkQSjhrV2udoe9wYR0feu1OlMihqzlS2aPOfLf1LHnoecfVXpdiso7Q== X-Received: by 2002:a05:6830:2705:: with SMTP id j5mr5399966otu.204.1641952879291; Tue, 11 Jan 2022 18:01:19 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id u14sm2369656ote.62.2022.01.11.18.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 18:01:18 -0800 (PST) Received: (nullmailer pid 3915021 invoked by uid 1000); Wed, 12 Jan 2022 02:01:17 -0000 Date: Tue, 11 Jan 2022 20:01:17 -0600 From: Rob Herring To: Brian Norris Cc: Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Lin Huang , MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org, Rob Herring , Derek Basehore , devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 03/10] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220107235320.965497-1-briannorris@chromium.org> <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_180120_005456_E12952DE X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, 07 Jan 2022 15:53:13 -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02EEEC433F5 for ; Wed, 12 Jan 2022 02:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=on98k71Phxf+DoaNkPhN//kgSHtfp83/w42+zFn1/5s=; b=3LmIdLoqPlbTpI R5+LUkRDgCGpThvw3VDuJ0EN5hDHcV+s7OqFadMLDNZLOOr9CEkOJs4dhRqyCcYG5PrCIOo1xcANX Zp+t5Q/d6iQGxrWrnUnk/lC6sP9+ES8dFjg1sExbqUscIiauZ1IJX/9IPXpuFekUimfVlUgMHWaRg R/lgmPbjAVxkeitTw3OwOGEzLa9LEMiCotraY0zF+Nfw4Np6Vv2qWwcV9AwOpeBqrKnlLmgEwqGhE 8VcoPhnWD+kCjmBVvCiH7g0iFNB4x9w9bZB2sp0rzfQTZG5xeQcKdEm38PWK2CihODnBUp0smMX5l 671F7ostQfDgr0nJM72A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7Sx1-000lUl-84; Wed, 12 Jan 2022 02:01:23 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7Swx-000lTV-U7; Wed, 12 Jan 2022 02:01:21 +0000 Received: by mail-ot1-f52.google.com with SMTP id o3-20020a9d4043000000b0058f31f4312fso960684oti.1; Tue, 11 Jan 2022 18:01:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qk2OQ/ws2ks++rPbFgmN3BZmamKFSn87De142ZHrSBo=; b=15x52a79QboaTjPcSYKytQgzj/Mi08KxekhdzgLfjkW1gjRjnC4MLgtpLCQZBiVLS5 xzt3PyAyq356jWyCNpsZtSOhdeo7UV4eRynmdZYq8pTrx+ZEa4TpoL7GWr4tvbcy5Ioo g6b3qKccd7u1ebz6tGS1EK1jzsvLhS3gbMl7CHIAcmpWWfCjvyZBdt5nAclBr637gxiV 3hxRNoiKV62XQJWmL1NIUCtEV8Bna52LPg7PHt9E80Rj3KYXYTs9Gj6uSrFp4P2cZ3s3 UdblsWHKbNUHeQvygS/q5/G39XYs4PHd1r9WqgJ32QhlIJwHwDQZWQXsRbmaMQqeNWS0 FcGw== X-Gm-Message-State: AOAM533MZ80TXg0zFBXIeMi44rZfSbP6VmtZqq4VHc3bI0bIsHnahJQV +52zV5YXhnwZOVwCKntoBA== X-Google-Smtp-Source: ABdhPJzqarYaUXTAPE1/+tVVkQSjhrV2udoe9wYR0feu1OlMihqzlS2aPOfLf1LHnoecfVXpdiso7Q== X-Received: by 2002:a05:6830:2705:: with SMTP id j5mr5399966otu.204.1641952879291; Tue, 11 Jan 2022 18:01:19 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id u14sm2369656ote.62.2022.01.11.18.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 18:01:18 -0800 (PST) Received: (nullmailer pid 3915021 invoked by uid 1000); Wed, 12 Jan 2022 02:01:17 -0000 Date: Tue, 11 Jan 2022 20:01:17 -0600 From: Rob Herring To: Brian Norris Cc: Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Lin Huang , MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org, Rob Herring , Derek Basehore , devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 03/10] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Message-ID: References: <20220107235320.965497-1-briannorris@chromium.org> <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220107155215.3.I9341269171c114d0e04e41d48037fd32816e2d8c@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220111_180120_005456_E12952DE X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 07 Jan 2022 15:53:13 -0800, Brian Norris wrote: > The driver and all downstream device trees [1] are using Hz units, but > the document claims MHz. DRAM frequency for these systems can't possibly > exceed 2^32-1 Hz, so the choice of unit doesn't really matter than much. > > Rather than add unnecessary risk in getting the units wrong, let's just > go with the unofficial convention and make the docs match reality. > > A sub-1MHz frequency is extremely unlikely, so include a minimum in the > schema, to help catch anybody who might have believed this was MHz. > > [1] And notably, also those trying to upstream them: > https://lore.kernel.org/lkml/20210308233858.24741-3-daniel.lezcano@linaro.org/ > > Signed-off-by: Brian Norris > --- > > .../bindings/devfreq/rk3399_dmc.yaml | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel