Re: [PATCH v3 2/2] devicetree: bindings THERMAL Add bindings doc for Sunplus SP7021

[Rob Herring <robh@kernel.org>]

On Tue, Jan 04, 2022 at 10:58:57AM +0800, Li-hao Kuo wrote:
> Add devicetree bindings THERMAL Add bindings doc for Sunplus SP7021

Complete sentences please.

For the subject:

'dt-bindings: thermal: Add Sunplus SP7021 schema'

> 
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
> Changes in v3:
>  - Modify Theraml driver
> 
>  .../bindings/thermal/sunplus_thermal.yaml          | 49 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> new file mode 100644
> index 0000000..e0290fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sunplus_thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus Thermal controller
> +
> +maintainers:
> +  - Li-hao Kuo <lhjeff911@gmail.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sunplus,sp7021-thermal
> +
> +  reg:
> +    maxItems: 1
> +
> +  reg-names:
> +    items:
> +      - const: reg
> +      - const: moon4

Is it 1 entry or 2? reg and reg-names don't agree. If 1, drop 
'reg-names'.

> +
> +  nvmem-cells:
> +    maxItems: 1
> +
> +  nvmem-cell-names:
> +    const: therm_calib

'therm_' is redundant.

> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - nvmem-cells
> +  - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    thermal@9c000280 {
> +        compatible = "sunplus,sp7021-thermal";
> +        reg = <0x9c000280 0x80>;
> +        nvmem-cells = <&therm_calib>;
> +        nvmem-cell-names = "therm_calib";
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4b02628..dd1b7bf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18246,6 +18246,7 @@ SUNPLUS THERMAL DRIVER
>  M:	Li-hao Kuo <lhjeff911@gmail.com>
>  L:	linux-pm@vger.kernel.org
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
>  F:	drivers/thermal/sunplus_thermal.c
>  
>  SUPERH
> -- 
> 2.7.4
> 
>