Re: [PULL 00/13] Net patches

[Roman Bolshakov <roman@roolebo.dev>]

On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote:
> 
> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
> > 
> > 
> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang <jasowang@redhat.com>:
> > 
> >     On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
> >     <peter.maydell@linaro.org> wrote:
> >     >
> >     > On Mon, 10 Jan 2022 at 03:40, Jason Wang <jasowang@redhat.com>
> >     wrote:
> >     > >
> >     > > The following changes since commit
> >     df722e33d5da26ea8604500ca8f509245a0ea524:
> >     > >
> >     > >   Merge tag 'bsd-user-arm-pull-request' of
> >     gitlab.com:bsdimp/qemu into staging (2022-01-08 09:37:59 -0800)
> >     > >
> >     > > are available in the git repository at:
> >     > >
> >     > > https://github.com/jasowang/qemu.git tags/net-pull-request
> >     > >
> >     > > for you to fetch changes up to
> >     5136cc6d3b8b74f4fa572f0874656947a401330e:
> >     > >
> >     > >   net/vmnet: update MAINTAINERS list (2022-01-10 11:30:55 +0800)
> >     > >
> >     > > ----------------------------------------------------------------
> >     > >
> >     > > ----------------------------------------------------------------
> >     >
> >     > Fails to build on OSX Catalina:
> >     >
> >     > ../../net/vmnet-common.m:165:10: error: use of undeclared identifier
> >     > 'VMNET_SHARING_SERVICE_BUSY'
> >     >     case VMNET_SHARING_SERVICE_BUSY:
> >     >          ^
> >     >
> >     > This constant only got added in macOS 11.0. I guess that technically
> >     > our supported-platforms policy only requires us to support 11
> >     (Big Sur)
> >     > and 12 (Monterey) at this point, but it would be nice to still
> >     be able
> >     > to build on Catalina (10.15).
> > 
> >     Yes, it was only supported by the vmnet framework starting from
> >     Catalyst according to
> >     https://developer.apple.com/documentation/vmnet?language=objc.
> > 
> > 
> > Yes, there are some symbols from macOS >= 11.0 new backend
> > uses, not only this one, ex. vmnet_enable_isolation_key:
> > https://developer.apple.com/documentation/vmnet/vmnet_enable_isolation_key
> > 
> >     >
> >     > (Personally I would like Catalina still to work at least for a
> >     little
> >     > while, because my x86 Mac is old enough that it is not supported by
> >     > Big Sur. I'll have to dump it once Apple stops doing security
> >     support
> >     > for Catalina, but they haven't done that quite yet.)
> > 
> > 
> > Sure, broken builds on old macOSes are bad. For this case I think
> > it's enough to disable vmnet for macOS < 11.0 with a probe while
> > configure build step. Especially given that Apple supports ~three
> > latest macOS versions, support for Catalina is expected to end
> > in 2022, when QEMU releases 7.0.
> 
> 
> That should be fine.
> 

I agree with Peter on this,

There's a lot of hardware running with Catalina. I think it's useful to
support it a little longer.

Regards,
Roman

> 
> > 
> > If this workaround is not suitable and it's required to support vmnet
> > in Catalina 10.15 with a subset of available features, it can be done.
> > But I'll be ready to handle this in approximately two-three weeks only.
> > 
> >     Sure, Vladislav please fix this and send a new version.
> > 
> > 
> > Quick fix as described above is available in v10:
> > https://patchew.org/QEMU/20220111211422.21789-1-yaroshchuk2000@gmail.com/
> 
> 
> Have you got chance to test that for macOS < 11.0?
> 
> Thanks
> 
> 
> >     Thanks
> > 
> >     >
> >     > -- PMM
> >     >
> > 
> > 
> > 
> > 
> > -- 
> > Best Regards,
> > 
> > Vladislav Yaroshchuk
> 
>