From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Thierry Reding <treding@nvidia.com>,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 1/1] gpio: tegra: Get rid of duplicate of_node assignment
Date: Wed, 12 Jan 2022 15:48:25 +0200 [thread overview]
Message-ID: <Yd7cKeGk4CzG3gAX@smile.fi.intel.com> (raw)
In-Reply-To: <Yd7TkUKo2g2Asbna@orome>
On Wed, Jan 12, 2022 at 02:11:45PM +0100, Thierry Reding wrote:
> On Thu, Dec 23, 2021 at 02:26:39PM +0200, Andy Shevchenko wrote:
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove these assignment all at once.
...
> Yep, this is indeed not necessary (anymore), so:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
>
> I've also given this a quick spin on a Tegra124 device (Venice 2) and
> everything seems to be working fine, so also:
>
> Tested-by: Thierry Reding <treding@nvidia.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-01-12 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 12:26 [PATCH v1 1/1] gpio: tegra: Get rid of duplicate of_node assignment Andy Shevchenko
2022-01-05 14:23 ` Andy Shevchenko
2022-01-06 8:42 ` Bartosz Golaszewski
2022-01-24 15:10 ` Andy Shevchenko
2022-01-12 13:11 ` Thierry Reding
2022-01-12 13:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd7cKeGk4CzG3gAX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.