From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Wed, 12 Jan 2022 17:20:44 +0000 Subject: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat In-Reply-To: <20220111031933.GB2175@gao-cwp> References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA07CC433EF for ; Wed, 12 Jan 2022 17:48:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 59E3B4B266; Wed, 12 Jan 2022 12:48:40 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NkJSQeDxf361; Wed, 12 Jan 2022 12:48:39 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3FD8A4B249; Wed, 12 Jan 2022 12:48:39 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 410AA4B23D for ; Wed, 12 Jan 2022 12:20:51 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g75uAD4G6ECS for ; Wed, 12 Jan 2022 12:20:50 -0500 (EST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4311C4B238 for ; Wed, 12 Jan 2022 12:20:50 -0500 (EST) Received: by mail-pj1-f51.google.com with SMTP id o3so6340539pjs.1 for ; Wed, 12 Jan 2022 09:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=iD4ax0W/ZQejkpiTV+wC/BTGkgvydCG1+oy9k4x41xcYsxdOIrYBD3Jg5pNLFotLn3 4lS1DP/A5h5rWv9t8jIgjAfIWRHyWSXlvlM7IaIgxX7hDAUmIgxXIoU5b+8CgT0R9dt0 iCbsvCcrQj4kpbl/NpitUUKIbg7rTypIFxqdxfB2feMrGc8niiEgwy4Jncc/4d2meNQg hKQ5yFTrProqxoFW6AG+GqRq3CQHFwiDeSswlB6x17ayzfA94e4NsXmAcxNN0/DUQR5b DQXQiXIgM3bNMe/5PUo8aj95UIBHAUjKy79FkjU/HbhRpV61hkglUgnEV5dHn1QxLypF YTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=t+MM7mjJ14cvfPZ4APUrEDgG3RITY/tXaPBgxVlHvM9kqaD64zz3fQOVOKfORyji1e tGQPNllmDFxstF0Hfvj0jflAav2OE3n2iUkFqOpXm11eHXeqEQLv6cto9blvybsQ3B8R yLd3rLS/f2fQvMNdJWSea0BTuVvlzAxtk79WAiub8+7NFBCvEdEtElwlkZjr1BwPWkrZ LGJHAKZ1rKG0x6ffrCYOglKHXQglq9elgAl+VV7y2+0UvSiV+NqgvlmlN0/6+ruvZHKy xiwFQwfnbWTnuBkBAv0Yhe+PGobfwIrn1pZ0kZltX2+AXDwClQaRULQaKz+AbCuJ06jv pCCA== X-Gm-Message-State: AOAM530kxA36a6t9+ljf/y7W0V7BfbvBMNzGmahYc1h0dfkaWEs4tSDU +kFESKTcj97ZvT+jcRnxQ8ZQTA== X-Google-Smtp-Source: ABdhPJzSQE5HuAs9ufGKv8GVZpWcgq8Jooiv84LWQSj+pdxhdpdaB4H7DHBA1IqNFc1FS00InVj1vA== X-Received: by 2002:a05:6a00:2442:b0:4bc:e7ac:b5aa with SMTP id d2-20020a056a00244200b004bce7acb5aamr553091pfj.56.1642008049112; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id kb1sm266614pjb.45.2022.01.12.09.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:20:48 -0800 (PST) Date: Wed, 12 Jan 2022 17:20:44 +0000 From: Sean Christopherson To: Chao Gao Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220111031933.GB2175@gao-cwp> X-Mailman-Approved-At: Wed, 12 Jan 2022 12:48:38 -0500 Cc: x86@kernel.org, Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Benjamin Herrenschmidt , Dave Hansen , linux-mips@vger.kernel.org, Atish Patra , Paul Mackerras , "H. Peter Anvin" , Alexander Gordeev , Claudio Imbrenda , Will Deacon , "Maciej S. Szmigiero" , linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Aleksandar Markovic , Ingo Molnar , Catalin Marinas , Palmer Dabbelt , Christian Borntraeger , Ravi Bangoria , kevin.tian@intel.com, Albert Ou , Vasily Gorbik , Heiko Carstens , Nicholas Piggin , Borislav Petkov , =?iso-8859-1?Q?C=E9dric?= Le Goater , Paul Walmsley , tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, Jim Mattson , Thomas Bogendoerfer , Fabiano Rosas , Anup Patel , linux-kernel@vger.kernel.org, Bharata B Rao , kvm-riscv@lists.infradead.org, Michael Ellerman , pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A81C433F5 for ; Wed, 12 Jan 2022 17:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355539AbiALRU6 (ORCPT ); Wed, 12 Jan 2022 12:20:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355542AbiALRUv (ORCPT ); Wed, 12 Jan 2022 12:20:51 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF015C061748 for ; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id hv15so6283022pjb.5 for ; Wed, 12 Jan 2022 09:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=iD4ax0W/ZQejkpiTV+wC/BTGkgvydCG1+oy9k4x41xcYsxdOIrYBD3Jg5pNLFotLn3 4lS1DP/A5h5rWv9t8jIgjAfIWRHyWSXlvlM7IaIgxX7hDAUmIgxXIoU5b+8CgT0R9dt0 iCbsvCcrQj4kpbl/NpitUUKIbg7rTypIFxqdxfB2feMrGc8niiEgwy4Jncc/4d2meNQg hKQ5yFTrProqxoFW6AG+GqRq3CQHFwiDeSswlB6x17ayzfA94e4NsXmAcxNN0/DUQR5b DQXQiXIgM3bNMe/5PUo8aj95UIBHAUjKy79FkjU/HbhRpV61hkglUgnEV5dHn1QxLypF YTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=WUa6AXVAdV3YGjtWJiLuZpBpBA2PErIjQX36eCobvauxCvwytgW2qYcKc68GNjCeSo 79CTEfSoxylJkP6BFIl+6G/E3aM3NBAZ2wLZZPu5aLeArksI2+7XqhBK8L1UgWhTFKpj w0roN/q+PLLqh/32vU3D76GynY5muWk5Qp7CB+y/tjo6GlNFLH86QWJXbESXnaUcUI7H WVSInnhDGILyq5H7V4iqKVxim5TcVByhLeYoViTHo8iclpIwLjpKguJ78duHsIdjYp1o oGrXiY8q1XRuECxw8cK/cHRKMU/H+wEtQLs99N7bJCSUmBuTRtKEnNSib6yEvK1NNdUZ 5QFQ== X-Gm-Message-State: AOAM532/p0CYe0Tc1TVExiffOW8tqaGGwB6v4CdYQ5bN3Ivw6uSRYurP 3hMbIc1QBcdZ4B9qf3AYSdXN0g== X-Google-Smtp-Source: ABdhPJzSQE5HuAs9ufGKv8GVZpWcgq8Jooiv84LWQSj+pdxhdpdaB4H7DHBA1IqNFc1FS00InVj1vA== X-Received: by 2002:a05:6a00:2442:b0:4bc:e7ac:b5aa with SMTP id d2-20020a056a00244200b004bce7acb5aamr553091pfj.56.1642008049112; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id kb1sm266614pjb.45.2022.01.12.09.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:20:48 -0800 (PST) Date: Wed, 12 Jan 2022 17:20:44 +0000 From: Sean Christopherson To: Chao Gao Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kevin.tian@intel.com, tglx@linutronix.de, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , David Hildenbrand , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Maciej S. Szmigiero" , Fabiano Rosas , Ravi Bangoria , =?iso-8859-1?Q?C=E9dric?= Le Goater , Bharata B Rao , Nicholas Piggin , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111031933.GB2175@gao-cwp> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A948BC433F5 for ; Wed, 12 Jan 2022 17:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZtYUm6xWoJSXlvMzfJRZiiUVpkyVw23WxGazEyFenAQ=; b=YXxFWVbPIyOf5F Hlx+KmyHU8m+F0pw5yfaNtCkpc52wI1iivj3xVK8VXDSIUEm9hEn4lxdz+WTd3gVZ6WhuLjWo2mMp 3wD9kjMigosh9JO7lR2WkSdpWzSE7+9zao8e1jZ8nP1xkeZmE40/Xar85YOWahYgmVXa94xGG6JPD 7ZdV3pKh2W+6DRxt0+8mb2tQHt3wXKipq5PrLav6afMN8x0SjYKtyZ2oetKAX6B/JFoX0D8sTNTUG Jyn+NrNsr+8L4dK5j4iM+3MiTt/vp871/jxs/O1jWcaR9UXSCWN4p0iLVb+KJhck+4h1kM1QaW7jU ARQjnHhpMkBRHcSmYOMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7hIr-003DgT-Mw; Wed, 12 Jan 2022 17:20:53 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7hIo-003Df9-6I for linux-riscv@lists.infradead.org; Wed, 12 Jan 2022 17:20:52 +0000 Received: by mail-pj1-x1035.google.com with SMTP id pf13so6412929pjb.0 for ; Wed, 12 Jan 2022 09:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=iD4ax0W/ZQejkpiTV+wC/BTGkgvydCG1+oy9k4x41xcYsxdOIrYBD3Jg5pNLFotLn3 4lS1DP/A5h5rWv9t8jIgjAfIWRHyWSXlvlM7IaIgxX7hDAUmIgxXIoU5b+8CgT0R9dt0 iCbsvCcrQj4kpbl/NpitUUKIbg7rTypIFxqdxfB2feMrGc8niiEgwy4Jncc/4d2meNQg hKQ5yFTrProqxoFW6AG+GqRq3CQHFwiDeSswlB6x17ayzfA94e4NsXmAcxNN0/DUQR5b DQXQiXIgM3bNMe/5PUo8aj95UIBHAUjKy79FkjU/HbhRpV61hkglUgnEV5dHn1QxLypF YTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=Wpoqqgen/EwwlJM+uucQr1fefTr8e/OG4Bz67vEGKhMeHPlBVvWOz4Ut4VNaFtvqTm 1zO0ABP0JxkA8x21OPYFBOhWFV2FBu8bvwdilod5Pfuz/NnWpjY4iQ6AdxZhxiZOAVf1 VcUzkmp9rrl9Z5yrw04CV3Nt33B067SO9jOxdIioCC2YqnwA+piGKloXLnjcGvT1ksP/ Czt4wrWW44Eg2TP2yOyFrZJYSzGZ6XRRapfftY8/DN9uuuhQlUHui5LyzzAJbR+Br8yw GdxcGiQMTTfnJNxnIUxMXskhvZcTf+j9xO/4Rs6oJyebHSHQQGVaNyXKkC/5p01N/4f4 8oVw== X-Gm-Message-State: AOAM533oXZauAOj/kipfODpiCwuG5z9/ROwKN9QMqidaoMSAe8MvaXTT vtT7/jMcc8hgdN0kGu03XF/0OA== X-Google-Smtp-Source: ABdhPJzSQE5HuAs9ufGKv8GVZpWcgq8Jooiv84LWQSj+pdxhdpdaB4H7DHBA1IqNFc1FS00InVj1vA== X-Received: by 2002:a05:6a00:2442:b0:4bc:e7ac:b5aa with SMTP id d2-20020a056a00244200b004bce7acb5aamr553091pfj.56.1642008049112; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id kb1sm266614pjb.45.2022.01.12.09.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:20:48 -0800 (PST) Date: Wed, 12 Jan 2022 17:20:44 +0000 From: Sean Christopherson To: Chao Gao Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kevin.tian@intel.com, tglx@linutronix.de, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , David Hildenbrand , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Maciej S. Szmigiero" , Fabiano Rosas , Ravi Bangoria , =?iso-8859-1?Q?C=E9dric?= Le Goater , Bharata B Rao , Nicholas Piggin , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220111031933.GB2175@gao-cwp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_092050_305760_2ED699C6 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 694A4C433EF for ; Wed, 12 Jan 2022 17:21:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JYvVf6Kx3z3bcT for ; Thu, 13 Jan 2022 04:21:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=iD4ax0W/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::630; helo=mail-pl1-x630.google.com; envelope-from=seanjc@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=iD4ax0W/; dkim-atps=neutral Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JYvTy5MF8z2xsG for ; Thu, 13 Jan 2022 04:20:53 +1100 (AEDT) Received: by mail-pl1-x630.google.com with SMTP id g5so4884086plo.12 for ; Wed, 12 Jan 2022 09:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=iD4ax0W/ZQejkpiTV+wC/BTGkgvydCG1+oy9k4x41xcYsxdOIrYBD3Jg5pNLFotLn3 4lS1DP/A5h5rWv9t8jIgjAfIWRHyWSXlvlM7IaIgxX7hDAUmIgxXIoU5b+8CgT0R9dt0 iCbsvCcrQj4kpbl/NpitUUKIbg7rTypIFxqdxfB2feMrGc8niiEgwy4Jncc/4d2meNQg hKQ5yFTrProqxoFW6AG+GqRq3CQHFwiDeSswlB6x17ayzfA94e4NsXmAcxNN0/DUQR5b DQXQiXIgM3bNMe/5PUo8aj95UIBHAUjKy79FkjU/HbhRpV61hkglUgnEV5dHn1QxLypF YTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QRCI1RlLdVZvt5lKUzeK60PXJ4E91izm9CxbrCuYWiw=; b=s9TFKM5PFMSPGth9GcXMu7rTBLhn2+tOMK9RfIMQfin15jzK2TuttPFrswUUn1lazY SmqsVb+9rMLeciSrjpWc5f/lVK+2454ROYG0w9eF4OKdNQLjvV8NsUkLpSH6aRryByqz lZyE6YFwdVXniG98yRC4ED1qX/+o+T80W2BzQ+2hZ5ABvSTR+YVJu7TSZOx6QpVbsgGY 8uio+m01VS1E4SuCzoHvgLNe1KMtuZ8MfYaGZ+SJ8yLdnl2rZHdOq8i8gZHDHTFMt9Tq LfhLfS6qYb20XoAkAXqbQFMVIiwKxOmXuS2v87EPYJBvFBhO5P4eP7h+LrZmfLXwlr8q 67qQ== X-Gm-Message-State: AOAM530AVOiWYWG1x6/RauPHtxVaa+Bj/mL0noyU6j0lGFMafFvru1OB 35/EJlhIen4kZtP7iTtpsM4meA== X-Google-Smtp-Source: ABdhPJzSQE5HuAs9ufGKv8GVZpWcgq8Jooiv84LWQSj+pdxhdpdaB4H7DHBA1IqNFc1FS00InVj1vA== X-Received: by 2002:a05:6a00:2442:b0:4bc:e7ac:b5aa with SMTP id d2-20020a056a00244200b004bce7acb5aamr553091pfj.56.1642008049112; Wed, 12 Jan 2022 09:20:49 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id kb1sm266614pjb.45.2022.01.12.09.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:20:48 -0800 (PST) Date: Wed, 12 Jan 2022 17:20:44 +0000 From: Sean Christopherson To: Chao Gao Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111031933.GB2175@gao-cwp> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Dave Hansen , linux-mips@vger.kernel.org, Atish Patra , Paul Mackerras , "H. Peter Anvin" , Alexander Gordeev , Claudio Imbrenda , Will Deacon , "Maciej S. Szmigiero" , linux-s390@vger.kernel.org, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Aleksandar Markovic , Ingo Molnar , Catalin Marinas , Palmer Dabbelt , Christian Borntraeger , Ravi Bangoria , kevin.tian@intel.com, Albert Ou , Vasily Gorbik , Suzuki K Poulose , Heiko Carstens , Nicholas Piggin , Borislav Petkov , =?iso-8859-1?Q?C=E9dric?= Le Goater , Paul Walmsley , tglx@linutronix.de, Alexandru Elisei , linux-arm-kernel@lists.infradead.org, Jim Mattson , Thomas Bogendoerfer , Fabiano Rosas , Anup Patel , linux-kernel@vger.kernel.org, Bharata B Rao , James Morse , kvm-riscv@lists.infradead.org, pbonzini@redhat.com, Vitaly Kuznetsov , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jan 11, 2022, Chao Gao wrote: > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > >On Mon, Dec 27, 2021, Chao Gao wrote: > >> No arch implementation uses this opaque now. > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > >is manually modified as RISC-V support came along in the interim. > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > plus manual changes to RISC-V. Given that, "process it as a revert" means > clearly say in changelog that this commit contains a partial revert of commit > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > Right? What I meant is literally do git revert -s b99040853738 and then manually handle RISC-V.